From 1ee4104d6c62d3f434217c4a421b68869fe02926 Mon Sep 17 00:00:00 2001
From: B Tasker <88340935+btasker@users.noreply.github.com>
Date: Wed, 3 Jan 2024 16:38:14 +0000
Subject: [PATCH 1/3] fix: don't accept a password longer than 72 bytes

---
 .../containers/.LoginPageContents.tsx.kate-swp     | Bin 0 -> 80 bytes
 src/onboarding/containers/LoginPageContents.tsx    |   8 +++++++-
 2 files changed, 7 insertions(+), 1 deletion(-)
 create mode 100644 src/onboarding/containers/.LoginPageContents.tsx.kate-swp

diff --git a/src/onboarding/containers/.LoginPageContents.tsx.kate-swp b/src/onboarding/containers/.LoginPageContents.tsx.kate-swp
new file mode 100644
index 0000000000000000000000000000000000000000..14300a0f2bbf73e3bf5255b1707c6095a1bee248
GIT binary patch
literal 80
zcmZQzU=Z?7EJ;-eE>A2_aLdd|RWQ;sU|?Vn5&Zo0ak4K@^?9iWSszT5uZGBSEDiPq
W%4`8*79eJ<bq#ifi?D)36kGv^Q4^8?

literal 0
HcmV?d00001

diff --git a/src/onboarding/containers/LoginPageContents.tsx b/src/onboarding/containers/LoginPageContents.tsx
index 54a19f95f3..11f3e5e363 100644
--- a/src/onboarding/containers/LoginPageContents.tsx
+++ b/src/onboarding/containers/LoginPageContents.tsx
@@ -174,7 +174,13 @@ class LoginPageContents extends PureComponent<Props> {
     const {email, password} = this.state
 
     const emailError = email === '' ? 'Email is required' : ''
-    const passwordError = password === '' ? 'Password is required' : ''
+    const pwlen = new Blob([password]).size
+
+    if (pwlen > 72){
+      const passwordError = 'Password is longer than 72 bytes'
+    else {
+      const passwordError = password === '' ? 'Password is required' : ''
+    }
 
     const errors: ErrorObject = {
       emailError,

From 6d15bf641651573a439bd19145bd6de1b1cbce0b Mon Sep 17 00:00:00 2001
From: B Tasker <88340935+btasker@users.noreply.github.com>
Date: Wed, 3 Jan 2024 17:03:41 +0000
Subject: [PATCH 2/3] fix: add missing bracket (had fixed earlier but not
 saved)

---
 .../containers/.LoginPageContents.tsx.kate-swp     | Bin 80 -> 0 bytes
 src/onboarding/containers/LoginPageContents.tsx    |   2 +-
 2 files changed, 1 insertion(+), 1 deletion(-)
 delete mode 100644 src/onboarding/containers/.LoginPageContents.tsx.kate-swp

diff --git a/src/onboarding/containers/.LoginPageContents.tsx.kate-swp b/src/onboarding/containers/.LoginPageContents.tsx.kate-swp
deleted file mode 100644
index 14300a0f2bbf73e3bf5255b1707c6095a1bee248..0000000000000000000000000000000000000000
GIT binary patch
literal 0
HcmV?d00001

literal 80
zcmZQzU=Z?7EJ;-eE>A2_aLdd|RWQ;sU|?Vn5&Zo0ak4K@^?9iWSszT5uZGBSEDiPq
W%4`8*79eJ<bq#ifi?D)36kGv^Q4^8?

diff --git a/src/onboarding/containers/LoginPageContents.tsx b/src/onboarding/containers/LoginPageContents.tsx
index 11f3e5e363..2e3b49cfda 100644
--- a/src/onboarding/containers/LoginPageContents.tsx
+++ b/src/onboarding/containers/LoginPageContents.tsx
@@ -178,7 +178,7 @@ class LoginPageContents extends PureComponent<Props> {
 
     if (pwlen > 72){
       const passwordError = 'Password is longer than 72 bytes'
-    else {
+    } else {
       const passwordError = password === '' ? 'Password is required' : ''
     }
 

From 0b39f832ef5da39ae54faec1a5e2f06146d7dfbc Mon Sep 17 00:00:00 2001
From: B Tasker <88340935+btasker@users.noreply.github.com>
Date: Thu, 4 Jan 2024 16:20:49 +0000
Subject: [PATCH 3/3] chore: refactor to fix tests

---
 src/onboarding/containers/LoginPageContents.tsx | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/src/onboarding/containers/LoginPageContents.tsx b/src/onboarding/containers/LoginPageContents.tsx
index 2e3b49cfda..f4b9c09014 100644
--- a/src/onboarding/containers/LoginPageContents.tsx
+++ b/src/onboarding/containers/LoginPageContents.tsx
@@ -176,15 +176,13 @@ class LoginPageContents extends PureComponent<Props> {
     const emailError = email === '' ? 'Email is required' : ''
     const pwlen = new Blob([password]).size
 
-    if (pwlen > 72){
-      const passwordError = 'Password is longer than 72 bytes'
-    } else {
-      const passwordError = password === '' ? 'Password is required' : ''
-    }
+    const passwordError = password === '' ? 'Password is required' : ''
+    const passwordLenError = pwlen > 72 ? 'Password is longer than 72 bytes' : ''
 
     const errors: ErrorObject = {
       emailError,
       passwordError,
+      passwordLenError,
     }
 
     const isValid = Object.values(errors).every(error => error === '')