Skip to content

Commit 8302227

Browse files
authored
Reverts workaround for fsd issue in XR app settings (#3610)
# Description Previously a kit change caused a performance regression in IsaacLab. This has been resolved and now the work around can be reverted. ## Type of change - Bug fix (non-breaking change which fixes an issue) ## Checklist - [x] I have read and understood the [contribution guidelines](https://isaac-sim.github.io/IsaacLab/main/source/refs/contributing.html) - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./isaaclab.sh --format` - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file - [x] I have added my name to the `CONTRIBUTORS.md` or my name already exists there
1 parent e29641a commit 8302227

File tree

2 files changed

+0
-8
lines changed

2 files changed

+0
-8
lines changed

apps/isaaclab.python.xr.openxr.headless.kit

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -22,10 +22,6 @@ app.useFabricSceneDelegate = true
2222
# Temporary, should be enabled by default in Kit soon
2323
rtx.hydra.readTransformsFromFabricInRenderDelegate = true
2424

25-
# work around for kitxr issue
26-
app.hydra.renderSettings.useUsdAttributes = false
27-
app.hydra.renderSettings.useFabricAttributes = false
28-
2925
# xr optimizations
3026
xr.skipInputDeviceUSDWrites = true
3127
'rtx-transient'.resourcemanager.enableTextureStreaming = false

apps/isaaclab.python.xr.openxr.kit

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -32,10 +32,6 @@ app.useFabricSceneDelegate = true
3232
# Temporary, should be enabled by default in Kit soon
3333
rtx.hydra.readTransformsFromFabricInRenderDelegate = true
3434

35-
# work around for kitxr issue
36-
app.hydra.renderSettings.useUsdAttributes = false
37-
app.hydra.renderSettings.useFabricAttributes = false
38-
3935
# xr optimizations
4036
xr.skipInputDeviceUSDWrites = true
4137
'rtx-transient'.resourcemanager.enableTextureStreaming = false

0 commit comments

Comments
 (0)