fix ruff errors

Author: skshetry

dvc/api/dataset.py

@@ -64,3 +64,4 @@ def get(name: str) -> Union[DatachainDataset, DVCDataset, URLDataset]:
             for file in dataset.lock.files
         ]
         return URLDataset(type="url", files=files, path=versioned_path)
+    raise AssertionError("unreachable")

dvc/commands/check_ignore.py

@@ -16,7 +16,7 @@ def __init__(self, args):
 
     def _show_results(self, result: "CheckIgnoreResult"):
         if not result.match and not self.args.details:
-            return
+            return None
 
         if self.args.details:
             pattern_infos = result.pattern_infos

dvc/commands/dataset.py

@@ -83,7 +83,7 @@ def display(self, name: str, dataset: "Dataset", new: "Dataset"):
             return CmdDatasetAdd.display(name, new, action)
         if dataset == new:
             ui.write("[yellow]Nothing to update[/]", styled=True)
-            return
+            return None
 
         assert new.lock
 
@@ -112,6 +112,7 @@ def display(self, name: str, dataset: "Dataset", new: "Dataset"):
             assert new.type == "url"
             stats = diff_files(dataset.lock.files, new.lock.files)
             log_changes(stats)
+        return None
 
     def run(self):
         from difflib import get_close_matches

dvc/config.py

@@ -139,6 +139,7 @@ def get_dir(cls, level):
             return global_config_dir()
         if level == "system":
             return system_config_dir()
+        return None
 
     @cached_property
     def files(self) -> dict[str, str]:

dvc/database.py

@@ -84,7 +84,7 @@ def test_connection(self, onerror: Optional[Callable[[], Any]] = None) -> None:
         except Exception as exc:
             if callable(onerror):
                 onerror()
-            logger.exception(
+            logger.exception(  # noqa: LOG007
                 "Could not connect to the database. "
                 "Check your database credentials and try again.",
                 exc_info=False,

dvc/dvcfile.py

@@ -203,7 +203,7 @@ def dump(self, stage, **kwargs) -> None:
 
     def dump_stages(self, stages, **kwargs) -> None:
         if not stages:
-            return
+            return None
 
         assert len(stages) == 1, "SingleStageFile can only dump one stage."
         return self.dump(stages[0], **kwargs)

dvc/exceptions.py

@@ -9,7 +9,7 @@
     from dvc.stage import Stage
 
 
-class DvcException(Exception):
+class DvcException(Exception):  # noqa: N818
     """Base class for all dvc exceptions."""
 
     def __init__(self, msg, *args):

dvc/logger.py

@@ -55,7 +55,7 @@ def log_to_root(message, *args, **kwargs):
         setattr(logging, method_name, log_to_root)
 
 
-class LoggingException(Exception):
+class LoggingException(Exception):  # noqa: N818
     def __init__(self, record):
         msg = f"failed to log {record!s}"
         super().__init__(msg)

dvc/output.py

@@ -1473,12 +1473,13 @@ def merge_version_meta(
     ):
         """Merge version meta for files which are unchanged from other."""
         if not self.hash_info:
-            return
+            return None
         if self.hash_info.isdir:
             return self._merge_dir_version_meta(old_hi, old_obj)
         if self.hash_info != old_hi:
-            return
+            return None
         self.meta = old_meta
+        return None
 
     def _merge_dir_version_meta(
         self, old_hi: "HashInfo", old_obj: Optional[Union["HashFile", "Tree"]]

dvc/parsing/context.py

@@ -66,7 +66,7 @@ class ParamsLoadError(ContextError):
     pass
 
 
-class KeyNotInContext(ContextError, KeyError):
+class KeyNotInContext(ContextError, KeyError):  # noqa: N818
     def __init__(self, key: str) -> None:
         self.key: str = key
         super().__init__(f"Could not find '{key}'")
@@ -75,7 +75,7 @@ def __str__(self):
         return self.msg
 
 
-class VarsAlreadyLoaded(ContextError):
+class VarsAlreadyLoaded(ContextError):  # noqa: N818
     pass
 
 
@@ -272,7 +272,7 @@ def __setitem__(self, key, value):
         if not isinstance(key, str):
             # limitation for the interpolation
             # ignore other kinds of keys
-            return
+            return None
         return super().__setitem__(key, value)
 
     def merge_update(self, other, overwrite=False):