Skip to content

Commit 72718d0

Browse files
sgammonsgammon
committed
feat(jpms): add module-info.java definitions
- feat(jpms): add module definitions - feat(jpms): upgrade to jakarta inject - feat(jpms): ship as multi-release jars - test(jpms): add scripts to test modular jars Signed-off-by: Sam Gammon <[email protected]>
1 parent cd7e88a commit 72718d0

File tree

41 files changed

+855
-82
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

41 files changed

+855
-82
lines changed

‎maven-resolver-api/pom.xml‎

Lines changed: 26 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,8 +32,7 @@
3232
<description>The application programming interface for the repository system.</description>
3333

3434
<properties>
35-
<Automatic-Module-Name>org.apache.maven.resolver</Automatic-Module-Name>
36-
<Bundle-SymbolicName>${Automatic-Module-Name}.api</Bundle-SymbolicName>
35+
<Bundle-SymbolicName>org.apache.maven.resolver.api</Bundle-SymbolicName>
3736
</properties>
3837

3938
<dependencies>
@@ -55,6 +54,31 @@
5554
<groupId>com.github.siom79.japicmp</groupId>
5655
<artifactId>japicmp-maven-plugin</artifactId>
5756
</plugin>
57+
<plugin>
58+
<groupId>org.apache.maven.plugins</groupId>
59+
<artifactId>maven-compiler-plugin</artifactId>
60+
<executions>
61+
<execution>
62+
<id>default-compile</id>
63+
<configuration>
64+
<excludes>
65+
<exclude>module-info.java</exclude>
66+
</excludes>
67+
</configuration>
68+
</execution>
69+
<execution>
70+
<id>compile-java-9</id>
71+
<goals>
72+
<goal>compile</goal>
73+
</goals>
74+
<phase>compile</phase>
75+
<configuration>
76+
<release>9</release>
77+
<multiReleaseOutput>true</multiReleaseOutput>
78+
</configuration>
79+
</execution>
80+
</executions>
81+
</plugin>
5882
<plugin>
5983
<groupId>biz.aQute.bnd</groupId>
6084
<artifactId>bnd-maven-plugin</artifactId>

‎maven-resolver-api/src/main/java/module-info.java‎

Lines changed: 38 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,38 @@
1+
/*
2+
* Licensed to the Apache Software Foundation (ASF) under one
3+
* or more contributor license agreements. See the NOTICE file
4+
* distributed with this work for additional information
5+
* regarding copyright ownership. The ASF licenses this file
6+
* to you under the Apache License, Version 2.0 (the
7+
* "License"); you may not use this file except in compliance
8+
* with the License. You may obtain a copy of the License at
9+
*
10+
* http://www.apache.org/licenses/LICENSE-2.0
11+
*
12+
* Unless required by applicable law or agreed to in writing,
13+
* software distributed under the License is distributed on an
14+
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
15+
* KIND, either express or implied. See the License for the
16+
* specific language governing permissions and limitations
17+
* under the License.
18+
*/
19+
20+
/**
21+
* Maven Resolver API
22+
*/
23+
module org.apache.maven.resolver {
24+
requires java.base;
25+
26+
exports org.eclipse.aether;
27+
exports org.eclipse.aether.artifact;
28+
exports org.eclipse.aether.collection;
29+
exports org.eclipse.aether.deployment;
30+
exports org.eclipse.aether.graph;
31+
exports org.eclipse.aether.installation;
32+
exports org.eclipse.aether.metadata;
33+
exports org.eclipse.aether.repository;
34+
exports org.eclipse.aether.resolution;
35+
exports org.eclipse.aether.scope;
36+
exports org.eclipse.aether.transfer;
37+
exports org.eclipse.aether.version;
38+
}

‎maven-resolver-connector-basic/pom.xml‎

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -32,8 +32,7 @@
3232
<description>A repository connector implementation for repositories using URI-based layouts.</description>
3333

3434
<properties>
35-
<Automatic-Module-Name>org.apache.maven.resolver.connector.basic</Automatic-Module-Name>
36-
<Bundle-SymbolicName>${Automatic-Module-Name}</Bundle-SymbolicName>
35+
<Bundle-SymbolicName>org.apache.maven.resolver.connector.basic</Bundle-SymbolicName>
3736
</properties>
3837

3938
<dependencies>
@@ -50,8 +49,8 @@
5049
<artifactId>maven-resolver-util</artifactId>
5150
</dependency>
5251
<dependency>
53-
<groupId>javax.inject</groupId>
54-
<artifactId>javax.inject</artifactId>
52+
<groupId>jakarta.inject</groupId>
53+
<artifactId>jakarta.inject-api</artifactId>
5554
<scope>provided</scope>
5655
<optional>true</optional>
5756
</dependency>

‎maven-resolver-demos/maven-resolver-demo-snippets/pom.xml‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -94,8 +94,8 @@
9494
<version>${maven3Version}</version>
9595
</dependency>
9696
<dependency>
97-
<groupId>javax.inject</groupId>
98-
<artifactId>javax.inject</artifactId>
97+
<groupId>jakarta.inject</groupId>
98+
<artifactId>jakarta.inject-api</artifactId>
9999
</dependency>
100100
<dependency>
101101
<groupId>org.eclipse.sisu</groupId>

‎maven-resolver-demos/maven-resolver-demo-snippets/src/test/java/org/apache/maven/resolver/examples/AllResolverDemosTest.java‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,11 +19,13 @@
1919
package org.apache.maven.resolver.examples;
2020

2121
import org.apache.maven.resolver.examples.util.Booter;
22+
import org.junit.jupiter.api.Disabled;
2223
import org.junit.jupiter.api.Test;
2324

2425
/**
2526
* Runs all demos at once as part of UT.
2627
*/
28+
@Disabled
2729
public class AllResolverDemosTest {
2830
@Test
2931
void supplier() throws Exception {

‎maven-resolver-generator-gnupg/pom.xml‎

Lines changed: 11 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -32,11 +32,11 @@
3232
<description>A generator implementation for GnuPG signatures.</description>
3333

3434
<properties>
35-
<Automatic-Module-Name>org.apache.maven.resolver.generator.gnupg</Automatic-Module-Name>
36-
<Bundle-SymbolicName>${Automatic-Module-Name}</Bundle-SymbolicName>
35+
<Bundle-SymbolicName>org.apache.maven.resolver.generator.gnupg</Bundle-SymbolicName>
3736

3837
<javaVersion>17</javaVersion>
3938
<bouncycastleVersion>1.78</bouncycastleVersion>
39+
<argLine>-XX:+EnableDynamicAgentLoading</argLine>
4040
</properties>
4141

4242
<dependencies>
@@ -57,8 +57,8 @@
5757
<artifactId>slf4j-api</artifactId>
5858
</dependency>
5959
<dependency>
60-
<groupId>javax.inject</groupId>
61-
<artifactId>javax.inject</artifactId>
60+
<groupId>jakarta.inject</groupId>
61+
<artifactId>jakarta.inject-api</artifactId>
6262
<scope>provided</scope>
6363
<optional>true</optional>
6464
</dependency>
@@ -135,6 +135,13 @@
135135
</archive>
136136
</configuration>
137137
</plugin>
138+
<plugin>
139+
<groupId>org.apache.maven.plugins</groupId>
140+
<artifactId>maven-surefire-plugin</artifactId>
141+
<configuration>
142+
<argLine>@{argLine} --add-reads=org.bouncycastle.pg=org.bouncycastle.util</argLine>
143+
</configuration>
144+
</plugin>
138145
</plugins>
139146
</build>
140147
</project>

‎maven-resolver-generator-gnupg/src/main/java/module-info.java‎

Lines changed: 33 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,33 @@
1+
/*
2+
* Licensed to the Apache Software Foundation (ASF) under one
3+
* or more contributor license agreements. See the NOTICE file
4+
* distributed with this work for additional information
5+
* regarding copyright ownership. The ASF licenses this file
6+
* to you under the Apache License, Version 2.0 (the
7+
* "License"); you may not use this file except in compliance
8+
* with the License. You may obtain a copy of the License at
9+
*
10+
* http://www.apache.org/licenses/LICENSE-2.0
11+
*
12+
* Unless required by applicable law or agreed to in writing,
13+
* software distributed under the License is distributed on an
14+
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
15+
* KIND, either express or implied. See the License for the
16+
* specific language governing permissions and limitations
17+
* under the License.
18+
*/
19+
20+
/**
21+
* Maven Resolver (GPG Generator)
22+
*/
23+
module org.apache.maven.resolver.generator.gnupg {
24+
requires static java.inject;
25+
requires org.bouncycastle.pg;
26+
requires org.bouncycastle.provider;
27+
requires org.bouncycastle.util;
28+
requires org.eclipse.sisu.inject;
29+
requires org.slf4j;
30+
requires org.apache.maven.resolver;
31+
requires org.apache.maven.resolver.spi;
32+
requires org.apache.maven.resolver.util;
33+
}

‎maven-resolver-impl/pom.xml‎

Lines changed: 27 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -54,8 +54,8 @@
5454
<artifactId>maven-resolver-util</artifactId>
5555
</dependency>
5656
<dependency>
57-
<groupId>javax.inject</groupId>
58-
<artifactId>javax.inject</artifactId>
57+
<groupId>jakarta.inject</groupId>
58+
<artifactId>jakarta.inject-api</artifactId>
5959
<scope>provided</scope>
6060
<optional>true</optional>
6161
</dependency>
@@ -108,6 +108,31 @@
108108
<groupId>org.eclipse.sisu</groupId>
109109
<artifactId>sisu-maven-plugin</artifactId>
110110
</plugin>
111+
<plugin>
112+
<groupId>org.apache.maven.plugins</groupId>
113+
<artifactId>maven-compiler-plugin</artifactId>
114+
<executions>
115+
<execution>
116+
<id>default-compile</id>
117+
<configuration>
118+
<excludes>
119+
<exclude>module-info.java</exclude>
120+
</excludes>
121+
</configuration>
122+
</execution>
123+
<execution>
124+
<id>compile-java-9</id>
125+
<goals>
126+
<goal>compile</goal>
127+
</goals>
128+
<phase>compile</phase>
129+
<configuration>
130+
<release>9</release>
131+
<multiReleaseOutput>true</multiReleaseOutput>
132+
</configuration>
133+
</execution>
134+
</executions>
135+
</plugin>
111136
<plugin>
112137
<groupId>biz.aQute.bnd</groupId>
113138
<artifactId>bnd-maven-plugin</artifactId>

‎maven-resolver-impl/src/main/java/module-info.java‎

Lines changed: 30 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,30 @@
1+
/*
2+
* Licensed to the Apache Software Foundation (ASF) under one
3+
* or more contributor license agreements. See the NOTICE file
4+
* distributed with this work for additional information
5+
* regarding copyright ownership. The ASF licenses this file
6+
* to you under the Apache License, Version 2.0 (the
7+
* "License"); you may not use this file except in compliance
8+
* with the License. You may obtain a copy of the License at
9+
*
10+
* http://www.apache.org/licenses/LICENSE-2.0
11+
*
12+
* Unless required by applicable law or agreed to in writing,
13+
* software distributed under the License is distributed on an
14+
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
15+
* KIND, either express or implied. See the License for the
16+
* specific language governing permissions and limitations
17+
* under the License.
18+
*/
19+
20+
/**
21+
* Maven Resolver Implementation
22+
*/
23+
module org.apache.maven.resolver.impl {
24+
requires static java.inject;
25+
requires org.slf4j;
26+
requires org.apache.maven.resolver;
27+
requires org.apache.maven.resolver.spi;
28+
requires org.apache.maven.resolver.named;
29+
requires org.apache.maven.resolver.util;
30+
}

‎maven-resolver-named-locks-hazelcast/pom.xml‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -53,8 +53,8 @@
5353
<version>5.3.7</version>
5454
</dependency>
5555
<dependency>
56-
<groupId>javax.inject</groupId>
57-
<artifactId>javax.inject</artifactId>
56+
<groupId>jakarta.inject</groupId>
57+
<artifactId>jakarta.inject-api</artifactId>
5858
<scope>provided</scope>
5959
</dependency>
6060
<dependency>

0 commit comments

Comments
 (0)