fix fixmes

Author: jdonszelmann

compiler/rustc_metadata/src/rmeta/mod.rs

@@ -258,7 +258,7 @@ pub(crate) struct CrateRoot {
     panic_in_drop_strategy: PanicStrategy,
     edition: Edition,
 
-    // TODO: these booleans can be replaced by the entries in `externally_implementable_items`
+    // FIXME(jdonszelmann): these booleans can be replaced by the entries in `externally_implementable_items`
     has_global_allocator: bool,
     has_alloc_error_handler: bool,
     has_default_lib_allocator: bool,

compiler/rustc_middle/src/middle/codegen_fn_attrs.rs

@@ -108,7 +108,7 @@ bitflags::bitflags! {
         /// `#[no_mangle]`: an indicator that the function's name should be the same
         /// as its symbol.
         const NO_MANGLE                 = 1 << 5;
-        // TODO: EIIs can replace this, most likely
+        // FIXME(jdonszelmann): EIIs can replace this, most likely
         /// `#[rustc_std_internal_symbol]`: an indicator that this symbol is a
         /// "weird symbol" for the standard library in that it has slightly
         /// different linkage, visibility, and reachability rules.

compiler/rustc_monomorphize/src/collector.rs

@@ -1535,7 +1535,7 @@ impl<'v> RootCollector<'_, 'v> {
 
                     self.entry_fn.and_then(|(id, _)| id.as_local()) == Some(def_id)
                         || self.tcx.is_reachable_non_generic(def_id)
-                        // TODO: EII might remove this:
+                        // FIXME(jdonszelmann): EII might remove this:
                         || cfa
                             .flags
                             .contains(CodegenFnAttrFlags::RUSTC_STD_INTERNAL_SYMBOL)

compiler/rustc_monomorphize/src/partitioning.rs

@@ -770,8 +770,6 @@ fn mono_item_linkage_and_visibility<'tcx>(
     // libraries. And shared libraries may later be linked together, both implementing the EII.
     // This conflicting implementations may show up. We want to ignore this and just link em
     // together anyway. LLVM ensures the last one is the one that's chosen
-    // TODO: this isn't the problem if they both decided to choose either the default or the
-    // same explicit impl but if their view on it differs it is a problem!
     if let MonoItem::Fn(Instance { def: InstanceKind::EiiShim { weak_linkage, .. }, .. }) =
         mono_item
     {
@@ -947,7 +945,7 @@ fn mono_item_visibility<'tcx>(
         //   LLVM internalize them as this decision is left up to the linker to
         //   omit them, so prevent them from being internalized.
         let attrs = tcx.codegen_fn_attrs(def_id);
-        // TODO: EII might replace this
+        // FIXME(jdonszelmann): EII might replace this
         if attrs.flags.contains(CodegenFnAttrFlags::RUSTC_STD_INTERNAL_SYMBOL) {
             *can_be_internalized = false;
         }