From dba6d85cf3e97015000ed0274f58996d95a0d553 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Alejandro=20Garci=CC=81a=20Iglesias?= Date: Thu, 11 Apr 2019 01:19:35 -0300 Subject: [PATCH] Remove svElement event listeners on $destroy --- src/angular-sortable-view.js | 25 +++++++++++++------------ 1 file changed, 13 insertions(+), 12 deletions(-) diff --git a/src/angular-sortable-view.js b/src/angular-sortable-view.js index 76e08bc..ed8ed2b 100644 --- a/src/angular-sortable-view.js +++ b/src/angular-sortable-view.js @@ -410,6 +410,7 @@ $controllers[1].addToSortableElements(sortableElement); $scope.$on('$destroy', function(){ $controllers[1].removeFromSortableElements(sortableElement); + html.off('mousemove touchmove', onMousemove); }); var handle = $element; @@ -520,20 +521,20 @@ } $element.removeClass('sv-visibility-hidden'); }); + } - // onMousemove(e); - function onMousemove(e){ - touchFix(e); - if(!moveExecuted){ - $element.parent().prepend(clone); - moveExecuted = true; - } - $controllers[1].$moveUpdate(opts, { - x: e.clientX, - y: e.clientY, - offset: pointerOffset - }, clone, $element, placeholder, $controllers[0].getPart(), $scope.$index); + // onMousemove(e); + function onMousemove(e){ + touchFix(e); + if(!moveExecuted){ + $element.parent().prepend(clone); + moveExecuted = true; } + $controllers[1].$moveUpdate(opts, { + x: e.clientX, + y: e.clientY, + offset: pointerOffset + }, clone, $element, placeholder, $controllers[0].getPart(), $scope.$index); } } };