Merge pull request #441 from kuzzleio/fix-base64-decoding-react-native

React Native does not have the Buffer class or the atob function to decode base64 payload.
This PR add a standalone base64 decoding function to ensure portability across platforms.

Author: Aschen

.travis.yml

@@ -183,6 +183,9 @@ jobs:
         email: [email protected]
         api_key:
           secure: ktfR6QVV59uCVLTfb60JSjPxzxg+UYe63pIGxU9awh1wJW89SQqQdeshHas3ojwrNoMOVybx/L6owtD8uIB4Xlau6pd7StBAA1VQ3vLa6RxU5SUr9VOz3RhZutRnYXH28Ziz/ynr6zVnwGxTzFsxBAdQ9CVS3ErBzliTgMVI+52YRNB3mBDiccSKVNGmp2APiWiaEidrmaOFkCwWQKsAxFTbBoCsDYGGAq8a8b1i2nE+BL4JWB1D2x55xzFaciDIQONXnY9YPAAbzCHBTKAne5iD6XwFj7Zg/42fHTn16LBSG+Sw+7aWyV11U6SJYKAjm/5GZEUrbvX/mwNQ7VYcvMStiP1nnt/L/s/Y7d0K3mwdsV8U8RCctElOeqLsDqoBzQYAxHTqRqJzyFNMcbcMhZgsHH5LgQDoJdKFwzP2ysYoazgm/jnr9atvlqucjWU8madRS34S8wD0zGjYf8VXH3WMUvL5mFwtb58FRCZKO3G7QJlGE8bdZ8CfJa/1tFnYY9SA0018GaXbh0RqQw0RskbmXEKTlnDBxaRd/ZjfaOjF4JcMGGZ8hsCRjxuDFY5Ki0kKDAlDV1W40fkkqPVm8k9H8Elwt0UFZvvAdjG4c+gV0zdAKHQ7P6uKvXiDlsKRHulE3Ztpo6jqGN69s7aLm6DKNVsaE4cNmmUOv3ODrM4=
+        on:
+          branch: master
+          tags: true
 
     - stage: Deploy Beta release on NPM
       if: type = push && branch =~ /^[0-9]+-dev$/

features/support/hooks.js

@@ -36,7 +36,7 @@ async function clean () {
   }
   catch (error) {
     // rethrow to get a readable error
-    console.error(error);
+    console.error(error); // eslint-disable-line no-console
     throw error;
   }
 

package-lock.json

@@ -1,6 +1,6 @@
 {
   "name": "kuzzle-sdk",
-  "version": "6.2.0",
+  "version": "6.2.1",
   "description": "Official Javascript SDK for Kuzzle",
   "author": "The Kuzzle Team <[email protected]>",
   "repository": {

package.json

@@ -1,15 +1,29 @@
 'use strict';
 
-// used for unit tests
-const browserAtob = base64 => atob(base64);
-const bufferAvailable = () => typeof Buffer !== 'undefined';
+// atob is not available in React Native
+// https://stackoverflow.com/questions/42829838/react-native-atob-btoa-not-working-without-remote-js-debugging
 
-const decodeBase64 = base64 => {
-  if (bufferAvailable()) {
-    return Buffer.from(base64, 'base64').toString();
+const base64Charset = 'ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789+/=';
+
+const decodeBase64 = input => {
+  const str = input.replace(/=+$/, '');
+  let output = '';
+
+  if (str.length % 4 === 1) {
+    throw new Error('Malformed base64 string.');
+  }
+
+  for (let bc = 0, bs = 0, buffer, i = 0;
+    buffer = str.charAt(i++); // eslint-disable-line no-cond-assign
+
+    ~buffer && (bs = bc % 4 ? bs * 64 + buffer : buffer, bc++ % 4)
+      ? output += String.fromCharCode(255 & bs >> (-2 * bc & 6))
+      : 0
+  ) {
+    buffer = base64Charset.indexOf(buffer);
   }
 
-  return browserAtob(base64);
+  return output;
 };
 
 class Jwt {
@@ -57,4 +71,4 @@ class Jwt {
   }
 }
 
-module.exports = Jwt;
+module.exports = Jwt;

src/core/Jwt.js

@@ -37,23 +37,6 @@ describe('Jwt', () => {
         new Jwt('this-is.not-json-payload.for-sure');
       }).throwError('Invalid JSON payload for JWT');
     });
-
-    it('should be able to decode the payload when Buffer is not available (browser)', () => {
-      Jwt.__set__('browserAtob', base64 => Buffer.from(base64, 'base64').toString());
-      Jwt.__set__('bufferAvailable', () => false);
-
-      const
-        expiresAt = Date.now() + 3600 * 1000,
-        encodedJwt = generateJwt('user-gordon', expiresAt);
-
-
-      authenticationToken = new Jwt(encodedJwt);
-
-      should(authenticationToken.encodedJwt).be.eql(encodedJwt);
-      should(authenticationToken.userId).be.eql('user-gordon');
-      should(authenticationToken.expiresAt).be.eql(expiresAt);
-      should(authenticationToken.expired).be.eql(false);
-    });
   });
 
   describe('#get expired', () => {