fix(jwt): use the same base64 decode for Node.js, browser and react native

Author: Aschen

features/support/hooks.js

@@ -36,7 +36,6 @@ async function clean () {
   }
   catch (error) {
     // rethrow to get a readable error
-    console.error(error);
     throw error;
   }
 

src/core/Jwt.js

@@ -1,15 +1,29 @@
 'use strict';
 
-// used for unit tests
-const browserAtob = base64 => atob(base64);
-const bufferAvailable = () => typeof Buffer !== 'undefined';
+// atob is not available in React Native
+// https://stackoverflow.com/questions/42829838/react-native-atob-btoa-not-working-without-remote-js-debugging
 
-const decodeBase64 = base64 => {
-  if (bufferAvailable()) {
-    return Buffer.from(base64, 'base64').toString();
+const base64Charset = 'ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789+/=';
+
+const decodeBase64 = input => {
+  const str = input.replace(/=+$/, '');
+  let output = '';
+
+  if (str.length % 4 === 1) {
+    throw new Error('Malformated base64 string.');
+  }
+
+  for (let bc = 0, bs = 0, buffer, i = 0;
+    buffer = str.charAt(i++); // eslint-disable-line no-cond-assign
+
+    ~buffer && (bs = bc % 4 ? bs * 64 + buffer : buffer, bc++ % 4)
+      ? output += String.fromCharCode(255 & bs >> (-2 * bc & 6))
+      : 0
+  ) {
+    buffer = base64Charset.indexOf(buffer);
   }
 
-  return browserAtob(base64);
+  return output;
 };
 
 class Jwt {

test/core/Jwt.test.js

@@ -37,23 +37,6 @@ describe('Jwt', () => {
         new Jwt('this-is.not-json-payload.for-sure');
       }).throwError('Invalid JSON payload for JWT');
     });
-
-    it('should be able to decode the payload when Buffer is not available (browser)', () => {
-      Jwt.__set__('browserAtob', base64 => Buffer.from(base64, 'base64').toString());
-      Jwt.__set__('bufferAvailable', () => false);
-
-      const
-        expiresAt = Date.now() + 3600 * 1000,
-        encodedJwt = generateJwt('user-gordon', expiresAt);
-
-
-      authenticationToken = new Jwt(encodedJwt);
-
-      should(authenticationToken.encodedJwt).be.eql(encodedJwt);
-      should(authenticationToken.userId).be.eql('user-gordon');
-      should(authenticationToken.expiresAt).be.eql(expiresAt);
-      should(authenticationToken.expired).be.eql(false);
-    });
   });
 
   describe('#get expired', () => {