temp debugging

Author: keelerm84

Makefile

@@ -1,4 +1,4 @@
-PYTEST_FLAGS=-W error::SyntaxWarning
+PYTEST_FLAGS=-W error::SyntaxWarning -s
 
 TEMP_TEST_OUTPUT=/tmp/contract-test-service.log
 
@@ -28,12 +28,12 @@ install:
 .PHONY: test
 test: #! Run unit tests
 test: install
-	@LD_SKIP_DATABASE_TESTS=1 poetry run pytest $(PYTEST_FLAGS)
+	@LD_SKIP_DATABASE_TESTS=1 poetry run pytest $(PYTEST_FLAGS) ldclient/testing/impl/datasystem/test_fdv2_datasystem.py::test_two_phase_init
 
 .PHONY: test-all
 test-all: #! Run unit tests (including database integrations)
 test-all: install
-	@poetry run pytest $(PYTEST_FLAGS)
+	@poetry run pytest $(PYTEST_FLAGS) ldclient/testing/impl/datasystem/test_fdv2_datasystem.py::test_two_phase_init
 
 .PHONY: lint
 lint: #! Run type analysis and linting checks

ldclient/impl/datasystem/fdv2.py

@@ -307,6 +307,7 @@ def _run_initializers(self, set_on_ready: Event):
                 log.info("Attempting to initialize via %s", initializer.name)
 
                 basis_result = initializer.fetch(self._store)
+                print("@@@@@@", "init", basis_result, "\n")
 
                 if isinstance(basis_result, _Fail):
                     log.warning("Initializer %s failed: %s", initializer.name, basis_result.error)
@@ -446,6 +447,7 @@ def _consume_synchronizer_results(
         def reader(self: 'FDv2'):
             try:
                 for update in synchronizer.sync(self._store):
+                    print("@@@@@@", "update is at", update, "\n")
                     action_queue.put(update)
             finally:
                 action_queue.put("quit")

ldclient/impl/datasystem/store.py

@@ -296,9 +296,12 @@ def _set_basis(
         # Take snapshot for change detection if we have flag listeners
         old_data: Optional[Collections] = None
         if self._flag_change_listeners.has_listeners():
+            print("@@@@", "we have flag listeners\n")
             old_data = {}
             for kind in [FEATURES, SEGMENTS]:
                 old_data[kind] = self._memory_store.all(kind, lambda x: x)
+        else:
+            print("@@@@", "we don't have flag listeners\n")
 
         ok = self._memory_store.set_basis(collections)
         if ok is False:
@@ -323,6 +326,7 @@ def _set_basis(
             affected_items = self._compute_changed_items_for_full_data_set(
                 old_data, collections
             )
+            print("@@@@@ affected items are", affected_items, "\n")
             self._send_change_events(affected_items)
 
     def _apply_delta(

ldclient/testing/impl/datasystem/test_fdv2_datasystem.py

@@ -27,25 +27,30 @@ def test_two_phase_init():
     set_on_ready = Event()
     fdv2 = FDv2(Config(sdk_key="dummy"), data_system_config)
 
-    changed = Event()
+    initialized = Event()
+    modified = Event()
     changes: List[FlagChange] = []
     count = 0
 
     def listener(flag_change: FlagChange):
         nonlocal count, changes
         count += 1
+        print("@@@@@ count", count, "\n")
         changes.append(flag_change)
 
+        if count == 1:
+            initialized.set()
         if count == 2:
-            changed.set()
+            modified.set()
 
     fdv2.flag_tracker.add_listener(listener)
 
     fdv2.start(set_on_ready)
     assert set_on_ready.wait(1), "Data system did not become ready in time"
+    assert initialized.wait(1), "Data system did not read from both initialization and synchronizer yet"
 
     td_synchronizer.update(td_synchronizer.flag("feature-flag").on(False))
-    assert changed.wait(1), "Flag change listener was not called in time"
+    assert modified.wait(1), "Data system did not read update from synchronizer"
     assert len(changes) == 2
     assert changes[0].key == "feature-flag"
     assert changes[1].key == "feature-flag"