Skip to content

Complete Lab #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Complete Lab #16

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 24 additions & 6 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,29 @@
function scuberGreetingForFeet(){
// Write your code here!
function scuberGreetingForFeet(number){
let result
if( number < 400 ) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if( number < 400 ) {
if (number < 400) {

result = 'This one is on me!';
} else if (number > 400 && number < 2000 ) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't need to include the > 400 bit since the first part of the conditional covers that.

Suggested change
} else if (number > 400 && number < 2000 ) {
} else if (number < 2000 ) {

result = 'That will be twenty bucks.';
} else if (number >= 2001 && number < 2500 ) {
result = 'I will gladly take your thirty bucks.';
} else if (number > 2500) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same idea here.

Suggested change
} else if (number > 2500) {
} else {

result = 'No can do.';
}
return result;
}

function ternaryCheckCity(){
// Write your code here!
function ternaryCheckCity(city){
const message = city === 'NYC' ? "Ok, sounds good." : "No go.";
return message;
Comment on lines +16 to +17
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While this works, you can simply return the ternary:

Suggested change
const message = city === 'NYC' ? "Ok, sounds good." : "No go.";
return message;
return city === 'NYC' ? 'Ok, sounds good.' : 'No go.;

Also, try to be consistent with using either single and double quotes, but not both.

}

function switchOnCharmFromTip(){
// Write your code here!
function switchOnCharmFromTip(tip){
switch(tip) {
case 'generous':
return 'Thank you so much.';
case 'not as generous':
return 'Thank you.';
default:
return 'Bye.'
}
}