print an error that wraps ExitError

Fix issue 4167

Signed-off-by: Akihiro Suda <[email protected]>

Author: AkihiroSuda

pkg/osutil/exit.go

@@ -4,18 +4,23 @@
 package osutil
 
 import (
-	"errors"
 	"os"
 	"os/exec"
 )
 
+// HandleExitError calls os.Exit immediately without printing an error, only if the error is an *exec.ExitError (non-nil).
+//
+// The function does not call os.Exit if the error is of any other type, even if it wraps an *exec.ExitError,
+// so that the caller can print the error message.
+// (i.e., fmt.Errorf("...: %w", &exec.ExitError{}))
 func HandleExitError(err error) {
 	if err == nil {
 		return
 	}
 
-	var exitErr *exec.ExitError
-	if errors.As(err, &exitErr) {
+	// Do not use errors.As, because we want to match only *exec.ExitError, not wrapped ones.
+	// https://github.com/lima-vm/lima/pull/4168
+	if exitErr, ok := err.(*exec.ExitError); ok {
 		os.Exit(exitErr.ExitCode()) //nolint:revive // it's intentional to call os.Exit in this function
 		return
 	}