Skip to content

Commit 53ab3e5

Browse files
committed
Apply reviews
- Remove wrong INFO message - Remove the `—progress` option. Signed-off-by: Norio Nomura <[email protected]>
1 parent 89ec621 commit 53ab3e5

File tree

4 files changed

+2
-6
lines changed

4 files changed

+2
-6
lines changed

cmd/limactl/delete.go

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -57,8 +57,6 @@ func deleteAction(cmd *cobra.Command, args []string) error {
5757
} else {
5858
logrus.Infof("The autostart entry for instance %q has been unregistered", instName)
5959
}
60-
} else {
61-
logrus.Infof("The autostart entry for instance %q is not registered", instName)
6260
}
6361
logrus.Infof("Deleted %q (%q)", instName, inst.Dir)
6462
}

pkg/autostart/autostart_test.go

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,6 @@ func TestRenderTemplate(t *testing.T) {
3838
<string>start</string>
3939
<string>default</string>
4040
<string>--foreground</string>
41-
<string>--progress</string>
4241
</array>
4342
<key>RunAtLoad</key>
4443
<true/>
@@ -66,7 +65,7 @@ Description=Lima - Linux virtual machines, with a focus on running containers.
6665
Documentation=man:lima(1)
6766
6867
[Service]
69-
ExecStart=/limactl start %i --foreground --progress
68+
ExecStart=/limactl start %i --foreground
7069
WorkingDirectory=%h
7170
Type=simple
7271
TimeoutSec=10

pkg/autostart/launchd/io.lima-vm.autostart.INSTANCE.plist

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@
1010
<string>start</string>
1111
<string>{{ .Instance }}</string>
1212
<string>--foreground</string>
13-
<string>--progress</string>
1413
</array>
1514
<key>RunAtLoad</key>
1615
<true/>

pkg/autostart/systemd/[email protected]

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ Description=Lima - Linux virtual machines, with a focus on running containers.
33
Documentation=man:lima(1)
44

55
[Service]
6-
ExecStart={{.Binary}} start %i --foreground --progress
6+
ExecStart={{.Binary}} start %i --foreground
77
WorkingDirectory=%h
88
Type=simple
99
TimeoutSec=10

0 commit comments

Comments
 (0)