Skip to content

Commit 924d111

Browse files
committed
fixup! move tests, remove redundant casts
1 parent 1c62bcc commit 924d111

File tree

2 files changed

+38
-43
lines changed

2 files changed

+38
-43
lines changed

llvm/unittests/BinaryFormat/DwarfTest.cpp

Lines changed: 38 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -254,4 +254,42 @@ TEST(DwarfTest, lname_SourceLanguageNameString) {
254254
EXPECT_EQ(SourceLanguageNameString(DW_LNAME_##NAME), xstr(DW_LNAME_##NAME));
255255
#include "llvm/BinaryFormat/Dwarf.def"
256256
}
257+
258+
TEST(DWARFDebugInfo, TestLanguageDescription_Versioned) {
259+
// Tests for the llvm::dwarf::LanguageDescription API that
260+
// takes a name *and* a version.
261+
262+
// Unknown language.
263+
EXPECT_EQ(
264+
llvm::dwarf::LanguageDescription(static_cast<SourceLanguageName>(0)),
265+
"Unknown");
266+
267+
EXPECT_EQ(
268+
llvm::dwarf::LanguageDescription(static_cast<SourceLanguageName>(0), 0),
269+
"Unknown");
270+
271+
// Test that specifying an invalid version falls back to a valid language name
272+
// regardless.
273+
EXPECT_EQ(llvm::dwarf::LanguageDescription(DW_LNAME_ObjC, 0), "Objective C");
274+
EXPECT_EQ(llvm::dwarf::LanguageDescription(DW_LNAME_Julia, 0), "Julia");
275+
276+
// Check some versions.
277+
EXPECT_EQ(llvm::dwarf::LanguageDescription(DW_LNAME_C_plus_plus, 199711),
278+
"C++98");
279+
EXPECT_EQ(llvm::dwarf::LanguageDescription(DW_LNAME_C_plus_plus, 201402),
280+
"C++14");
281+
282+
// Versions round up.
283+
EXPECT_EQ(llvm::dwarf::LanguageDescription(DW_LNAME_C_plus_plus, 201400),
284+
"C++14");
285+
286+
// Version 0 for C and C++ is an unversioned name.
287+
EXPECT_EQ(llvm::dwarf::LanguageDescription(DW_LNAME_C, 0), "C (K&R and ISO)");
288+
EXPECT_EQ(llvm::dwarf::LanguageDescription(DW_LNAME_C_plus_plus, 0),
289+
"ISO C++");
290+
291+
// Version 0 for other versioned languages may not be the unversioned name.
292+
EXPECT_EQ(llvm::dwarf::LanguageDescription(DW_LNAME_Fortran, 0),
293+
"FORTRAN 77");
294+
}
257295
} // end namespace

llvm/unittests/DebugInfo/DWARF/DWARFDebugInfoTest.cpp

Lines changed: 0 additions & 43 deletions
Original file line numberDiff line numberDiff line change
@@ -2275,47 +2275,4 @@ TEST(DWARFDebugInfo, TestDWARF64UnitLength) {
22752275
ASSERT_EQ(0x1122334455667788ULL, CU.getLength());
22762276
});
22772277
}
2278-
2279-
TEST(DWARFDebugInfo, TestLanguageDescription_Versioned) {
2280-
// Tests for the llvm::dwarf::LanguageDescription API that
2281-
// takes a name *and* a version.
2282-
2283-
// Unknown language.
2284-
EXPECT_EQ(
2285-
llvm::dwarf::LanguageDescription(static_cast<SourceLanguageName>(0)),
2286-
"Unknown");
2287-
2288-
// Test that specifying an invalid version falls back to a valid language name
2289-
// regardless.
2290-
EXPECT_EQ(llvm::dwarf::LanguageDescription(
2291-
static_cast<SourceLanguageName>(DW_LNAME_ObjC), 0),
2292-
"Objective C");
2293-
EXPECT_EQ(llvm::dwarf::LanguageDescription(
2294-
static_cast<SourceLanguageName>(DW_LNAME_Julia), 0),
2295-
"Julia");
2296-
2297-
// Check some versions.
2298-
EXPECT_EQ(llvm::dwarf::LanguageDescription(DW_LNAME_C_plus_plus, 199711),
2299-
"C++98");
2300-
EXPECT_EQ(llvm::dwarf::LanguageDescription(DW_LNAME_C_plus_plus, 201402),
2301-
"C++14");
2302-
2303-
// Versions round up.
2304-
EXPECT_EQ(llvm::dwarf::LanguageDescription(DW_LNAME_C_plus_plus, 201400),
2305-
"C++14");
2306-
2307-
// Version 0 for C and C++ is an unversioned name.
2308-
EXPECT_EQ(llvm::dwarf::LanguageDescription(
2309-
static_cast<SourceLanguageName>(DW_LNAME_C), 0),
2310-
"C (K&R and ISO)");
2311-
EXPECT_EQ(llvm::dwarf::LanguageDescription(
2312-
static_cast<SourceLanguageName>(DW_LNAME_C_plus_plus), 0),
2313-
"ISO C++");
2314-
2315-
// Version 0 for other versioned languages may not be the unversioned name.
2316-
EXPECT_EQ(llvm::dwarf::LanguageDescription(
2317-
static_cast<SourceLanguageName>(DW_LNAME_Fortran), 0),
2318-
"FORTRAN 77");
2319-
}
2320-
23212278
} // end anonymous namespace

0 commit comments

Comments
 (0)