Fix deployment permissions #206
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix the permissions so that the deployment works/page can get updated
mostly test if deployment is fixed
timhoffm
reviewed
Oct 7, 2025
timhoffm
reviewed
Oct 7, 2025
.github/workflows/gh-pages.yml
Outdated
Comment on lines
3
to
4
| contents: write | ||
| deployments: write |
There was a problem hiding this comment.
Not sure how relevant this is because we have only one job, but the general recommendation is
- Set top-level permissions as
read-allorcontents: readas described in GitHub's documentation.- Set any required write permissions at the job-level. Only set the permissions required for that job; do not set
permissions: write-allat the job level.
timhoffm
approved these changes
Oct 9, 2025
QuLogic
reviewed
Oct 21, 2025
Co-authored-by: Elliott Sales de Andrade <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix the permissions so that the deployment works/page can get updated
PR Summary