chore: cosmetic changes

Author: euonymos

example/CEM/Example/Auction.hs

@@ -124,8 +124,6 @@ instance CEMScript SimpleAuction where
           ( BuyoutSpine
           ,
             [ input (ownUtxo $ inState WinnerSpine) auctionValue
-            , byFlagError (lift False) "Some err"
-            , byFlagError (lift False) "Another err"
             , -- Example: In constraints redundant for on-chain
               offchainOnly
                 ( if'

src/Cardano/CEM/OffChain.hs

@@ -166,6 +166,7 @@ compileActionConstraints
             Map.! getSpine transition
         xSpine = transitionInStateSpine uncompiled
 
+      -- Check input state
       when (fmap getSpine mState /= xSpine) $
         throwError CEMScriptTxInResolutionError
 
@@ -286,8 +287,8 @@ resolveTx spec = runExceptT $ do
       SomeCEMAction -> (ExceptT TxResolutionError m) [OffchainTxIR]
     resolveSomeAction (MkSomeCEMAction @script action) = do
       let MkCEMAction params _ = action
-      mScript <- lift $ queryScriptState params
-      cs <- ExceptT $ return $ compileActionConstraints mScript action
+      mState <- lift $ queryScriptState params
+      cs <- ExceptT $ return $ compileActionConstraints mState action
       mapM (process action) cs
 
 resolveTxAndSubmitRet ::
@@ -368,7 +369,6 @@ compileConstraint datum transition c = case c of
       UserAddress dsl -> UserAddress <$> compileDslRecur dsl
       SameScript (MkSameScriptArg stateDsl) -> SameScript . MkSameScriptArg <$> compileDslRecur stateDsl
 
--- TODO: types errors
 compileDsl ::
   forall script x.
   (CEMScript script) =>

src/Cardano/CEM/OnChain.hs

@@ -165,19 +165,26 @@ genericPlutarchScript spec code =
             script # params # state # redm
         Nothing -> ptraceInfo "transitionComp is nothing" perror
       -- Builds checks for transition (its spine)
+      -- checks :: Spine (Transition script) -> Term s PUnit
       let checks = perTransitionCheck ctx.txInfo ownAddress comp
       -- Checks for transition spine from redeemer
       compileSpineCaseSwitch spineIndex checks
       where
-        -- We are done
-
         -- Builds 'Spine (Transition script) -> Term s PUnit'
         perTransitionCheck txInfo ownAddress comp transitionSpine = P.do
           ptraceDebug
             (pconstant $ fromString $ "Checking transition " <> Prelude.show transitionSpine)
             perTransitionCheck'
           where
             perTransitionCheck' = P.do
+              -- Get constraints from the definition
+              let constrs = case Map.lookup transitionSpine spec of
+                    Just x -> x
+                    Nothing ->
+                      error $
+                        "Compilation error: transition: "
+                          <> (Prelude.show transitionSpine)
+                          <> " lacks spec"
               pif
                 -- Constraints
                 ( foldr
@@ -190,15 +197,6 @@ genericPlutarchScript spec code =
                 -- Fail
                 (ptraceInfoError "Constraint check failed")
 
-            -- Get constraints from the definition
-            constrs = case Map.lookup transitionSpine spec of
-              Just x -> x
-              Nothing ->
-                error $
-                  "Compilation error: transition: "
-                    <> (Prelude.show transitionSpine)
-                    <> " lacks spec"
-
             -- Actual constraint compilation
             compileConstr :: TxConstraint False script -> Term s PBool
             compileConstr c = ptraceInfoIfFalse