Skip to content

Commit 878bc27

Browse files
authored
Merge pull request #810 from mozilla/tracy/fix_find_toolbar_test_for_fx144
tracy/ Find "log" instead of "pro"
2 parents 3c7ea7e + 6414766 commit 878bc27

File tree

2 files changed

+9
-6
lines changed

2 files changed

+9
-6
lines changed

tests/find_toolbar/test_find_toolbar_nav.py

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -16,11 +16,11 @@ def test_case():
1616
TOLERANCE = 3
1717

1818
TARGET_PAGE = "about:about"
19-
PROCESSES_SELECTOR = "a[href='about:processes']"
20-
PROTECTIONS_SELECTOR = "a[href='about:protections']"
19+
LOGGING_SELECTOR = "a[href='about:logging']"
20+
LOGO_SELECTOR = "a[href='about:logo']"
2121

22-
first_match = (By.CSS_SELECTOR, PROCESSES_SELECTOR)
23-
fourth_match = (By.CSS_SELECTOR, PROTECTIONS_SELECTOR)
22+
first_match = (By.CSS_SELECTOR, LOGGING_SELECTOR)
23+
fourth_match = (By.CSS_SELECTOR, LOGO_SELECTOR)
2424

2525

2626
def are_lists_different(a: int, b: int) -> bool:
@@ -40,9 +40,9 @@ def test_find_toolbar_navigation(
4040
driver.get(TARGET_PAGE)
4141

4242
find_toolbar.open()
43-
find_toolbar.find("pro")
43+
find_toolbar.find("log")
4444
match_status = find_toolbar.match_dict
45-
assert match_status["total"] == 4
45+
assert match_status["total"] == 5
4646

4747
# Sometimes we get a match that isn't the first
4848
# (This also tests that the number is correct)

tests/pdf_viewer/test_download_triggered_on_content_disposition_attachment.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -39,10 +39,13 @@ def test_download_panel_triggered_on_content_disposition_attachment(
3939
nav = Navigation(driver)
4040
about_prefs = AboutPrefs(driver, category="general").open()
4141
browser_actions = BrowserActions(driver)
42+
4243
# search for Applications section in settings
4344
about_prefs.find_in_settings("appl")
45+
4446
# set download option for pdf as always ask
4547
about_prefs.select_content_and_action("application/pdf", "Always ask")
48+
4649
# search pdf file
4750
tabs.open()
4851
nav.search(CONTENT_DISPOSITION_ATTACHMENT_URL)

0 commit comments

Comments
 (0)