Fix major memory leaks in CGUI impl

Author: Dutchman101

Client/gui/CGUI_Impl.cpp

@@ -30,25 +30,33 @@ using std::list;
 #define CGUI_SA_GOTHIC_SIZE         47
 #define CGUI_MTA_SANS_FONT_SIZE     9
 
-CGUI_Impl::CGUI_Impl(IDirect3DDevice9* pDevice) : m_HasSchemeLoaded(false), m_fCurrentServerCursorAlpha(1.0f)
+CGUI_Impl::CGUI_Impl(IDirect3DDevice9* pDevice) : 
+    m_HasSchemeLoaded(false), 
+    m_fCurrentServerCursorAlpha(1.0f),
+    m_pDevice(pDevice),
+    m_pRenderer(nullptr),
+    m_pSystem(nullptr),
+    m_pFontManager(nullptr),
+    m_pImageSetManager(nullptr),
+    m_pSchemeManager(nullptr),
+    m_pWindowManager(nullptr),
+    m_pTop(nullptr),
+    m_pCursor(nullptr),
+    m_pDefaultFont(nullptr),
+    m_pSmallFont(nullptr),
+    m_pBoldFont(nullptr),
+    m_pClearFont(nullptr),
+    m_pSAHeaderFont(nullptr),
+    m_pSAGothicFont(nullptr),
+    m_pSansFont(nullptr),
+    m_pUniFont(nullptr),
+    m_ulPreviousUnique(0),
+    m_eInputMode(INPUTMODE_NO_BINDS_ON_EDIT),
+    m_Channel(INPUT_CORE)
 {
     m_RenderOkTimer.SetMaxIncrement(100);
 
-    // Init
-    m_pDevice = pDevice;
-    /*
-    m_pCharacterKeyHandler = NULL;
-    m_pKeyDownHandler = NULL;
-    m_pMouseClickHandler = NULL;
-    m_pMouseDoubleClickHandler = NULL;
-    m_pMouseWheelHandler = NULL;
-    m_pMouseMoveHandler = NULL;
-    m_pMouseEnterHandler = NULL;
-    m_pMouseLeaveHandler = NULL;
-    m_pMovedHandler = NULL;
-    m_pSizedHandler = NULL;
-    */
-    m_Channel = INPUT_CORE;
+    // Callback arrays are default-initialized to empty state by their constructors
 
     // Create a GUI system and get the windowmanager
     m_pRenderer = new CEGUI::DirectX9Renderer(pDevice, 0);
@@ -104,7 +112,19 @@ CGUI_Impl::CGUI_Impl(IDirect3DDevice9* pDevice) : m_HasSchemeLoaded(false), m_fC
 
 CGUI_Impl::~CGUI_Impl()
 {
+    // Clean up font objects to prevent memory leaks
+    delete m_pUniFont;
+    delete m_pDefaultFont;
+    delete m_pSmallFont;
+    delete m_pBoldFont;
+    delete m_pClearFont;
+    delete m_pSAHeaderFont;
+    delete m_pSAGothicFont;
+    delete m_pSansFont;
+    
+    // Clean up CEGUI system - this automatically deletes the renderer
     delete CEGUI::System::getSingletonPtr();
+    // DO NOT delete m_pRenderer - it's already deleted by System destructor
 }
 
 void CGUI_Impl::SetSkin(const char* szName)