Merge pull request #23 from joegrasse/development

MarkLeith · MarkLeith · commit 7c98db997469 · 2014-08-29T16:05:43.000+01:00
All user summaries should include background thread
diff --git a/README.md b/README.md
@@ -251,10 +251,12 @@ mysql> select * from latest_file_io limit 5;
 
 Summarizes memory use by user using the 5.7 Performance Schema instrumentation.
 
+When the user found is NULL, it is assumed to be a "background" thread.
+
 ##### Example
 
 ```SQL
-mysql> select * from memory_by_user_by_current_bytes WHERE user IS NOT NULL;
+mysql> select * from memory_by_user_by_current_bytes;
 +------+--------------------+-------------------+-------------------+-------------------+-----------------+
 | user | current_count_used | current_allocated | current_avg_alloc | current_max_alloc | total_allocated |
 +------+--------------------+-------------------+-------------------+-------------------+-----------------+
@@ -742,6 +744,8 @@ avg_tmp_tables_per_query: 189
 
 Summarizes statement activity, file IO and connections by user.
 
+When the user found is NULL, it is assumed to be a "background" thread.
+
 ##### Example
 
 ```SQL
@@ -823,6 +827,8 @@ mysql> select * from user_summary_by_file_io_type;
 
 Summarizes stages by user, ordered by user and total latency per stage.
 
+When the user found is NULL, it is assumed to be a "background" thread.
+
 ##### Example
 
 ```SQL
@@ -855,6 +861,8 @@ mysql> select * from user_summary_by_stages;
 
 Summarizes overall statement statistics by user.
 
+When the user found is NULL, it is assumed to be a "background" thread.
+
 ##### Example
 
 ```SQL
@@ -872,6 +880,8 @@ mysql> select * from user_summary_by_statement_latency;
 
 Summarizes the types of statements executed by each user.
 
+When the user found is NULL, it is assumed to be a "background" thread.
+
 ##### Example
 
 ```SQL
diff --git a/views/p_s/memory_by_user.sql b/views/p_s/memory_by_user.sql
@@ -17,8 +17,10 @@
  * View: memory_by_user_by_current_bytes
  *
  * Summarizes memory use by user using the 5.7 Performance Schema instrumentation.
+ * 
+ * When the user found is NULL, it is assumed to be a "background" thread.  
  *
- * mysql> select * from memory_by_user_by_current_bytes WHERE user IS NOT NULL;
+ * mysql> select * from memory_by_user_by_current_bytes;
  * +------+--------------------+-------------------+-------------------+-------------------+-----------------+
  * | user | current_count_used | current_allocated | current_avg_alloc | current_max_alloc | total_allocated |
  * +------+--------------------+-------------------+-------------------+-------------------+-----------------+
@@ -40,7 +42,7 @@ VIEW memory_by_user_by_current_bytes (
   current_max_alloc,
   total_allocated
 ) AS
-SELECT user,
+SELECT IF(user IS NULL, 'background', user) AS user,
        SUM(current_count_used) AS current_count_used,
        sys.format_bytes(SUM(current_number_of_bytes_used)) AS current_allocated,
        sys.format_bytes(IFNULL(SUM(current_number_of_bytes_used) / NULLIF(SUM(current_count_used), 0), 0)) AS current_avg_alloc,
@@ -54,8 +56,10 @@ SELECT user,
  * View: x$memory_by_user_by_current_bytes
  *
  * Summarizes memory use by user
+ * 
+ * When the user found is NULL, it is assumed to be a "background" thread.  
  *
- * mysql> select * from x$memory_by_user_by_current_bytes WHERE user IS NOT NULL;
+ * mysql> select * from x$memory_by_user_by_current_bytes;
  * +------+--------------------+-------------------+-------------------+-------------------+-----------------+
  * | user | current_count_used | current_allocated | current_avg_alloc | current_max_alloc | total_allocated |
  * +------+--------------------+-------------------+-------------------+-------------------+-----------------+
@@ -77,7 +81,7 @@ VIEW x$memory_by_user_by_current_bytes (
   current_max_alloc,
   total_allocated
 ) AS
-SELECT user,
+SELECT IF(user IS NULL, 'background', user) AS user,
        SUM(current_count_used) AS current_count_used,
        SUM(current_number_of_bytes_used) AS current_allocated,
        IFNULL(SUM(current_number_of_bytes_used) / NULLIF(SUM(current_count_used), 0), 0) AS current_avg_alloc,
diff --git a/views/p_s/user_summary.sql b/views/p_s/user_summary.sql
@@ -17,6 +17,8 @@
  * View: user_summary
  *
  * Summarizes statement activity, file IO and connections by user.
+ * 
+ * When the user found is NULL, it is assumed to be a "background" thread.  
  *
  * mysql> select * from user_summary;
  * +------+------------+-------------------+-----------------------+-------------+----------+-----------------+---------------------+-------------------+--------------+
@@ -43,7 +45,7 @@ VIEW user_summary (
   total_connections,
   unique_hosts
 ) AS
-SELECT accounts.user,
+SELECT IF(accounts.user IS NULL, 'background', accounts.user) AS user,
        SUM(stmt.total) AS statements,
        sys.format_time(SUM(stmt.total_latency)) AS statement_latency,
        sys.format_time(IFNULL(SUM(stmt.total_latency) / NULLIF(SUM(stmt.total), 0), 0)) AS statement_avg_latency,
@@ -54,15 +56,16 @@ SELECT accounts.user,
        SUM(accounts.total_connections) AS total_connections,
        COUNT(DISTINCT host) AS unique_hosts
   FROM performance_schema.accounts
-  LEFT JOIN sys.x$user_summary_by_statement_latency AS stmt ON accounts.user = stmt.user
-  LEFT JOIN sys.x$user_summary_by_file_io AS io ON accounts.user = io.user
- WHERE accounts.user IS NOT NULL
- GROUP BY accounts.user;
+  LEFT JOIN sys.x$user_summary_by_statement_latency AS stmt ON IF(accounts.user IS NULL, 'background', accounts.user) = stmt.user
+  LEFT JOIN sys.x$user_summary_by_file_io AS io ON IF(accounts.user IS NULL, 'background', accounts.user) = io.user
+ GROUP BY IF(accounts.user IS NULL, 'background', accounts.user);
 
 /*
  * View: x$user_summary
  *
  * Summarizes statement activity, file IO and connections by user.
+ * 
+ * When the user found is NULL, it is assumed to be a "background" thread.  
  *
  * mysql> select * from x$user_summary;
  * +------+------------+-------------------+-----------------------+-------------+----------+-----------------+---------------------+-------------------+--------------+
@@ -89,7 +92,7 @@ VIEW x$user_summary (
   total_connections,
   unique_hosts
 ) AS
-SELECT accounts.user,
+SELECT IF(accounts.user IS NULL, 'background', accounts.user) AS user,
        SUM(stmt.total) AS statements,
        SUM(stmt.total_latency) AS statement_latency,
        IFNULL(SUM(stmt.total_latency) / NULLIF(SUM(stmt.total), 0), 0) AS statement_avg_latency,
@@ -100,7 +103,6 @@ SELECT accounts.user,
        SUM(accounts.total_connections) AS total_connections,
        COUNT(DISTINCT host) AS unique_hosts
   FROM performance_schema.accounts
-  LEFT JOIN sys.x$user_summary_by_statement_latency AS stmt ON accounts.user = stmt.user
-  LEFT JOIN sys.x$user_summary_by_file_io AS io ON accounts.user = io.user
- WHERE accounts.user IS NOT NULL
- GROUP BY accounts.user;
+  LEFT JOIN sys.x$user_summary_by_statement_latency AS stmt ON IF(accounts.user IS NULL, 'background', accounts.user) = stmt.user
+  LEFT JOIN sys.x$user_summary_by_file_io AS io ON IF(accounts.user IS NULL, 'background', accounts.user) = io.user
+ GROUP BY IF(accounts.user IS NULL, 'background', accounts.user);
diff --git a/views/p_s/user_summary_57.sql b/views/p_s/user_summary_57.sql
@@ -17,6 +17,8 @@
  * View: user_summary
  *
  * Summarizes statement activity and connections by user
+ * 
+ * When the user found is NULL, it is assumed to be a "background" thread.  
  *
  * mysql> select * from user_summary;
  * +------+------------+---------------+-------------+---------------------+-------------------+--------------+----------------+------------------------+
@@ -46,7 +48,7 @@ VIEW user_summary (
   current_memory,
   total_memory_allocated
 ) AS
-SELECT accounts.user,
+SELECT IF(accounts.user IS NULL, 'background', accounts.user) AS user,
        SUM(stmt.total) AS statements,
        sys.format_time(SUM(stmt.total_latency)) AS statement_latency,
        sys.format_time(IFNULL(SUM(stmt.total_latency) / NULLIF(SUM(stmt.total), 0), 0)) AS statement_avg_latency,
@@ -59,16 +61,17 @@ SELECT accounts.user,
        sys.format_bytes(mem.current_allocated) AS current_memory,
        sys.format_bytes(mem.total_allocated) AS total_memory_allocated
   FROM performance_schema.accounts
-  JOIN sys.x$user_summary_by_statement_latency AS stmt ON accounts.user = stmt.user
-  JOIN sys.x$user_summary_by_file_io AS io ON accounts.user = io.user
-  JOIN sys.x$memory_by_user_by_current_bytes mem ON accounts.user = mem.user
- WHERE accounts.user IS NOT NULL
- GROUP BY accounts.user;
+  LEFT JOIN sys.x$user_summary_by_statement_latency AS stmt ON IF(accounts.user IS NULL, 'background', accounts.user) = stmt.user
+  LEFT JOIN sys.x$user_summary_by_file_io AS io ON IF(accounts.user IS NULL, 'background', accounts.user) = io.user
+  LEFT JOIN sys.x$memory_by_user_by_current_bytes mem ON IF(accounts.user IS NULL, 'background', accounts.user) = mem.user
+ GROUP BY IF(accounts.user IS NULL, 'background', accounts.user);
 
 /*
  * View: x$user_summary
  *
  * Summarizes statement activity and connections by user
+ * 
+ * When the user found is NULL, it is assumed to be a "background" thread.  
  *
  * mysql> select * from x$user_summary;
  * +------+------------+-----------------+------------------+---------------------+-------------------+--------------+----------------+------------------------+
@@ -98,7 +101,7 @@ VIEW x$user_summary (
   current_memory,
   total_memory_allocated
 ) AS
-SELECT accounts.user,
+SELECT IF(accounts.user IS NULL, 'background', accounts.user) AS user,
        SUM(stmt.total) AS statements,
        SUM(stmt.total_latency) AS statement_latency,
        IFNULL(SUM(stmt.total_latency) / NULLIF(SUM(stmt.total), 0), 0) AS statement_avg_latency,
@@ -111,8 +114,7 @@ SELECT accounts.user,
        mem.current_allocated AS current_memory,
        mem.total_allocated AS total_memory_allocated
   FROM performance_schema.accounts
-  JOIN sys.x$user_summary_by_statement_latency AS stmt ON accounts.user = stmt.user
-  JOIN sys.x$user_summary_by_file_io AS io ON accounts.user = io.user
-  JOIN sys.x$memory_by_user_by_current_bytes mem ON accounts.user = mem.user
- WHERE accounts.user IS NOT NULL
- GROUP BY accounts.user;
+  LEFT JOIN sys.x$user_summary_by_statement_latency AS stmt ON IF(accounts.user IS NULL, 'background', accounts.user) = stmt.user
+  LEFT JOIN sys.x$user_summary_by_file_io AS io ON IF(accounts.user IS NULL, 'background', accounts.user) = io.user
+  LEFT JOIN sys.x$memory_by_user_by_current_bytes mem ON IF(accounts.user IS NULL, 'background', accounts.user) = mem.user
+ GROUP BY IF(accounts.user IS NULL, 'background', accounts.user);
diff --git a/views/p_s/user_summary_by_stages.sql b/views/p_s/user_summary_by_stages.sql
@@ -18,6 +18,8 @@
  *
  * Summarizes stages by user, ordered by user and total latency per stage.
  * 
+ * When the user found is NULL, it is assumed to be a "background" thread.  
+ * 
  * mysql> select * from user_summary_by_stages;
  * +------+--------------------------------+-------+-----------+-----------+
  * | user | event_name                     | total | wait_sum  | wait_avg  |
@@ -53,21 +55,22 @@ VIEW user_summary_by_stages (
   wait_sum,
   wait_avg
 ) AS
-SELECT user,
+SELECT IF(user IS NULL, 'background', user) AS user,
        event_name,
        count_star AS total,
        sys.format_time(sum_timer_wait) AS wait_sum, 
        sys.format_time(avg_timer_wait) AS wait_avg 
   FROM performance_schema.events_stages_summary_by_user_by_event_name
- WHERE user IS NOT NULL 
-   AND sum_timer_wait != 0 
+ WHERE sum_timer_wait != 0 
  ORDER BY user, sum_timer_wait DESC;
 
 /*
  * View: x$user_summary_by_stages
  *
  * Summarizes stages by user, ordered by user and total latency per stage.
  * 
+ * When the user found is NULL, it is assumed to be a "background" thread.  
+ * 
  * mysql> select * from x$user_summary_by_stages;
  * +------+--------------------------------+-------+-------------+-----------+
  * | user | event_name                     | total | wait_sum    | wait_avg  |
@@ -102,12 +105,11 @@ VIEW x$user_summary_by_stages (
   wait_sum,
   wait_avg
 ) AS
-SELECT user,
+SELECT IF(user IS NULL, 'background', user) AS user,
        event_name,
        count_star AS total,
        sum_timer_wait AS wait_sum, 
        avg_timer_wait AS wait_avg 
   FROM performance_schema.events_stages_summary_by_user_by_event_name
- WHERE user IS NOT NULL 
-   AND sum_timer_wait != 0 
+ WHERE sum_timer_wait != 0 
  ORDER BY user, sum_timer_wait DESC;
diff --git a/views/p_s/user_summary_by_statement_latency.sql b/views/p_s/user_summary_by_statement_latency.sql
@@ -17,6 +17,8 @@
  * View: user_summary_by_statement_latency
  *
  * Summarizes overall statement statistics by user.
+ * 
+ * When the user found is NULL, it is assumed to be a "background" thread.
  *
  * mysql> select * from user_summary_by_statement_latency;
  * +------+-------+---------------+-------------+--------------+-----------+---------------+---------------+------------+
@@ -59,6 +61,8 @@ SELECT user,
  * View: x$user_summary_by_statement_latency
  *
  * Summarizes overall statement statistics by user.
+ * 
+ * When the user found is NULL, it is assumed to be a "background" thread.
  *
  * mysql> select * from x$user_summary_by_statement_latency;
  * +------+-------+-----------------+---------------+---------------+-----------+---------------+---------------+------------+
diff --git a/views/p_s/user_summary_by_statement_type.sql b/views/p_s/user_summary_by_statement_type.sql
@@ -17,6 +17,8 @@
  * View: user_summary_by_statement_type
  *
  * Summarizes the types of statements executed by each user.
+ * 
+ * When the user found is NULL, it is assumed to be a "background" thread.
  *
  * mysql> select * from user_summary_by_statement_type;
  * +------+----------------------+--------+---------------+-------------+--------------+-----------+---------------+---------------+------------+
@@ -48,7 +50,7 @@ VIEW user_summary_by_statement_type (
   rows_affected,
   full_scans
 ) AS
-SELECT user,
+SELECT IF(user IS NULL, 'background', user) AS user,
        SUBSTRING_INDEX(event_name, '/', -1) AS statement,
        count_star AS total,
        sys.format_time(sum_timer_wait) AS total_latency,
@@ -59,14 +61,15 @@ SELECT user,
        sum_rows_affected AS rows_affected,
        sum_no_index_used + sum_no_good_index_used AS full_scans
   FROM performance_schema.events_statements_summary_by_user_by_event_name
- WHERE user IS NOT NULL
-   AND sum_timer_wait != 0
+ WHERE sum_timer_wait != 0
  ORDER BY user, sum_timer_wait DESC;
 
 /*
  * View: x$user_summary_by_statement_type
  *
  * Summarizes the types of statements executed by each user.
+ * 
+ * When the user found is NULL, it is assumed to be a "background" thread.
  *
  * mysql> select * from x$user_summary_by_statement_type;
  * +------+----------------------+--------+-----------------+----------------+----------------+-----------+---------------+---------------+------------+
@@ -98,7 +101,7 @@ VIEW x$user_summary_by_statement_type (
   rows_affected,
   full_scans
 ) AS
-SELECT user,
+SELECT IF(user IS NULL, 'background', user) AS user,
        SUBSTRING_INDEX(event_name, '/', -1) AS statement,
        count_star AS total,
        sum_timer_wait AS total_latency,
@@ -109,6 +112,5 @@ SELECT user,
        sum_rows_affected AS rows_affected,
        sum_no_index_used + sum_no_good_index_used AS full_scans
   FROM performance_schema.events_statements_summary_by_user_by_event_name
- WHERE user IS NOT NULL
-   AND sum_timer_wait != 0
+ WHERE sum_timer_wait != 0
  ORDER BY user, sum_timer_wait DESC;

Original file line number	Diff line number	Diff line change
`@@ -17,6 +17,8 @@`
`17`	`17`	`* View: user_summary_by_statement_latency`
`18`	`18`	`*`
`19`	`19`	`* Summarizes overall statement statistics by user.`
	`20`	`+ *`
	`21`	`+ * When the user found is NULL, it is assumed to be a "background" thread.`
`20`	`22`	`*`
`21`	`23`	`* mysql> select * from user_summary_by_statement_latency;`
`22`	`24`	`* +------+-------+---------------+-------------+--------------+-----------+---------------+---------------+------------+`
`@@ -59,6 +61,8 @@ SELECT user,`
`59`	`61`	`* View: x$user_summary_by_statement_latency`
`60`	`62`	`*`
`61`	`63`	`* Summarizes overall statement statistics by user.`
	`64`	`+ *`
	`65`	`+ * When the user found is NULL, it is assumed to be a "background" thread.`
`62`	`66`	`*`
`63`	`67`	`* mysql> select * from x$user_summary_by_statement_latency;`
`64`	`68`	`* +------+-------+-----------------+---------------+---------------+-----------+---------------+---------------+------------+`