Merge pull request anthropics#5 from Intuit-A4A/fix-model-feedback

FIX: make sure we are consistent about prediction id

Author: EfraimFeinstein

player-service-model/README.md

@@ -1,6 +1,6 @@
 # Player Service Model
 
-This is a thin model wrapper container based on `Player.csv` data. 
+This is a thin model wrapper container based on `Player.csv` data.
 
 To build and run:
 ```shell
@@ -13,11 +13,11 @@ This will expose port 5000.
 To send data to the trad AI model:
 ```shell
 $ curl -H "Content-type: application/json" -d '{"seed_id":"abbotji01","team_size":10}' http://127.0.0.1:5000/team/generate
-{"seed_id":"abbotji01","team_size":10,"member_ids":["abbotji01","combspa01","maurero01","cummijo01","flemida01","macdobo01","eddych01","morriha02","mcgrifr01","blossgr01"]}
+{"seed_id":"abbotji01","prediction_id":"38f5f02f-b1be-4282-8d0e-865b3995d50a","team_size":10,"member_ids":["abbotji01","combspa01","maurero01","cummijo01","flemida01","macdobo01","eddych01","morriha02","mcgrifr01","blossgr01"]}
 ```
 
 To send feedback:
 ```shell
-$ curl -H "Content-type: application/json"  -d '{"seed_id":"abbotji01","member_id":"maurero01","feedback":-1}' http://127.0.0.1:5000/team/feedback 
-{"seed_id":"abbotji01","member_id":"maurero01","accepted":true}
-```
+$ curl -H "Content-type: application/json"  -d '{"seed_id":"abbotji01","member_id":"maurero01","feedback":-1,"prediction_id":"38f5f02f-b1be-4282-8d0e-865b3995d50a"}' http://127.0.0.1:5000/team/feedback 
+{"seed_id":"abbotji01","member_id":"maurero01","accepted":true,"prediction_id":"38f5f02f-b1be-4282-8d0e-865b3995d50a"}
+```

player-service-model/a4a_model/server.py

@@ -64,6 +64,8 @@ class TeamFeedbackInput(BaseModel):
     seed_id: str
     member_id: str
     feedback: Literal[-1, 1]   # expect -1 or 1
+    prediction_id: str
+
 
 class TeamFeedbackOutput(BaseModel):
     seed_id: str
@@ -123,6 +125,7 @@ def generate_team(body: TeamGenerateInput) -> TeamGenerateOutput:
 def team_feedback(body: TeamFeedbackInput) -> TeamFeedbackOutput:
     seed_id = body.seed_id
     member_id = body.member_id
+    prediction_id = body.prediction_id
     accepted = True
     if seed_id not in all_players:
         accepted = False
@@ -135,7 +138,8 @@ def team_feedback(body: TeamFeedbackInput) -> TeamFeedbackOutput:
     return TeamFeedbackOutput(
         seed_id=seed_id,
         member_id=member_id,
-        accepted=accepted
+        accepted=accepted,
+        prediction_id=prediction_id or str(uuid.uuid4()),
     )