Skip to content

Commit 15387c0

Browse files
soerenreichardtFlorentinD
authored andcommitted
Fix circular import by moving aura api authentication to session module
1 parent 6b77476 commit 15387c0

File tree

10 files changed

+20
-18
lines changed

10 files changed

+20
-18
lines changed

graphdatascience/graph_data_science.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,8 @@
77
from neo4j import Driver
88
from pandas import DataFrame
99

10+
from graphdatascience.query_runner.arrow_authentication import UsernamePasswordAuthentication
11+
1012
from .call_builder import IndirectCallBuilder
1113
from .endpoints import AlphaEndpoints, BetaEndpoints, DirectEndpoints
1214
from .error.uncallable_namespace import UncallableNamespace
@@ -16,7 +18,6 @@
1618
from .query_runner.neo4j_query_runner import Neo4jQueryRunner
1719
from .query_runner.query_runner import QueryRunner
1820
from .server_version.server_version import ServerVersion
19-
from .session.arrow_authentication import UsernamePasswordAuthentication
2021
from .utils.util_proc_runner import UtilProcRunner
2122
from .version import __min_server_version__
2223

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,6 @@
11
from abc import ABC, abstractmethod
22
from typing import Callable
33

4-
from graphdatascience.session.aura_api import AuraApi
5-
64

75
class ArrowAuthentication(ABC):
86
type AuthTokenFn = Callable[[], str]
@@ -20,11 +18,3 @@ def __init__(self, username: str, password: str):
2018

2119
def auth_pair(self) -> tuple[str, str]:
2220
return self._username, self._password
23-
24-
25-
class AuraApiTokenAuthentication(ArrowAuthentication):
26-
def __init__(self, aura_api: AuraApi):
27-
self._aura_api = aura_api
28-
29-
def auth_pair(self) -> tuple[str, str]:
30-
return "", self._aura_api._auth._auth_token()

graphdatascience/query_runner/arrow_query_runner.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55

66
from pandas import DataFrame
77

8+
from graphdatascience.query_runner.arrow_authentication import ArrowAuthentication
89
from graphdatascience.retry_utils.retry_config import RetryConfig
910

1011
from ..call_parameters import CallParameters
@@ -14,7 +15,6 @@
1415
from .gds_arrow_client import GdsArrowClient
1516
from .graph_constructor import GraphConstructor
1617
from .query_runner import QueryRunner
17-
from ..session.arrow_authentication import ArrowAuthentication
1818

1919

2020
class ArrowQueryRunner(QueryRunner):

graphdatascience/query_runner/gds_arrow_client.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,11 +35,11 @@
3535
wait_exponential,
3636
)
3737

38+
from graphdatascience.query_runner.arrow_authentication import ArrowAuthentication
3839
from graphdatascience.retry_utils.retry_config import RetryConfig
3940
from graphdatascience.retry_utils.retry_utils import before_log
4041

4142
from ..semantic_version.semantic_version import SemanticVersion
42-
from ..session.arrow_authentication import ArrowAuthentication
4343
from ..version import __version__
4444
from .arrow_endpoint_version import ArrowEndpointVersion
4545
from .arrow_info import ArrowInfo
Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
1+
from graphdatascience.query_runner.arrow_authentication import ArrowAuthentication
2+
from graphdatascience.session.aura_api import AuraApi
3+
4+
5+
class AuraApiTokenAuthentication(ArrowAuthentication):
6+
def __init__(self, aura_api: AuraApi):
7+
self._aura_api = aura_api
8+
9+
def auth_pair(self) -> tuple[str, str]:
10+
return "", self._aura_api._auth._auth_token()

graphdatascience/session/aura_graph_data_science.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,13 +13,13 @@
1313
)
1414
from graphdatascience.error.uncallable_namespace import UncallableNamespace
1515
from graphdatascience.graph.graph_remote_proc_runner import GraphRemoteProcRunner
16+
from graphdatascience.query_runner.arrow_authentication import ArrowAuthentication
1617
from graphdatascience.query_runner.arrow_info import ArrowInfo
1718
from graphdatascience.query_runner.arrow_query_runner import ArrowQueryRunner
1819
from graphdatascience.query_runner.gds_arrow_client import GdsArrowClient
1920
from graphdatascience.query_runner.neo4j_query_runner import Neo4jQueryRunner
2021
from graphdatascience.query_runner.session_query_runner import SessionQueryRunner
2122
from graphdatascience.query_runner.standalone_session_query_runner import StandaloneSessionQueryRunner
22-
from graphdatascience.session.arrow_authentication import ArrowAuthentication
2323
from graphdatascience.session.dbms_connection_info import DbmsConnectionInfo
2424
from graphdatascience.utils.util_remote_proc_runner import UtilRemoteProcRunner
2525

graphdatascience/session/dedicated_sessions.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,11 +5,12 @@
55
from datetime import datetime, timedelta, timezone
66
from typing import Optional
77

8+
from graphdatascience.query_runner.arrow_authentication import ArrowAuthentication
89
from graphdatascience.query_runner.neo4j_query_runner import Neo4jQueryRunner
910
from graphdatascience.session.algorithm_category import AlgorithmCategory
10-
from graphdatascience.session.arrow_authentication import AuraApiTokenAuthentication, ArrowAuthentication
1111
from graphdatascience.session.aura_api import AuraApi
1212
from graphdatascience.session.aura_api_responses import SessionDetails
13+
from graphdatascience.session.aura_api_token_authentication import AuraApiTokenAuthentication
1314
from graphdatascience.session.aura_graph_data_science import AuraGraphDataScience
1415
from graphdatascience.session.cloud_location import CloudLocation
1516
from graphdatascience.session.dbms_connection_info import DbmsConnectionInfo

graphdatascience/tests/integration/conftest.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,9 +7,9 @@
77
from neo4j import Driver, GraphDatabase
88

99
from graphdatascience.graph_data_science import GraphDataScience
10+
from graphdatascience.query_runner.arrow_authentication import UsernamePasswordAuthentication
1011
from graphdatascience.query_runner.neo4j_query_runner import Neo4jQueryRunner
1112
from graphdatascience.server_version.server_version import ServerVersion
12-
from graphdatascience.session.arrow_authentication import UsernamePasswordAuthentication
1313
from graphdatascience.session.aura_graph_data_science import AuraGraphDataScience
1414
from graphdatascience.session.dbms_connection_info import DbmsConnectionInfo
1515

graphdatascience/tests/unit/conftest.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,13 +10,13 @@
1010
from graphdatascience import QueryRunner
1111
from graphdatascience.call_parameters import CallParameters
1212
from graphdatascience.graph_data_science import GraphDataScience
13+
from graphdatascience.query_runner.arrow_authentication import UsernamePasswordAuthentication
1314
from graphdatascience.query_runner.arrow_info import ArrowInfo
1415
from graphdatascience.query_runner.cypher_graph_constructor import (
1516
CypherGraphConstructor,
1617
)
1718
from graphdatascience.query_runner.graph_constructor import GraphConstructor
1819
from graphdatascience.server_version.server_version import ServerVersion
19-
from graphdatascience.session.arrow_authentication import UsernamePasswordAuthentication
2020
from graphdatascience.session.aura_graph_data_science import AuraGraphDataScience
2121
from graphdatascience.session.dbms_connection_info import DbmsConnectionInfo
2222

graphdatascience/tests/unit/test_gds_arrow_client.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,9 +14,9 @@
1414
Ticket,
1515
)
1616

17+
from graphdatascience.query_runner.arrow_authentication import UsernamePasswordAuthentication
1718
from graphdatascience.query_runner.arrow_info import ArrowInfo
1819
from graphdatascience.query_runner.gds_arrow_client import AuthMiddleware, GdsArrowClient
19-
from graphdatascience.session.session_connection_info import UsernamePasswordAuthentication
2020

2121
ActionParam = Union[str, tuple[str, Any], Action]
2222

0 commit comments

Comments
 (0)