Is it in scope of mini.colors add_transparency's statuscolumn functionality to set background highlights of diagnostic sign groups to transparent.

[231tr0n]

Contributing guidelines

• I have read CODE_OF_CONDUCT.md

Module(s)

mini.colors

Question

Hi echasnovski! Is it in scope of mini.colors add_transparency's method to adjust highlights to DiagnosticSign* groups so that when we set statuscolumn field in add_transparency to true, it adjust's background of diagnostic sign groups as well. Because of as of now, when the statuscolumn option is set to true in add_transparency method, it sets foldcolumn, signcolumn, linenr[above/below] highlight groups but leaves setting default diagnosticsign* groups which results in mismatch between background colors for statuscolumn and diagnostic signs.

[echasnovski]

Maybe, yeah. The issue might be that most variants of diagnostic groups are usually linked to plain DiagnosticXxx groups. Don't quite remember how add_transparency might work in this case.

[231tr0n]

@echasnovski also one last question and since it is a small one, I am just asking it here. Is there any reason why ErrorMsg highlight group has bg defined while all other highlight groups like WarningMsg, MoreMsg, etc don't have bg set? The reason for me asking this is that with the new extui enabled, the msg window shows all error messages with different background than its own since msg window is a float window and its background is float background.

hi('ErrorMsg',       {fg=p.base08, bg=p.base00, attr=nil,            sp=nil})

[echasnovski]

I presume, it is about 'mini.base16'. As I already said previously, its main design was/is to follow 'chriskempson/base16-vim'. Here how it is defined there.

If it is again about the add_transparency() effects, then maybe adding all XxxMsg groups to opts.general (as there is already MsgArea there) is also worth it.

[231tr0n]

I presume, it is about 'mini.base16'. As I already said previously, its main design was/is to follow 'chriskempson/base16-vim'. Here how it is defined there.

If it is again about the add_transparency() effects, then maybe adding all XxxMsg groups to opts.general (as there is already MsgArea there) is also worth it.

Yeah, it is about mini.base16. I should have mentioned it earlier, my bad! This is not related to add_transparency at all altough add_transparency will also conflict with the bg set for ErrorMsg. This is a separate issue. The reason for me asking this is that with the new extui enabled, the msg window shows all error messages with different background than its own since msg window is a float window and its background is float background. So the window looks something like this. Basically, setting bg highlight for ErrorMsg conflicts with msg window background.

[echasnovski]

The reason for me asking this is that with the new extui enabled, the msg window shows all error messages with different background than its own since msg window is a float window and its background is float background.

This is not a "default" behavior, but with a dedicated configuration. Please also mention such details, because I was not quite aware of this.

---

I'll take a look at ErrorMsg.

[231tr0n]

The reason for me asking this is that with the new extui enabled, the msg window shows all error messages with different background than its own since msg window is a float window and its background is float background.

This is not a "default" behavior, but with a dedicated configuration. Please also mention such details, because I was not quite aware of this.

I'll take a look at ErrorMsg.

My bad will do it from the next time! The issue is also with default highlights without any dedicated configuration as well. This is a screenshot with minicyan. The float window border looks weird because I am testing out winborder = "solid".

[echasnovski]

All the issues here should now be resolved on latest main:

• DiagnosticXxx and XxxMsg groups are now accounted in add_transparency().
• 'mini.base16' and 'mini.hues' do not set background where it is not needed.