add unittests and refactor to be backward compatible

Author: lslusarczyk

include/umf/memory_pool_ops.h

@@ -167,7 +167,7 @@ typedef struct umf_memory_pool_ops_t {
     ///
     /// @return umf_result_t result of the control operation.
     ///
-    umf_result_t (*ext_ctl)(void *hPool, umf_ctl_query_source_t source,
+    umf_result_t (*ext_ctl)(void *pool, umf_ctl_query_source_t source,
                             const char *name, void *arg, size_t size,
                             umf_ctl_query_type_t queryType, va_list args);
 
@@ -196,12 +196,12 @@ typedef struct umf_memory_pool_ops_t {
     /// @brief Adds or removes devices on which allocations should be made
     ///        resident.
     /// @param pool pointer to the memory pool
-    /// @param deviceIndex identifier of device
+    /// @param device device handle
     /// @param isAdding Boolean indicating if peer is to be removed or added
     /// @return UMF_RESULT_SUCCESS on success or appropriate error code on
     ///         failure.
     ///
-    umf_result_t (*ext_resident_device_change)(void *pool, uint32_t deviceIndex,
+    umf_result_t (*ext_resident_device_change)(void *pool, void *device,
                                                bool isAdding);
 } umf_memory_pool_ops_t;
 

include/umf/memory_provider.h

@@ -268,13 +268,13 @@ umfMemoryProviderAllocationMerge(umf_memory_provider_handle_t hProvider,
 /// @brief Adds or removes devices on which allocations should be made
 ///        resident.
 /// @param hProvider handle to the memory provider
-/// @param deviceIndex identifier of device
+/// @param device device handle
 /// @param isAdding Boolean indicating if peer is to be removed or added
 /// @return UMF_RESULT_SUCCESS on success or appropriate error code on
 ///         failure.
 umf_result_t
 umfMemoryProviderResidentDeviceChange(umf_memory_provider_handle_t hProvider,
-                                      uint32_t deviceIndex, bool isAdding);
+                                      void *device, bool isAdding);
 
 #ifdef __cplusplus
 }

include/umf/memory_provider_ops.h

@@ -326,12 +326,11 @@ typedef struct umf_memory_provider_ops_t {
     /// @brief Adds or removes devices on which allocations should be made
     ///        resident.
     /// @param provider handle to the memory provider
-    /// @param device_index identifier of device
+    /// @param device device handle
     /// @param is_adding Boolean indicating if peer is to be removed or added
     /// @return UMF_RESULT_SUCCESS on success or appropriate error code on
     ///         failure.
-    umf_result_t (*ext_resident_device_change)(void *provider,
-                                               uint32_t device_index,
+    umf_result_t (*ext_resident_device_change)(void *provider, void *device,
                                                bool is_adding);
 
 } umf_memory_provider_ops_t;

include/umf/providers/provider_level_zero.h

@@ -61,15 +61,12 @@ umf_result_t umfLevelZeroMemoryProviderParamsSetMemoryType(
 
 /// @brief  Set the resident devices in the parameters struct.
 /// @param  hParams handle to the parameters of the Level Zero Memory Provider.
-/// @param  hDevices array of all devices for which the memory can be made resident.
-/// @param  deviceCount number of devices for which the memory can be made resident.
-/// @param  residentDevicesIndices array of indices in all devices array to devices for which the memory should be made resident.
-/// @param  residentDevicesCount number of items in indices array.
+/// @param  hDevices array of devices for which the memory should be made resident.
+/// @param  deviceCount number of devices for which the memory should be made resident.
 /// @return UMF_RESULT_SUCCESS on success or appropriate error code on failure.
 umf_result_t umfLevelZeroMemoryProviderParamsSetResidentDevices(
     umf_level_zero_memory_provider_params_handle_t hParams,
-    ze_device_handle_t *hDevices, uint32_t deviceCount,
-    uint32_t *residentDevicesIndices, uint32_t residentDevicesCount);
+    ze_device_handle_t *hDevices, uint32_t deviceCount);
 
 typedef enum umf_level_zero_memory_provider_free_policy_t {
     UMF_LEVEL_ZERO_MEMORY_PROVIDER_FREE_POLICY_DEFAULT =

src/libumf.def

@@ -19,6 +19,7 @@ EXPORTS
     umfCUDAMemoryProviderParamsSetContext
     umfCUDAMemoryProviderParamsSetDevice
     umfCUDAMemoryProviderParamsSetMemoryType
+    umfLevelZeroMemoryProviderParamsSetResidentDevices
     umfDevDaxMemoryProviderOps
     umfDevDaxMemoryProviderParamsCreate
     umfDevDaxMemoryProviderParamsDestroy
@@ -143,7 +144,6 @@ EXPORTS
     umfJemallocPoolParamsCreate
     umfJemallocPoolParamsDestroy
     umfJemallocPoolParamsSetNumArenas
-    umfLevelZeroMemoryProviderParamsSetResidentDevices
     umfPoolGetName
 ; Added in UMF_1.1
     umfCUDAMemoryProviderParamsSetName

src/memory_provider.c

@@ -154,11 +154,10 @@ static umf_result_t umfDefaultGetAllocationPropertiesSize(
     return UMF_RESULT_ERROR_NOT_SUPPORTED;
 }
 
-static umf_result_t umfDefaultResidentDeviceChange(void *provider,
-                                                   uint32_t device_index,
+static umf_result_t umfDefaultResidentDeviceChange(void *provider, void *device,
                                                    bool is_adding) {
     (void)provider;
-    (void)device_index;
+    (void)device;
     (void)is_adding;
     return UMF_RESULT_ERROR_NOT_SUPPORTED;
 }
@@ -622,12 +621,12 @@ umf_result_t umfMemoryProviderGetAllocationPropertiesSize(
 
 umf_result_t
 umfMemoryProviderResidentDeviceChange(umf_memory_provider_handle_t hProvider,
-                                      uint32_t deviceIndex, bool isAdding) {
+                                      void *device, bool isAdding) {
 
     UMF_CHECK((hProvider != NULL), UMF_RESULT_ERROR_INVALID_ARGUMENT);
 
     umf_result_t res = hProvider->ops.ext_resident_device_change(
-        hProvider->provider_priv, deviceIndex, isAdding);
+        hProvider->provider_priv, device, isAdding);
 
     checkErrorAndSetLastProvider(res, hProvider);
     return res;