Merge pull request #7 from pinepain/new_methods

Add Isolate::IsInUse() method

Author: pinepain

README.md

@@ -40,8 +40,8 @@ intentionally with the purpose to provide more solid experience between native V
 
 ## Demo
 
-Here is a [Hello World](https://developers.google.com/v8/get_started#hello-world)
-from V8 [Getting Started](https://developers.google.com/v8/intro) developers guide page implemented in PHP with php-v8:
+Here is a [Hello World][v8-hello-world]
+from V8 [Getting Started][v8-intro] developers guide page implemented in PHP with php-v8:
 
 ```php
 <?php
@@ -55,8 +55,8 @@ $result = $script->Run($context);
 echo $result->ToString($context)->Value(), PHP_EOL;
 ```
 
-which will output `Hello, World!`. See how it's shorter and readable from that C++ version? And it also doesn't limit
-you from V8 API utilizing to implement more amazing stuff.
+which will output `Hello, World!`. See how it's shorter and readable from [that C++ version]([v8-hello-world])?
+And it also doesn't limit you from V8 API utilizing to implement more amazing stuff.
 
 
 ## Installation
@@ -103,11 +103,11 @@ You will need some fresh v8 Google JavaScript enging version installed. At this
    ```
 
 
-### Installing from packages
+### Installing php-v8 from packages
 
  - For Ubuntu there are [pinepain/php-v8](https://launchpad.net/~pinepain/+archive/ubuntu/php-v8) PPA.
 
-   To install fresh `php7.0` do:
+   To install fresh `php-v8`:
 
    ```
    $ sudo add-apt-repository -y ppa:pinepain/php-v8
@@ -122,7 +122,7 @@ You will need some fresh v8 Google JavaScript enging version installed. At this
    $ brew install https://raw.githubusercontent.com/pinepain/php-v8/master/scripts/homebrew/php70-v8.rb
    ```
 
-### Building from sources
+### Building php-v8 from sources
 
 ```
 git clone https://github.com/pinepain/php-v8.git
@@ -152,5 +152,7 @@ Copyright (c) 2015-2016 Bogdan Padalko &lt;[email protected]&gt;
 [php-v8](https://github.com/pinepain/php-v8) PHP extension is licensed under the [MIT license](http://opensource.org/licenses/MIT).
 
 
+[v8-hello-world]: https://chromium.googlesource.com/v8/v8/+/master/samples/hello-world.cc
+[v8-intro]: https://developers.google.com/v8/intro
 [php70-v8.rb]: https://github.com/pinepain/php-v8/blob/master/scripts/homebrew/php70-v8.rb
 [php71-v8.rb]: https://github.com/pinepain/php-v8/blob/master/scripts/homebrew/php71-v8.rb

src/php_v8_isolate.cc

@@ -489,7 +489,6 @@ static PHP_METHOD(V8Isolate, SetCaptureStackTraceForUncaughtExceptions) {
                                                        static_cast<v8::StackTrace::StackTraceOptions>(options & PHP_V8_STACK_TRACE_OPTIONS));
 }
 
-
 static PHP_METHOD(V8Isolate, IsDead) {
     if (zend_parse_parameters_none() == FAILURE) {
         return;
@@ -501,6 +500,17 @@ static PHP_METHOD(V8Isolate, IsDead) {
     RETURN_BOOL(isolate->IsDead());
 }
 
+static PHP_METHOD(V8Isolate, IsInUse) {
+    if (zend_parse_parameters_none() == FAILURE) {
+        return;
+    }
+
+    PHP_V8_ISOLATE_FETCH_WITH_CHECK(getThis(), php_v8_isolate);
+    PHP_V8_DECLARE_ISOLATE(php_v8_isolate);
+
+    RETURN_BOOL(isolate->IsInUse());
+}
+
 
 ZEND_BEGIN_ARG_INFO_EX(arginfo_v8_isolate___construct, ZEND_SEND_BY_VAL, ZEND_RETURN_VALUE, 0)
                 ZEND_ARG_OBJ_INFO(0, snapshot, V8\\StartupData, 1)
@@ -574,6 +584,10 @@ ZEND_END_ARG_INFO()
 ZEND_BEGIN_ARG_WITH_RETURN_TYPE_INFO_EX(arginfo_v8_isolate_IsDead, ZEND_RETURN_VALUE, 0, _IS_BOOL, NULL, 0)
 ZEND_END_ARG_INFO()
 
+ZEND_BEGIN_ARG_WITH_RETURN_TYPE_INFO_EX(arginfo_v8_isolate_IsInUse, ZEND_RETURN_VALUE, 0, _IS_BOOL, NULL, 0)
+ZEND_END_ARG_INFO()
+
+
 static const zend_function_entry php_v8_isolate_methods[] = {
         PHP_ME(V8Isolate, __construct, arginfo_v8_isolate___construct, ZEND_ACC_PUBLIC | ZEND_ACC_CTOR)
 
@@ -603,6 +617,7 @@ static const zend_function_entry php_v8_isolate_methods[] = {
 
         PHP_ME(V8Isolate, SetCaptureStackTraceForUncaughtExceptions, arginfo_v8_isolate_SetCaptureStackTraceForUncaughtExceptions, ZEND_ACC_PUBLIC)
         PHP_ME(V8Isolate, IsDead, arginfo_v8_isolate_IsDead, ZEND_ACC_PUBLIC)
+        PHP_ME(V8Isolate, IsInUse, arginfo_v8_isolate_IsInUse, ZEND_ACC_PUBLIC)
 
         PHP_FE_END
 };

stubs/src/Isolate.php

@@ -196,11 +196,22 @@ public function LowMemoryNotification()
     /**
      * Check if V8 is dead and therefore unusable.  This is the case after
      * fatal errors such as out-of-memory situations.
+     *
+     * @return bool
      */
     public function IsDead() : bool
     {
     }
 
+    /**
+     * Check if this isolate is in use.
+     * True if at least one thread Enter'ed this isolate.
+     *
+     * @return bool
+     */
+    public function IsInUse() : bool
+    {
+    }
 
     /**
      * Tells V8 to capture current stack trace when uncaught exception occurs

tests/.testsuite.php

@@ -39,6 +39,12 @@ public function inline($message, $value)
         echo $message, ': ', $value, PHP_EOL;
     }
 
+    public function inline_dump($message, $value)
+    {
+        echo $message, ': ';
+        $this->dump($value);
+    }
+
     public function space($new_lines_number = 2)
     {
         echo str_repeat(PHP_EOL, max(1, $new_lines_number));

tests/V8Isolate.phpt

@@ -46,7 +46,7 @@ object(V8\Isolate)#2 (5) {
 V8\Exceptions\GenericException: Not in context!
 
 V8\Isolate->GetHeapStatistics():
-    object(V8\HeapStatistics)#28 (9) {
+    object(V8\HeapStatistics)#29 (9) {
       ["total_heap_size":"V8\HeapStatistics":private]=>
       float(%d)
       ["total_heap_size_executable":"V8\HeapStatistics":private]=>

tests/V8Isolate_IsInUse.phpt

@@ -0,0 +1,32 @@
+--TEST--
+V8\Isolate::IsInUse()
+--SKIPIF--
+<?php if (!extension_loaded("v8")) print "skip"; ?>
+--FILE--
+<?php
+
+/** @var \Phpv8Testsuite $helper */
+$helper = require '.testsuite.php';
+
+require '.v8-helpers.php';
+$v8_helper = new PhpV8Helpers($helper);
+
+
+$isolate = new V8\Isolate();
+
+$helper->inline_dump('Isolate in use', $isolate->IsInUse());
+
+$context = new V8\Context($isolate);
+$fnc = new \V8\FunctionObject($context, function (\V8\CallbackInfo $info) use ($helper) {
+  $helper->inline_dump('Isolate in use', $info->GetIsolate()->IsInUse());
+});
+
+
+$context->GlobalObject()->Set($context, new \V8\StringValue($isolate, 'test'), $fnc);
+
+(new \V8\Script($context, new \V8\StringValue($isolate, 'test()')))->Run($context);
+
+?>
+--EXPECT--
+Isolate in use: bool(false)
+Isolate in use: bool(true)