Skip to content

Commit 98e4399

Browse files
committed
Don't suggest use_system_icu=1, closes #238
1 parent de71f83 commit 98e4399

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

README.Linux.md

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -32,10 +32,10 @@ Compile latest V8
3232

3333
```
3434
# Install `build-essential` if you haven't already:
35-
sudo apt-get install build-essential
35+
sudo apt install build-essential
3636
37-
# Install `libicu-dev` if you haven't already:
38-
sudo apt-get install libicu-dev
37+
# Install `chrpath` for fixing libv8.so's RUNPATH header, if you haven't already:
38+
sudo apt install chrpath
3939
4040
cd /tmp
4141
@@ -51,9 +51,6 @@ cd v8
5151
git checkout 4.9.385.28
5252
gclient sync
5353
54-
# use libicu of operating system
55-
export GYP_DEFINES="use_system_icu=1"
56-
5754
# Build (with internal snapshots)
5855
export GYPFLAGS="-Dv8_use_external_startup_data=0"
5956
@@ -67,6 +64,9 @@ sudo mkdir -p /usr/lib /usr/include
6764
sudo cp out/native/lib.target/lib*.so /usr/lib/
6865
sudo cp -R include/* /usr/include
6966
67+
# Fix libv8.so's RUNPATH header
68+
sudo chrpath -r '$ORIGIN' /usr/lib/libv8.so
69+
7070
# Install libv8_libplatform.a (V8 >= 5.2.51)
7171
echo -e "create /usr/lib/libv8_libplatform.a\naddlib out/native/obj.target/src/libv8_libplatform.a\nsave\nend" | sudo ar -M
7272

0 commit comments

Comments
 (0)