Skip to content

Commit cdcfb97

Browse files
committed
Merge pull request #148 from stesie/test-fail-old-v8
skip extensions_error test for v8 version < 3.30
2 parents f6eacd5 + 34242c5 commit cdcfb97

File tree

1 file changed

+18
-1
lines changed

1 file changed

+18
-1
lines changed

tests/extensions_error.phpt

Lines changed: 18 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,24 @@
11
--TEST--
22
Test V8::registerExtension() : Register extension with errors
33
--SKIPIF--
4-
<?php require_once(dirname(__FILE__) . '/skipif.inc'); ?>
4+
<?php
5+
require_once(dirname(__FILE__) . '/skipif.inc');
6+
7+
ob_start(NULL, 0, PHP_OUTPUT_HANDLER_CLEANABLE | PHP_OUTPUT_HANDLER_REMOVABLE);
8+
phpinfo(INFO_MODULES);
9+
$minfo = ob_get_contents();
10+
ob_end_clean();
11+
12+
if(preg_match("/V8 Engine Linked Version => (.*)/", $minfo, $matches)) {
13+
$version = explode('.', $matches[1]);
14+
if($version[0] < 3 || ($version[0] == 3 && $version[1] < 30)) {
15+
// old v8 version, has shorter error message and hence doesn't
16+
// fit our EXCEPTF below
17+
echo "skip";
18+
}
19+
}
20+
21+
?>
522
--FILE--
623
<?php
724

0 commit comments

Comments
 (0)