Release/7.0.2 (#133)

* Catch Rejected Promise and Throw Explicit Error (#132)

* Catch promise rejection and re-throw. Tests for this scenario.

* Use arrow functions in tests

* 7.0.2

* Changelog

Author: timetraveler328

CHANGELOG.md

@@ -1,3 +1,13 @@
+## [7.0.2](https://github.com/polygon-io/client-js/v7.0.1...v7.0.2) (2023-02-15)
+
+### Bug Fixes
+* Wrap fetch call in try/catch and bubble up network errors
+
+## [6.2.1](https://github.com/polygon-io/client-js/v6.2.0...v6.2.1) (2023-02-15)
+
+### Bug Fixes
+* Wrap fetch call in try/catch and bubble up network errors
+
 ## [7.0.1](https://github.com/polygon-io/client-js/v7.0.0...v7.0.1) (2023-02-01)
 
 ### Bug Fixes

package-lock.json

@@ -1,6 +1,6 @@
 {
   "name": "@polygon.io/client-js",
-  "version": "7.0.1",
+  "version": "7.0.2",
   "description": "Isomorphic Javascript client for Polygon.io Stocks, Forex, and Crypto APIs",
   "main": "lib/main.js",
   "types": "lib/main.d.ts",

package.json

@@ -207,4 +207,13 @@ describe("[REST] Crypto", () => {
     fetchStub.getCalls()[0].args[1].referrer.should.eql(mocks.overrideOptions.referrer);
     fetchStub.getCalls()[0].args[1].headers.header1.should.eql(mocks.globalOptions.headers.header1);
   });
+
+  it("properly handles promise rejections", async () => {
+    fetchStub?.restore();
+    fetchStub = sandbox.stub(fetchModule, 'fetch').rejects('Error Message')
+    crypto = cryptoClient(mocks.key, mocks.base, mocks.globalOptions);
+    return crypto.summaries({ 'ticker.any_of': "X:BTCUSD,X:USDBTC" })
+      .then(() => { throw new Error('function should throw error'); })
+      .catch((e) => { chai.expect(e).to.be.an.instanceof (Error); })
+  });
 });

src/rest/crypto/index.test.ts

@@ -196,4 +196,13 @@ describe("[REST] Forex / Currencies", () => {
     fetchStub.getCalls()[0].args[1].headers.header1.should.eql(mocks.globalOptions.headers.header1);
   });
 
+  it("properly handles promise rejections", async () => {
+    fetchStub?.restore();
+    fetchStub = sandbox.stub(fetchModule, 'fetch').rejects('Error Message')
+    fx = forexClient(mocks.key, mocks.base, mocks.globalOptions);
+    return fx.summaries({ 'ticker.any_of': "C:USDEUR,C:EURAUD" })
+      .then(() => { throw new Error('function should throw error'); })
+      .catch((e) => { chai.expect(e).to.be.an.instanceof (Error); })
+  });
+
 });

src/rest/forex/index.test.ts

@@ -169,4 +169,13 @@ describe("[REST] Options", () => {
     fetchStub.getCalls()[0].args[1].referrer.should.eql(mocks.overrideOptions.referrer);
     fetchStub.getCalls()[0].args[1].headers.header1.should.eql(mocks.globalOptions.headers.header1);
   });
+
+  it("properly handles promise rejections", async () => {
+    fetchStub?.restore();
+    fetchStub = sandbox.stub(fetchModule, 'fetch').rejects('Error Message')
+    options = optionsClient(mocks.key, mocks.base, mocks.globalOptions);
+    return options.summaries({ 'ticker.any_of': "O:Ticker1,O:Ticker2" })
+      .then(() => { throw new Error('function should throw error'); })
+      .catch((e) => { chai.expect(e).to.be.an.instanceof (Error); })
+  });
 });

src/rest/options/index.test.ts

@@ -208,4 +208,13 @@ describe("[REST] Stocks", () => {
     fetchStub.getCalls()[0].args[1].referrer.should.eql(mocks.overrideOptions.referrer);
     fetchStub.getCalls()[0].args[1].headers.header1.should.eql(mocks.globalOptions.headers.header1);
   });
+
+  it("properly handles promise rejections", async () => {
+    fetchStub?.restore();
+    fetchStub = sandbox.stub(fetchModule, 'fetch').rejects('Error Message')
+    stocks = stocksClient(mocks.key, mocks.base, mocks.globalOptions);
+    return stocks.summaries({ 'ticker.any_of': "AAPL,TSLA" })
+        .then(() => { throw new Error('function should throw error'); })
+        .catch((e) => { chai.expect(e).to.be.an.instanceof (Error); })
+  });
 });

src/rest/stocks/index.test.ts

@@ -34,23 +34,27 @@ export const getWithGlobals: ICurriedGet = (apiKey, apiBase, globalOptions = {})
 
   const queryString = stringify(query, { encode: true });
   const url = `${apiBase}${path}?${queryString}`;
-  const response = await fetchModule.fetch(url, {
-    ...globalOptions,
-    ...options,
-    headers: {
-      ...(options.headers || globalOptions.headers || {}),
-      "Authorization": `Bearer ${apiKey}`
+  try {
+    const response = await fetchModule.fetch(url, {
+      ...globalOptions,
+      ...options,
+      headers: {
+        ...(options.headers || globalOptions.headers || {}),
+        "Authorization": `Bearer ${apiKey}`
+      }
+    });
+
+    if (response.status >= 400) {
+      const message = await response.text();
+      throw new Error(message);
     }
-  });
 
-  if (response.status >= 400) {
-    const message = await response.text();
-    throw new Error(message);
-  }
+    if (response?.headers?.get('content-type') === 'text/csv') {
+      return response.text();
+    }
 
-  if (response?.headers?.get('content-type') === 'text/csv') {
-    return response.text();
+    return response.json();
+  } catch (e) {
+    throw new Error(e);
   }
-
-  return response.json();
 };