Rename function name, and the parameter's name

Signed-off-by: Hazel <[email protected]>

Author: Hazel

prometheus_client/metrics.py

@@ -203,7 +203,7 @@ def remove(self, *labelvalues: Any) -> None:
             if labelvalues in self._metrics:
                 del self._metrics[labelvalues]
 
-    def remove_matching(self, partial: dict[str, str]) -> int:
+    def remove_by_labels(self, labels: dict[str, str]) -> int:
         if 'prometheus_multiproc_dir' in os.environ or 'PROMETHEUS_MULTIPROC_DIR' in os.environ:
             warnings.warn(
                 "Removal of labels has not been implemented in  multi-process mode yet.",
@@ -213,19 +213,19 @@ def remove_matching(self, partial: dict[str, str]) -> int:
         if not self._labelnames:
             raise ValueError('No label names were set when constructing %s' % self)
 
-        if not isinstance(partial, dict):
-            raise TypeError("partial must be a dict of {label_name: label_value}")
+        if not isinstance(labels, dict):
+            raise TypeError("labels must be a dict of {label_name: label_value}")
 
-        if not partial:
+        if not labels:
             return 0
 
-        invalid = [k for k in partial.keys() if k not in self._labelnames]
+        invalid = [k for k in labels.keys() if k not in self._labelnames]
         if invalid:
             raise ValueError(
                 'Unknown label names: %s; expected %s' % (invalid, self._labelnames)
             )
 
-        pos_filter = {self._labelnames.index(k): str(v) for k, v in partial.items()}
+        pos_filter = {self._labelnames.index(k): str(v) for k, v in labels.items()}
 
         deleted = 0
         with self._lock:

tests/test_core.py

@@ -639,7 +639,7 @@ def test_remove_matching(self):
         c.labels('globex', '/').inc()
 
 
-        deleted = c.remove_matching({'tenant': 'acme'})
+        deleted = c.remove_by_labels({'tenant': 'acme'})
         self.assertEqual(2, deleted)
 
         self.assertIsNone(self.registry.get_sample_value('c2_total', {'tenant': 'acme', 'endpoint': '/'}))
@@ -651,13 +651,13 @@ def test_remove_matching_invalid_label_name(self):
         c = Counter('c3', 'help', ['tenant', 'endpoint'], registry=self.registry)
         c.labels('acme', '/').inc()
         with self.assertRaises(ValueError):
-            c.remove_matching({'badkey': 'x'})
+            c.remove_by_labels({'badkey': 'x'})
 
     def test_remove_matching_empty_is_noop(self):
         from prometheus_client import Counter
         c = Counter('c4', 'help', ['tenant', 'endpoint'], registry=self.registry)
         c.labels('acme', '/').inc()
-        self.assertEqual(0, c.remove_matching({}))
+        self.assertEqual(0, c.remove_by_labels({}))
         self.assertEqual(1, self.registry.get_sample_value('c4_total', {'tenant': 'acme', 'endpoint': '/'}))
 
     def test_non_string_labels_raises(self):