fix flaking tests

routes related tests were failing for two reasons:

- order dependencies between tests utilizing routes.rb and tests
  utilizing in file routes.
- automatically reloading routes at the top of process.

The routes file is always loaded by rails, so I think removing the thing
should be good. Tests still work anyways.

Author: kwstannard

lib/pry-rails/commands/show_routes.rb

@@ -14,7 +14,6 @@ def options(opt)
   end
 
   def process
-    Rails.application.reload_routes!
     all_routes = Rails.application.routes.routes
 
     formatted =

spec/config/environment.rb

@@ -65,6 +65,12 @@ class Pokemon < ActiveRecord::Base
   has_many :beers, :through => :hacker
 end
 
+CarsController = Class.new(ActionController::Base)
+module Admin
+  CarsController = Class.new(ActionController::Base)
+  TrucksController = Class.new(ActionController::Base)
+end
+
 if defined?(Mongoid)
   class Artist
     include Mongoid::Document

spec/config/routes.rb

@@ -1,5 +1,12 @@
 TestApp.routes.draw do
   resource :pokemon, :beer
+  resources :cars
+  namespace :admin do
+    resources :cars
+    resources :trucks
+  end
+
   get 'exit' => proc { exit! }
   get 'pry' => proc { binding.pry; [200, {}, ['']] }
+  root to: 'cars#index'
 end

spec/find_route_spec.rb

@@ -3,25 +3,14 @@
 require 'spec_helper'
 
 describe "find-route" do
-  before do
-    routes = Rails.application.routes
-    routes.draw {
-      namespace :admin do
-        resources :users
-        resources :images
-      end
-    }
-    routes.finalize!
-  end
-
   it 'returns the route for a single action' do
-    output = mock_pry('find-route Admin::UsersController#show', 'exit-all')
+    output = mock_pry('find-route Admin::CarsController#show', 'exit-all')
     _(output).must_match(/show GET/)
     _(output).wont_match(/index GET/)
   end
 
   it 'returns all the routes for a controller' do
-    output = mock_pry('find-route Admin::UsersController', 'exit-all')
+    output = mock_pry('find-route Admin::CarsController', 'exit-all')
     _(output).must_match(/index GET/)
     _(output).must_match(/show GET/)
     _(output).must_match(/new GET/)
@@ -33,8 +22,8 @@
 
   it 'returns all routes for controllers under a namespace' do
     output = mock_pry('find-route Admin', 'exit-all')
-    _(output).must_match(/Routes for Admin::UsersController/)
-    _(output).must_match(/Routes for Admin::ImagesController/)
+    _(output).must_match(/Routes for Admin::CarsController/)
+    _(output).must_match(/Routes for Admin::TrucksController/)
   end
 
   it 'returns no routes found when controller is not recognized' do

spec/recognize_path_spec.rb

@@ -3,23 +3,6 @@
 require 'spec_helper'
 
 describe "recognize-path" do
-  before do
-    FooController = Class.new(ActionController::Base)
-    BoomsController = Class.new(ActionController::Base)
-    routes = Rails.application.routes
-    routes.draw {
-      root(:to => 'foo#index', :constraints => {:host => 'example.com'})
-      resources :booms
-    }
-    routes.finalize!
-  end
-
-  after do
-    [:FooController, :BoomsController].each { |const|
-      Object.__send__(:remove_const, const)
-    }
-  end
-
   it 'fails gracefully if no path is given' do
     output = mock_pry('recognize-path', 'exit-all')
     _(output).must_match \
@@ -28,25 +11,25 @@
 
   it "prints info about controller/action that is bound to the given path" do
     output = mock_pry('recognize-path example.com', 'exit-all')
-    _(output).must_match(/controller.+foo/)
+    _(output).must_match(/controller.+cars/)
     _(output).must_match(/action.+index/)
   end
 
   it "accepts short path" do
-    output = mock_pry('recognize-path /booms/1/edit', 'exit-all')
+    output = mock_pry('recognize-path /cars/1/edit', 'exit-all')
     _(output).must_match(/action.+edit/)
-    _(output).must_match(/controller.+booms/)
+    _(output).must_match(/controller.+cars/)
     _(output).must_match(/id.+1/)
   end
 
   it "accepts -m switch" do
-    output = mock_pry('recognize-path example.com/booms -m post', 'exit-all')
-    _(output).must_match(/controller.+booms/)
+    output = mock_pry('recognize-path example.com/cars -m post', 'exit-all')
+    _(output).must_match(/controller.+cars/)
     _(output).must_match(/action.+create/)
   end
 
   it "doesn't accept unknown methods" do
-    output = mock_pry('recognize-path example.com/booms -m posty', 'exit-all')
+    output = mock_pry('recognize-path example.com/cars -m posty', 'exit-all')
     _(output).must_match 'Unknown HTTP method: posty'
   end