#245 unittest coverage (#249)

Add more unit-tests

Author: rahulraghu94

.gitignore

@@ -7,7 +7,7 @@ pymodbus.egg-info/
 .vscode
 .idea
 .noseids
-
+*.db
 .idea/
 .tox/
 doc/api/epydoc/html/

examples/contrib/message_generator.py

@@ -82,7 +82,7 @@
     ReturnSlaveBusCharacterOverrunCountRequest,
     ReturnIopOverrunCountRequest,
     ClearOverrunCountRequest,
-    GetClearModbusPlusRequest,
+    GetClearModbusPlusRequest
 ]
 
 
@@ -128,7 +128,7 @@
     ReturnSlaveBusCharacterOverrunCountResponse,
     ReturnIopOverrunCountResponse,
     ClearOverrunCountResponse,
-    GetClearModbusPlusResponse,
+    GetClearModbusPlusResponse
 ]
 
 

examples/contrib/message_parser.py

@@ -146,6 +146,10 @@ def get_options():
                       help="If the incoming message is in hexadecimal format",
                       action="store_true", dest="transaction", default=False)
 
+    parser.add_option("-t", "--transaction",
+        help="If the incoming message is in hexadecimal format",
+        action="store_true", dest="transaction", default=False)
+
     (opt, arg) = parser.parse_args()
 
     if not opt.message and len(arg) > 0:

pymodbus/pdu.py

@@ -149,8 +149,8 @@ class ModbusExceptions(Singleton):
     @classmethod
     def decode(cls, code):
         ''' Given an error code, translate it to a
-        string error name. 
-        
+        string error name.
+
         :param code: The code number to translate
         '''
         values = dict((v, k) for k, v in iteritems(cls.__dict__)

pymodbus/server/async.py

@@ -161,7 +161,7 @@ def datagramReceived(self, data, addr):
 
         :param data: The data sent by the client
         '''
-        _logger.debug("Client Connected [%s:%s]" % addr)
+        _logger.debug("Client Connected [%s]" % addr)
         if _logger.isEnabledFor(logging.DEBUG):
             _logger.debug(" ".join([hex(byte2int(x)) for x in data]))
         if not self.control.ListenOnly: