From 2de638744b618b2562a386b0901dc496c0954739 Mon Sep 17 00:00:00 2001 From: Ting Lu Date: Fri, 24 May 2024 06:47:09 -0700 Subject: [PATCH 1/4] set the linker script env var --- aarch64_linux/aarch64_wheel_ci_build.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/aarch64_linux/aarch64_wheel_ci_build.py b/aarch64_linux/aarch64_wheel_ci_build.py index 61efa10f2..adff00b64 100755 --- a/aarch64_linux/aarch64_wheel_ci_build.py +++ b/aarch64_linux/aarch64_wheel_ci_build.py @@ -199,7 +199,7 @@ def parse_arguments(): branch = "master" print("Building PyTorch wheel") - os.system("export USE_PRIORITIZED_TEXT_FOR_LD=1") #enable linker script optimization https://github.com/pytorch/pytorch/pull/121975/files + os.environ["USE_PRIORITIZED_TEXT_FOR_LD_environ"] = "1" #enable linker script optimization https://github.com/pytorch/pytorch/pull/121975/files build_vars = "MAX_JOBS=5 CMAKE_SHARED_LINKER_FLAGS=-Wl,-z,max-page-size=0x10000 " os.system("cd /pytorch; python setup.py clean") From cc8a4f78c080a0f62a671cd9509bca18404dac81 Mon Sep 17 00:00:00 2001 From: Ting Lu Date: Fri, 24 May 2024 13:25:22 -0700 Subject: [PATCH 2/4] fix var name --- aarch64_linux/aarch64_wheel_ci_build.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/aarch64_linux/aarch64_wheel_ci_build.py b/aarch64_linux/aarch64_wheel_ci_build.py index adff00b64..4d1b5d534 100755 --- a/aarch64_linux/aarch64_wheel_ci_build.py +++ b/aarch64_linux/aarch64_wheel_ci_build.py @@ -199,7 +199,7 @@ def parse_arguments(): branch = "master" print("Building PyTorch wheel") - os.environ["USE_PRIORITIZED_TEXT_FOR_LD_environ"] = "1" #enable linker script optimization https://github.com/pytorch/pytorch/pull/121975/files + os.environ["USE_PRIORITIZED_TEXT_FOR_LD"] = "1" #enable linker script optimization https://github.com/pytorch/pytorch/pull/121975/files build_vars = "MAX_JOBS=5 CMAKE_SHARED_LINKER_FLAGS=-Wl,-z,max-page-size=0x10000 " os.system("cd /pytorch; python setup.py clean") From 1c0a937a2cd97a914112b5690470b9ff5f2c0cc6 Mon Sep 17 00:00:00 2001 From: Ting Lu Date: Tue, 28 May 2024 09:01:19 -0700 Subject: [PATCH 3/4] try add it in the python command line --- aarch64_linux/aarch64_ci_build.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/aarch64_linux/aarch64_ci_build.sh b/aarch64_linux/aarch64_ci_build.sh index dc9f25a1f..18760c551 100644 --- a/aarch64_linux/aarch64_ci_build.sh +++ b/aarch64_linux/aarch64_ci_build.sh @@ -33,5 +33,5 @@ if [ "$DESIRED_CUDA" = "cpu" ]; then python /builder/aarch64_linux/aarch64_wheel_ci_build.py --enable-mkldnn else echo "BASE_CUDA_VERSION is set to: $DESIRED_CUDA" - python /builder/aarch64_linux/aarch64_wheel_ci_build.py --enable-mkldnn --enable-cuda + USE_PRIORITIZED_TEXT_FOR_LD=1 python /builder/aarch64_linux/aarch64_wheel_ci_build.py --enable-mkldnn --enable-cuda fi \ No newline at end of file From 2828e336eedb1c97484ead54bec63f7962acab93 Mon Sep 17 00:00:00 2001 From: Ting Lu Date: Wed, 29 May 2024 23:45:27 -0700 Subject: [PATCH 4/4] pick one way --- aarch64_linux/aarch64_ci_build.sh | 3 ++- aarch64_linux/aarch64_wheel_ci_build.py | 1 - 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/aarch64_linux/aarch64_ci_build.sh b/aarch64_linux/aarch64_ci_build.sh index 18760c551..0b1f7b679 100644 --- a/aarch64_linux/aarch64_ci_build.sh +++ b/aarch64_linux/aarch64_ci_build.sh @@ -33,5 +33,6 @@ if [ "$DESIRED_CUDA" = "cpu" ]; then python /builder/aarch64_linux/aarch64_wheel_ci_build.py --enable-mkldnn else echo "BASE_CUDA_VERSION is set to: $DESIRED_CUDA" - USE_PRIORITIZED_TEXT_FOR_LD=1 python /builder/aarch64_linux/aarch64_wheel_ci_build.py --enable-mkldnn --enable-cuda + #USE_PRIORITIZED_TEXT_FOR_LD for enable linker script optimization https://github.com/pytorch/pytorch/pull/121975/files + USE_PRIORITIZED_TEXT_FOR_LD=1 python /builder/aarch64_linux/aarch64_wheel_ci_build.py --enable-mkldnn --enable-cuda fi \ No newline at end of file diff --git a/aarch64_linux/aarch64_wheel_ci_build.py b/aarch64_linux/aarch64_wheel_ci_build.py index 4d1b5d534..5297cf42d 100755 --- a/aarch64_linux/aarch64_wheel_ci_build.py +++ b/aarch64_linux/aarch64_wheel_ci_build.py @@ -199,7 +199,6 @@ def parse_arguments(): branch = "master" print("Building PyTorch wheel") - os.environ["USE_PRIORITIZED_TEXT_FOR_LD"] = "1" #enable linker script optimization https://github.com/pytorch/pytorch/pull/121975/files build_vars = "MAX_JOBS=5 CMAKE_SHARED_LINKER_FLAGS=-Wl,-z,max-page-size=0x10000 " os.system("cd /pytorch; python setup.py clean")