Skip to content

Commit b1e60d9

Browse files
ghuntleygiusepe
authored andcommitted
fix: reactiveui packages should be pinned and only work with packages from the same release (#1225)
For maintainer sanity, we version ReactiveUI and package as a pinned group - all packages in a release will always be the same version and only work with that version which makes it impossible for a consumer to run into situations where they use reactiveui-core at 7.1.0 but reactiveui-xamforms at 7.0.0. Additionally all assemblies share the same CommonAssemblyInfo.cs which is updated just before compile time by the build infrastructure.
1 parent 0a97939 commit b1e60d9

6 files changed

+14
-14
lines changed

src/ReactiveUI-AndroidSupport.nuspec

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
<language>en-us</language>
88

99
<dependencies>
10-
<dependency id="reactiveui-core" version="$version$" />
10+
<dependency id="reactiveui-core" version="[$version$]" />
1111
<dependency id="Xamarin.Android.Support.v4" version="22.1.1.1" />
1212
<dependency id="Xamarin.Android.Support.v7.AppCompat" version="22.1.1.1" />
1313
<dependency id="Xamarin.Android.Support.v7.RecyclerView" version="22.1.1.1" />

src/ReactiveUI-Blend.nuspec

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -7,22 +7,22 @@
77
<language>en-us</language>
88
<dependencies>
99
<group>
10-
<dependency id="reactiveui-core" version="$version$" />
10+
<dependency id="reactiveui-core" version="[$version$]" />
1111
</group>
1212
<group targetFramework="net45">
13-
<dependency id="reactiveui-core" version="$version$" />
13+
<dependency id="reactiveui-core" version="[$version$]" />
1414
<dependency id="Rx-Xaml" version="2.2.5" />
1515
</group>
1616
<group targetFramework="wp8">
17-
<dependency id="reactiveui-core" version="$version$" />
17+
<dependency id="reactiveui-core" version="[$version$]" />
1818
<dependency id="Rx-Xaml" version="2.2.5" />
1919
</group>
2020
<group targetFramework="Portable-Win81+WPA81">
21-
<dependency id="reactiveui-core" version="$version$" />
21+
<dependency id="reactiveui-core" version="[$version$]" />
2222
<dependency id="Rx-Xaml" version="2.2.5" />
2323
</group>
2424
<group targetFramework="uap10.0">
25-
<dependency id="reactiveui-core" version="$version$" />
25+
<dependency id="reactiveui-core" version="[$version$]" />
2626
<dependency id="System.Diagnostics.Debug" version="4.0.10" />
2727
<dependency id="Microsoft.Xaml.Behaviors.Uwp.Managed" version="1.1.0" />
2828
<dependency id="Rx-Core" version="2.2.5" />

src/ReactiveUI-Testing.nuspec

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -7,15 +7,15 @@
77
<language>en-us</language>
88
<dependencies>
99
<group targetFramework="net45">
10-
<dependency id="reactiveui-core" version="$version$" />
10+
<dependency id="reactiveui-core" version="[$version$]" />
1111
<dependency id="Rx-Testing" version="2.2.5" />
1212
</group>
1313
<group targetFramework="Win8">
14-
<dependency id="reactiveui-core" version="$version$" />
14+
<dependency id="reactiveui-core" version="[$version$]" />
1515
<dependency id="Rx-Testing" version="2.2.5" />
1616
</group>
1717
<group targetFramework="uap10.0">
18-
<dependency id="reactiveui-core" version="$version$" />
18+
<dependency id="reactiveui-core" version="[$version$]" />
1919
<dependency id="Rx-Core" version="2.2.5" />
2020
<dependency id="Rx-Interfaces" version="2.2.5" />
2121
<dependency id="Rx-Linq" version="2.2.5" />
@@ -26,10 +26,10 @@
2626
<dependency id="System.Threading.Tasks" version="4.0.10" />
2727
</group>
2828
<group targetFramework="monoandroid">
29-
<dependency id="reactiveui-core" version="$version$" />
29+
<dependency id="reactiveui-core" version="[$version$]" />
3030
</group>
3131
<group targetFramework="monotouch">
32-
<dependency id="reactiveui-core" version="$version$" />
32+
<dependency id="reactiveui-core" version="[$version$]" />
3333
</group>
3434
</dependencies>
3535
</metadata>

src/ReactiveUI-Winforms.nuspec

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
<description>Windows Forms specific extensions to ReactiveUI</description>
77
<language>en-us</language>
88
<dependencies>
9-
<dependency id="reactiveui-core" version="$version$" />
9+
<dependency id="reactiveui-core" version="[$version$]" />
1010
</dependencies>
1111
</metadata>
1212
<files>

src/ReactiveUI-XamForms.nuspec

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
<description>Xamarin Forms specific extensions to ReactiveUI</description>
77
<language>en-us</language>
88
<dependencies>
9-
<dependency id="reactiveui-core" version="$version$" />
9+
<dependency id="reactiveui-core" version="[$version$]" />
1010
<dependency id="Xamarin.Forms" version="2.3.1.114" />
1111
</dependencies>
1212
</metadata>

src/ReactiveUI.nuspec

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
<description>A MVVM framework that integrates with the Reactive Extensions for .NET to create elegant, testable User Interfaces that run on any mobile or desktop platform. Supports Xamarin.iOS, Xamarin.Android, Xamarin.Mac, Xamarin Forms, WPF, Windows Forms, Windows Phone 8.1, Windows Store and Universal Windows Platform (UWP).</description>
77
<language>en-us</language>
88
<dependencies>
9-
<dependency id="reactiveui-core" version="$version$" />
9+
<dependency id="reactiveui-core" version="[$version$]" />
1010
</dependencies>
1111
</metadata>
1212
<files>

0 commit comments

Comments
 (0)