dict migrations

Author: zth

packages/@rescript/runtime/Js_dict.resi

@@ -57,6 +57,10 @@ Js.Dict.get(ages, "Vinh") == Some(22)
 Js.Dict.get(ages, "Paul") == None
 ```
 */
+@deprecated({
+  reason: "Use `Dict.get` instead.",
+  migrate: Dict.get(),
+})
 let get: (t<'a>, key) => option<'a>
 
 /**
@@ -69,6 +73,10 @@ Js.Dict.unsafeGet(ages, "Fred") == 49
 Js.Dict.unsafeGet(ages, "Paul") // returns undefined
 ```
 */
+@deprecated({
+  reason: "Use `Dict.getUnsafe` instead.",
+  migrate: Dict.getUnsafe(),
+})
 @get_index
 external unsafeGet: (t<'a>, key) => 'a = ""
 
@@ -88,6 +96,10 @@ Js.Dict.set(ages, "David", 66)
 Js.log(ages == Js.Dict.fromList(list{("Maria", 31), ("Vinh", 22), ("Fred", 49), ("David", 66)}))
 ```
 */
+@deprecated({
+  reason: "Use `Dict.set` instead.",
+  migrate: Dict.set(),
+})
 @set_index
 external set: (t<'a>, key, 'a) => unit = ""
 
@@ -100,14 +112,26 @@ Returns all the keys in the dictionary `dict`.
 Js.Dict.keys(ages) == ["Maria", "Vinh", "Fred"]
 ```
 */
+@deprecated({
+  reason: "Use `Dict.keysToArray` instead.",
+  migrate: Dict.keysToArray(),
+})
 @val
 external keys: t<'a> => array<string> = "Object.keys"
 
 /** Returns an empty dictionary. */
+@deprecated({
+  reason: "Use `Dict.make` instead.",
+  migrate: Dict.make(),
+})
 @obj
 external empty: unit => t<'a> = ""
 
 /** Experimental internal function */
+@deprecated({
+  reason: "Use `Dict.delete` instead.",
+  migrate: Dict.delete(),
+})
 let unsafeDeleteKey: (t<string>, string) => unit
 
 /**
@@ -119,6 +143,10 @@ Returns an array of key/value pairs in the given dictionary (ES2017).
 Js.Dict.entries(ages) == [("Maria", 30), ("Vinh", 22), ("Fred", 49)]
 ```
 */
+@deprecated({
+  reason: "Use `Dict.toArray` instead.",
+  migrate: Dict.toArray(),
+})
 let entries: t<'a> => array<(key, 'a)>
 
 /**
@@ -130,6 +158,10 @@ Returns the values in the given dictionary (ES2017).
 Js.Dict.values(ages) == [30, 22, 49]
 ```
 */
+@deprecated({
+  reason: "Use `Dict.valuesToArray` instead.",
+  migrate: Dict.valuesToArray(),
+})
 let values: t<'a> => array<'a>
 
 /**
@@ -142,6 +174,7 @@ argument.
 let capitals = Js.Dict.fromList(list{("Japan", "Tokyo"), ("France", "Paris"), ("Egypt", "Cairo")})
 ```
 */
+@deprecated("Use `Dict.fromArray(List.toArray(...))` instead.")
 let fromList: list<(key, 'a)> => t<'a>
 
 /**
@@ -154,6 +187,10 @@ argument.
 let capitals2 = Js.Dict.fromArray([("Germany", "Berlin"), ("Burkina Faso", "Ouagadougou")])
 ```
 */
+@deprecated({
+  reason: "Use `Dict.fromArray` instead.",
+  migrate: Dict.fromArray(),
+})
 let fromArray: array<(key, 'a)> => t<'a>
 
 /**
@@ -171,4 +208,9 @@ let salePrices = Js.Dict.map(discount, prices)
 salePrices == Js.Dict.fromList(list{("pen", 0.90), ("book", 4.50), ("stapler", 6.30)})
 ```
 */
+@deprecated({
+  reason: "Use `Dict.mapValues` instead.",
+  migrate: Dict.mapValues(%insert.unlabelledArgument(1), %insert.unlabelledArgument(0)),
+  migrateInPipeChain: Dict.mapValues(),
+})
 let map: ('a => 'b, t<'a>) => t<'b>

tests/tools_tests/src/expected/StdlibMigration_Dict.res.expected

@@ -0,0 +1,34 @@
+let d = Dict.make()
+
+let get1 = d->Dict.get("k")
+let get2 = Dict.get(d, "k")
+
+let unsafeGet1 = d->Dict.getUnsafe("k")
+let unsafeGet2 = Dict.getUnsafe(d, "k")
+
+let set1 = d->Dict.set("k", 1)
+let set2 = Dict.set(d, "k", 1)
+
+let keys1 = d->Dict.keysToArray
+let keys2 = Dict.keysToArray(d)
+
+let values1 = d->Dict.valuesToArray
+let values2 = Dict.valuesToArray(d)
+
+let entries1 = d->Dict.toArray
+let entries2 = Dict.toArray(d)
+
+let dStr: Js.Dict.t<string> = Dict.make()
+let del1 = dStr->Dict.delete("k")
+let del2 = Dict.delete(dStr, "k")
+
+let empty1: Js.Dict.t<int> = Dict.make()
+
+let fromArray1 = [("a", 1), ("b", 2)]->Dict.fromArray
+let fromArray2 = Dict.fromArray([("a", 1), ("b", 2)])
+
+let fromList1 = list{("a", 1), ("b", 2)}->Js.Dict.fromList
+let fromList2 = Js.Dict.fromList(list{("a", 1), ("b", 2)})
+
+let map2 = Dict.mapValues(d, x => x + 1)
+

tests/tools_tests/src/migrate/StdlibMigration_Dict.res

@@ -0,0 +1,33 @@
+let d = Js.Dict.empty()
+
+let get1 = d->Js.Dict.get("k")
+let get2 = Js.Dict.get(d, "k")
+
+let unsafeGet1 = d->Js.Dict.unsafeGet("k")
+let unsafeGet2 = Js.Dict.unsafeGet(d, "k")
+
+let set1 = d->Js.Dict.set("k", 1)
+let set2 = Js.Dict.set(d, "k", 1)
+
+let keys1 = d->Js.Dict.keys
+let keys2 = Js.Dict.keys(d)
+
+let values1 = d->Js.Dict.values
+let values2 = Js.Dict.values(d)
+
+let entries1 = d->Js.Dict.entries
+let entries2 = Js.Dict.entries(d)
+
+let dStr: Js.Dict.t<string> = Js.Dict.empty()
+let del1 = dStr->Js.Dict.unsafeDeleteKey("k")
+let del2 = Js.Dict.unsafeDeleteKey(dStr, "k")
+
+let empty1: Js.Dict.t<int> = Js.Dict.empty()
+
+let fromArray1 = [("a", 1), ("b", 2)]->Js.Dict.fromArray
+let fromArray2 = Js.Dict.fromArray([("a", 1), ("b", 2)])
+
+let fromList1 = list{("a", 1), ("b", 2)}->Js.Dict.fromList
+let fromList2 = Js.Dict.fromList(list{("a", 1), ("b", 2)})
+
+let map2 = Js.Dict.map(x => x + 1, d)

tests/tools_tests/src/migrate/migrated/Migrated_StdlibMigration_Dict.res

@@ -0,0 +1,35 @@
+// This file is autogenerated so it can be type checked.
+// It's the migrated version of src/migrate/StdlibMigration_Dict.res.
+let d = Dict.make()
+
+let get1 = d->Dict.get("k")
+let get2 = Dict.get(d, "k")
+
+let unsafeGet1 = d->Dict.getUnsafe("k")
+let unsafeGet2 = Dict.getUnsafe(d, "k")
+
+let set1 = d->Dict.set("k", 1)
+let set2 = Dict.set(d, "k", 1)
+
+let keys1 = d->Dict.keysToArray
+let keys2 = Dict.keysToArray(d)
+
+let values1 = d->Dict.valuesToArray
+let values2 = Dict.valuesToArray(d)
+
+let entries1 = d->Dict.toArray
+let entries2 = Dict.toArray(d)
+
+let dStr: Js.Dict.t<string> = Dict.make()
+let del1 = dStr->Dict.delete("k")
+let del2 = Dict.delete(dStr, "k")
+
+let empty1: Js.Dict.t<int> = Dict.make()
+
+let fromArray1 = [("a", 1), ("b", 2)]->Dict.fromArray
+let fromArray2 = Dict.fromArray([("a", 1), ("b", 2)])
+
+let fromList1 = list{("a", 1), ("b", 2)}->Js.Dict.fromList
+let fromList2 = Js.Dict.fromList(list{("a", 1), ("b", 2)})
+
+let map2 = Dict.mapValues(d, x => x + 1)