fix(highlight): check if children is a string

Author: danez

package.json

@@ -4,11 +4,12 @@
   "description": "A fast react component wrapper for highlight.js",
   "main": "lib/index.js",
   "scripts": {
+    "check": "npm run lint && npm run flow && npm test",
     "clean": "rimraf lib",
     "build": "cross-env NODE_ENV=production babel src --out-dir lib",
     "flow": "flow",
     "lint": "eslint src",
-    "prepublish": "npm run flow && npm test && npm run clean && npm run build",
+    "prepublish": "npm run check && npm run clean && npm run build",
     "test": "cross-env NODE_ENV=test mocha $(find src -path '*__tests__/*.js') --reporter progress --compilers js:babel-register"
   },
   "repository": {

src/components/Highlight.js

@@ -37,7 +37,12 @@ export default class Highlight extends Component<void, Props, State> {
   }
 
   // $FlowIssue - get/set properties not yet supported
-  get initialCode(): string {
+  get initialCode(): ?string {
+    const type = typeof this.props.children;
+    if (type !== 'string') {
+      throw new Error(`Children of <Highlight> must be a string. ${type} supplied`);
+    }
+
     return this.props.children;
   }
 
@@ -68,9 +73,9 @@ export default class Highlight extends Component<void, Props, State> {
     } else {
       const promise = new Promise(this.highlightCallback);
 
-      promise
-        .then(result => this.setState({ highlightedCode: result.value, language: result.language }))
-        .catch(error => console.error(error));
+      promise.then(
+        result => this.setState({ highlightedCode: result.value, language: result.language })
+      );
     }
   }
 
@@ -79,6 +84,7 @@ export default class Highlight extends Component<void, Props, State> {
     const classes = cx(this.props.className, 'hljs', this.state.language);
 
     let result: ReactElement;
+
     if (code) {
       result = (
         <pre>

src/highlight.js

@@ -1,4 +1,4 @@
-var hljs = require('highlight.js/lib/highlight');
+const hljs = require('highlight.js/lib/highlight');
 
 hljs.registerLanguage('1c', require('highlight.js/lib/languages/1c'));
 hljs.registerLanguage('accesslog', require('highlight.js/lib/languages/accesslog'));
@@ -12,7 +12,7 @@ hljs.registerLanguage('asciidoc', require('highlight.js/lib/languages/asciidoc')
 hljs.registerLanguage('aspectj', require('highlight.js/lib/languages/aspectj'));
 hljs.registerLanguage('autohotkey', require('highlight.js/lib/languages/autohotkey'));
 // webpack currently can't handle this file
-//hljs.registerLanguage('autoit', require('highlight.js/lib/languages/autoit'));
+// hljs.registerLanguage('autoit', require('highlight.js/lib/languages/autoit'));
 hljs.registerLanguage('avrasm', require('highlight.js/lib/languages/avrasm'));
 hljs.registerLanguage('axapta', require('highlight.js/lib/languages/axapta'));
 hljs.registerLanguage('bash', require('highlight.js/lib/languages/bash'));