v25.2 - Fix the delete action

Author: robole

CHANGELOG.md

@@ -5,6 +5,12 @@ All notable changes to this project are documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [0.25.2] - 2023-10-16
+
+### Fixed
+
+- Fix the delete action. It was doing an error-prone regex replacement. Parse the file as JSON and use `delete` instead.
+
 ## [0.25.0, 0.25.1] - 2023-10-16
 
 ### Changed

package.json

@@ -7,7 +7,7 @@
   },
   "description": "View and edit all your snippets in one purty place. Yee-haw!",
   "icon": "img/logo.png",
-  "version": "0.25.1",
+  "version": "0.25.2",
   "engines": {
     "vscode": "^1.4.0",
     "node": ">=12.0.0"

src/snippets-editor.js

@@ -1,3 +1,4 @@
+/* eslint-disable class-methods-use-this */
 // @ts-nocheck
 /* eslint-disable import/no-unresolved, no-useless-escape, prefer-destructuring, no-template-curly-in-string */
 const vscode = require("vscode");
@@ -48,20 +49,14 @@ class SnippetsEditor {
   /**
    * @async
    * Delete a snippet from a snippet file.
-   * @param {vscode.Uri} uri Uri of snippet file
+   * @param {vscode.Uri} uri URI of the snippet file you want to delete the snippet from.
    * @param {String} snippetName The name of the snippet to delete
    * @returns {Promise} The TextEditor that contains the user snippets document.
    */
   async deleteSnippet(uri, snippetName) {
-    let text = await SnippetsFetcher.getData(uri.fsPath);
-
-    let escapedSnippetName = Util.escapeStringRegexp(snippetName);
-    let regex = new RegExp(
-      `[\r\n]*?"${escapedSnippetName}".*?:.*?\\{.*?\\},{0,1}`,
-      "ms"
-    );
-    let newText = text.replace(regex, "");
-    await fs.promises.writeFile(uri.fsPath, newText);
+    let json = await SnippetsFetcher.getJson(uri.fsPath);
+		delete json[snippetName];
+    await fs.promises.writeFile(uri.fsPath, JSON.stringify(json, null, 2));
   }
 }
 

src/snippets-fetcher.js

@@ -149,6 +149,18 @@ class SnippetsFetcher {
     return Promise.all(json);
   }
 
+	/**
+   * Get the contents of the files as JSON objects. The files can be JSON or JSONC 
+	 * files (Microsoft JSON with comments standard).
+   * @param {Array} filepaths
+   * @returns {Promise} A Promise with an array of JSON objects.
+   */
+  static async getJson(filepath) {
+    let data = await SnippetsFetcher.getData(filepath);
+    let json = await jsonc.parse(data);
+    return json;
+  }
+
   /**
    * @async
    * @static