Skip to content

Commit 6a9bde1

Browse files
marcelmamulamarcelmamula
authored
Merge pull request #57 from sap-linuxlab/dev
merge dev to main for release 1.3.1
2 parents 9787868 + beddec9 commit 6a9bde1

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

43 files changed

+743
-138
lines changed

‎.ansible-lint‎

Lines changed: 11 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,24 @@
11
---
2-
# Collection wide lint-file
3-
# DO NOT CHANGE
2+
## Collection wide ansible-lint configuration file.
3+
# Changes for ansible-lint v25.7.0+
4+
# - Always executed from collection root using collection configuration.
5+
# - .ansible-lint-ignore can be used to ignore files, not folders.
6+
## Execution examples:
7+
# ansible-lint
8+
# ansible-lint roles/sap_swpm
9+
# ansible-lint roles/sap_install_media_detect -c roles/sap_install_media_detect/.ansible-lint
10+
411
exclude_paths:
512
- .ansible/
613
- .cache/
714
- .github/
8-
# - docs/
915
- changelogs/
1016
- playbooks/
1117
- tests/
18+
1219
enable_list:
1320
- yaml
21+
1422
skip_list:
1523
# We don't want to enforce new Ansible versions for Galaxy:
1624
- meta-runtime[unsupported-version]

‎.github/workflows/.ansible-lint‎

Lines changed: 0 additions & 10 deletions
This file was deleted.

‎.github/workflows/ansible-lint-sap_software_download.yml‎

Lines changed: 36 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,36 @@
1+
---
2+
name: Ansible Lint - sap_software_download
3+
4+
on:
5+
push:
6+
branches:
7+
- main
8+
- dev
9+
paths:
10+
- 'roles/sap_software_download/**'
11+
pull_request:
12+
branches:
13+
- main
14+
- dev
15+
paths:
16+
- 'roles/sap_software_download/**'
17+
18+
workflow_dispatch:
19+
20+
jobs:
21+
ansible-lint:
22+
runs-on: ubuntu-latest
23+
24+
steps:
25+
- uses: actions/checkout@v5
26+
27+
# Use @v25 to automatically track the latest release from the year 2025.
28+
# ansible-lint uses Calendar Versioning (e.g., v25.9.0 -> YYYY.MM.PATCH).
29+
# Avoid using @main, which can introduce breaking changes unexpectedly.
30+
- uses: ansible/ansible-lint@v25
31+
with:
32+
# v25.7.0 no longer uses 'working_directory' and role path is set in 'args'.
33+
# Role specific .ansible-lint can be added with argument '-c'.
34+
args: roles/sap_software_download
35+
# Use the shared requirements file from the collection root for dependency context.
36+
requirements_file: ./requirements.yml

‎.github/workflows/ansible-lint.yml‎

Lines changed: 16 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,24 @@
1-
name: Ansible Lint
1+
---
2+
name: Ansible Lint - Collection
23

3-
on: [push, pull_request]
4+
on:
5+
schedule:
6+
# This is 03:05 UTC, which is 5:05 AM in Prague/CEST.
7+
- cron: '5 3 * * 1'
8+
9+
workflow_dispatch:
410

511
jobs:
612
ansible-lint:
7-
813
runs-on: ubuntu-latest
914

1015
steps:
11-
- uses: actions/checkout@v4
16+
- uses: actions/checkout@v5
1217

13-
- name: Ansible Lint Action
14-
uses: ansible/ansible-lint@v6
18+
# Use @v25 to automatically track the latest release from the year 2025.
19+
# ansible-lint uses Calendar Versioning (e.g., v25.9.0 -> YYYY.MM.PATCH).
20+
# Avoid using @main, which can introduce breaking changes unexpectedly.
21+
- uses: ansible/ansible-lint@v25
22+
with:
23+
# Use the shared requirements file from the collection root for dependency context.
24+
requirements_file: ./requirements.yml

‎.github/workflows/ansible-test-sanity.yml‎

Lines changed: 84 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,84 @@
1+
---
2+
# Always check ansible-core support matrix before configuring units matrix.
3+
# https://docs.ansible.com/ansible/latest/reference_appendices/release_and_maintenance.html#ansible-core-support-matrix
4+
5+
name: Ansible Test - Sanity
6+
7+
on:
8+
schedule:
9+
# This is 01:05 UTC, which is 3:05 AM in Prague/CEST
10+
- cron: '5 3 * * 1'
11+
12+
pull_request:
13+
branches:
14+
- main
15+
- dev
16+
17+
workflow_dispatch:
18+
19+
jobs:
20+
sanity-supported:
21+
runs-on: ubuntu-latest
22+
name: Sanity (Supported Ⓐ${{ matrix.ansible }})
23+
strategy:
24+
fail-fast: false # Disabled so we can see all failed combinations.
25+
# Define a build matrix to test compatibility across multiple Ansible versions.
26+
# Each version listed below will spawn a separate job that runs in parallel.
27+
matrix:
28+
ansible:
29+
- 'stable-2.18' # Python 3.11 - 3.13
30+
- 'stable-2.19' # Python 3.11 - 3.13
31+
- 'devel' # Test against the upcoming development version.
32+
33+
steps:
34+
- uses: actions/checkout@v5
35+
36+
- name: ansible-test - sanity
37+
uses: ansible-community/ansible-test-gh-action@release/v1
38+
with:
39+
ansible-core-version: ${{ matrix.ansible }}
40+
testing-type: sanity
41+
42+
sanity-eol:
43+
runs-on: ubuntu-latest
44+
# This job only runs if the supported tests pass
45+
needs: sanity-supported
46+
name: Sanity (EOL Ⓐ${{ matrix.ansible }}+py${{ matrix.python }})
47+
continue-on-error: true # This entire job is allowed to fail
48+
strategy:
49+
fail-fast: false # Disabled so we can see all failed combinations.
50+
# Define a build matrix to test compatibility across multiple Ansible versions.
51+
# Each version listed below will spawn a separate job that runs in parallel.
52+
matrix:
53+
ansible:
54+
- 'stable-2.14' # Python 3.9 - 3.11
55+
- 'stable-2.15' # Python 3.9 - 3.11
56+
- 'stable-2.16' # Python 3.10 - 3.12
57+
- 'stable-2.17' # Python 3.10 - 3.12
58+
python:
59+
- '3.9'
60+
- '3.10'
61+
- '3.11'
62+
- '3.12'
63+
exclude:
64+
# Exclusions for incompatible Python versions.
65+
- ansible: 'stable-2.14'
66+
python: '3.12'
67+
68+
- ansible: 'stable-2.15'
69+
python: '3.12'
70+
71+
- ansible: 'stable-2.16'
72+
python: '3.9'
73+
74+
- ansible: 'stable-2.17'
75+
python: '3.9'
76+
steps:
77+
- uses: actions/checkout@v5
78+
79+
- name: ansible-test - sanity
80+
uses: ansible-community/ansible-test-gh-action@release/v1
81+
with:
82+
ansible-core-version: ${{ matrix.ansible }}
83+
target-python-version: ${{ matrix.python }}
84+
testing-type: sanity

‎CHANGELOG.rst‎

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,19 @@ community.sap\_launchpad Release Notes
44

55
.. contents:: Topics
66

7+
v1.3.1
8+
======
9+
10+
Release Summary
11+
---------------
12+
13+
Various bug fixes fixing issues identified by new workflows for sanity tests.
14+
15+
Bugfixes
16+
--------
17+
- collection: Add ansible-test sanity workflow and fix sanity errors (https://github.com/sap-linuxlab/community.sap_launchpad/pull/55)
18+
19+
720
v1.3.0
821
======
922

‎CONTRIBUTORS.md‎

Lines changed: 77 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,77 @@
1+
# Contributors to community.sap_launchpad
2+
3+
Thank you to all contributors who have helped make this project possible!
4+
5+
We welcome contributions! Please see our [contributing guidelines](https://sap-linuxlab.github.io/initiative_contributions/) to get started.
6+
7+
## Maintainers
8+
9+
The following people are the maintainers of this collection:
10+
11+
### SUSE
12+
13+
- [Marcel Mamula](https://github.com/marcelmamula)
14+
15+
16+
For specific role maintainers, see the `README.md` file in the corresponding role's directory.
17+
18+
## All Contributors
19+
20+
| Name | Commits | Lines Changed | Last Commit |
21+
| ---- | ------- | ------------- | ----------- |
22+
| [Marcel Mamula](https://github.com/marcelmamula) | 45 | 11303 | 2025-11-11 |
23+
| [Sean Freeman](https://github.com/sean-freeman) | 35 | 2915 | 2025-03-31 |
24+
| [Matthias Winzeler](https://github.com/MatthiasWinzeler) | 12 | 885 | 2023-11-12 |
25+
| [Markus Koch](https://github.com/rhmk) | 1 | 32 | 2022-10-21 |
26+
| 朱聖黎 Zhu Sheng Li | 1 | 209 | 2022-04-11 |
27+
28+
## Contributions by Role
29+
30+
### Role: sap_software_download
31+
32+
| Name | Commits | Lines Changed | Last Commit |
33+
| ---- | ------- | ------------- | ----------- |
34+
| [Marcel Mamula](https://github.com/marcelmamula) | 15 | 2408 | 2025-09-10 |
35+
36+
## Contributions by Module
37+
38+
### Module: license_keys.py
39+
40+
| Name | Commits | Lines Changed | Last Commit |
41+
| ---- | ------- | ------------- | ----------- |
42+
| [Matthias Winzeler](https://github.com/MatthiasWinzeler) | 9 | 351 | 2023-11-12 |
43+
| [Marcel Mamula](https://github.com/marcelmamula) | 2 | 181 | 2025-10-08 |
44+
45+
### Module: maintenance_planner_stack_xml_download.py
46+
47+
| Name | Commits | Lines Changed | Last Commit |
48+
| ---- | ------- | ------------- | ----------- |
49+
| [Marcel Mamula](https://github.com/marcelmamula) | 5 | 126 | 2025-10-08 |
50+
| [Sean Freeman](https://github.com/sean-freeman) | 3 | 156 | 2024-11-09 |
51+
| [Matthias Winzeler](https://github.com/MatthiasWinzeler) | 1 | 3 | 2023-11-17 |
52+
53+
### Module: systems_info.py
54+
55+
| Name | Commits | Lines Changed | Last Commit |
56+
| ---- | ------- | ------------- | ----------- |
57+
| [Matthias Winzeler](https://github.com/MatthiasWinzeler) | 5 | 121 | 2023-11-12 |
58+
| [Marcel Mamula](https://github.com/marcelmamula) | 2 | 72 | 2025-10-08 |
59+
60+
### Module: maintenance_planner_files.py
61+
62+
| Name | Commits | Lines Changed | Last Commit |
63+
| ---- | ------- | ------------- | ----------- |
64+
| [Marcel Mamula](https://github.com/marcelmamula) | 4 | 134 | 2025-10-08 |
65+
| [Sean Freeman](https://github.com/sean-freeman) | 2 | 161 | 2024-11-09 |
66+
| [Matthias Winzeler](https://github.com/MatthiasWinzeler) | 1 | 3 | 2023-11-17 |
67+
68+
### Module: software_center_download.py
69+
70+
| Name | Commits | Lines Changed | Last Commit |
71+
| ---- | ------- | ------------- | ----------- |
72+
| [Marcel Mamula](https://github.com/marcelmamula) | 11 | 627 | 2025-10-08 |
73+
| [Sean Freeman](https://github.com/sean-freeman) | 6 | 189 | 2024-11-09 |
74+
| [Matthias Winzeler](https://github.com/MatthiasWinzeler) | 1 | 3 | 2023-11-17 |
75+
| [Markus Koch](https://github.com/rhmk) | 1 | 11 | 2022-10-21 |
76+
| 朱聖黎 Zhu Sheng Li | 1 | 44 | 2022-04-11 |
77+

‎README.md‎

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,8 @@ This Ansible Collection was tested across different Operating Systems and SAP pr
9797

9898

9999
## Contributing
100-
You can find more information about ways you can contribute at [sap-linuxlab website](https://sap-linuxlab.github.io/initiative_contributions/).
100+
101+
We welcome contributions to this collection. For a list of all contributors and information on how you can get involved, please see our [CONTRIBUTORS document](./CONTRIBUTORS.md).
101102

102103

103104
## Support
@@ -120,7 +121,7 @@ When an SAP User ID (e.g. S-User) is enabled with and part of an SAP Universal I
120121
- the SAP User ID
121122
- the password for login with the SAP Universal ID
122123

123-
In addition, if a SAP Universal ID is used then the recommendation is to check and reset the SAP User ID ‘Account Password’ in the [SAP Universal ID Account Manager](https://account.sap.com/manage/accounts), which will help to avoid any potential conflicts.
124+
In addition, if a SAP Universal ID is used then the recommendation is to check and reset the SAP User ID `Account Password` in the [SAP Universal ID Account Manager](https://account.sap.com/manage/accounts), which will help to avoid any potential conflicts.
124125

125126
For further information regarding connection errors, please see the FAQ section [Errors with prefix 'SAP SSO authentication failed - '](./docs/FAQ.md#errors-with-prefix-sap-sso-authentication-failed---).
126127

‎changelogs/changelog.yaml‎

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,12 @@
11
ancestor: null
22
releases:
3+
1.3.1:
4+
release_date: '2025-11-11'
5+
changes:
6+
release_summary: Various bug fixes fixing issues identified by new workflows for sanity tests
7+
bugfixes:
8+
- collection - Add ansible-test sanity workflow and fix sanity errors (https://github.com/sap-linuxlab/community.sap_launchpad/pull/55)
9+
310
1.3.0:
411
release_date: '2025-09-23'
512
changes:

‎docs/CONTRIBUTORS.md‎

Lines changed: 0 additions & 13 deletions
This file was deleted.

0 commit comments

Comments
 (0)