Fix wrong exception catching

Add unit tests for POST with broken mapper

Author: aruhier

netboxapi/mapper.py

@@ -88,7 +88,7 @@ def post(self, **json):
             if isinstance(v, NetboxMapper):
                 try:
                     json[k] = v.id
-                except KeyError:
+                except AttributeError:
                     raise ValueError("Mapper {} has no id".format(k))
         new_mapper_dict = self.netbox_api.post(self._route, json=json)
         try:

tests/test_mapper.py

@@ -242,6 +242,20 @@ def test_post_foreign_key(self, mapper):
 
         assert received_req.last_request.json()["fk"] == 2
 
+    def test_post_foreign_key_broken_mapper(self, mapper):
+        url = self.get_mapper_url(mapper)
+
+        fk_mapper = NetboxMapper(mapper.netbox_api, "foo", "bar")
+
+        with requests_mock.Mocker() as m:
+            m.register_uri(
+                "post", url, json={
+                    "id": 1, "name": "testname", "fk": {"id": 2}
+                }
+            )
+            with pytest.raises(ValueError):
+                mapper.post(name="testname", fk=fk_mapper)
+
     def test_put(self, mapper):
         child_mapper = self.get_child_mapper(mapper)
         url = self.get_mapper_url(child_mapper) + "{}/".format(child_mapper.id)