bug: fixes cryptography scanner

Author: agustingroh

CHANGELOG.md

@@ -2,6 +2,11 @@
 
 All notable changes to this project will be documented in this file. See [standard-version](https://github.com/conventional-changelog/standard-version) for commit guidelines.
 
+## [0.23.0] (2025-09-19)
+### Bug
+- Fixed bug in the cryptography scanner
+### Changed
+- Enhance http error handling on cryptography client
 
 ## [0.22.0] (2025-09-05)
 ### Added

package.json

@@ -1,6 +1,6 @@
 {
   "name": "scanoss",
-  "version": "0.22.0",
+  "version": "0.23.0",
   "description": "The SCANOSS JS package provides a simple, easy to consume module for interacting with SCANOSS APIs/Engine.",
   "main": "build/main/index.js",
   "typings": "build/main/index.d.ts",

src/sdk/Clients/Cryptography/CryptographyGRPCClient.ts

@@ -120,7 +120,7 @@ export class CryptographyGRPCClient extends BaseGRPCClient implements ICryptogra
 
   private transformGrpcAlgorithmResponse(grpcResponse: any): AlgorithmResponse {
     return {
-      purls: grpcResponse.purlsList?.map((purl: any) => ({
+      components: grpcResponse.components?.map((purl: any) => ({
         purl: purl.purl,
         version: purl.version || '',
         algorithms: purl.algorithmsList?.map((algo: any) => ({
@@ -137,7 +137,7 @@ export class CryptographyGRPCClient extends BaseGRPCClient implements ICryptogra
 
   private transformGrpcHintsResponse(grpcResponse: any): HintsInRangeResponse {
     return {
-      purls: grpcResponse.purlsList?.map((purl: any) => ({
+      components: grpcResponse.components?.map((purl: any) => ({
         purl: purl.purl,
         version: purl.version || '',
         versions: purl.versionsList || [],

src/sdk/Clients/Cryptography/CryptographyHttpClient.ts

@@ -30,16 +30,21 @@ export class CryptographyHttpClient extends HttpClient implements ICryptographyC
    */
   public async getAlgorithms(components: Component[]): Promise<AlgorithmResponse> {
     try {
-      const baseURL = this.hostURL();
       validateComponents(components);
-      const URL = `${this.hostURL()}/v2/cryptography/algorithms`;
-      const response = await this.post(URL, { purls: components });
-
+      const URL = `${this.hostURL()}/v2/cryptography/algorithms/components`;
+      const response = await this.post(URL, { components: components });
       if (response.ok) {
         const algorithms = await response.json();
         return algorithms as AlgorithmResponse;
       }
 
+      if(response.status === 404){
+        const responseData = await response.json();
+        const errorMessage = `Failed to get algorithms: ${response.status} ${response.statusText} - ${JSON.stringify(responseData)}`;
+        logger.log(`Error getting algorithms: ${errorMessage}`);
+        return responseData as AlgorithmResponse;
+      }
+
       const errorText = await response.text();
       const errorMessage = `Failed to get algorithms: ${response.status} ${response.statusText} - ${errorText}`;
       logger.log(`Error getting algorithms: ${errorMessage}`);
@@ -59,13 +64,26 @@ export class CryptographyHttpClient extends HttpClient implements ICryptographyC
   public async getEncryptionHints(components: Component[]): Promise<HintsInRangeResponse> {
     try {
       validateComponents(components);
-      const URL = `${this.hostURL()}/v2/cryptography/hintsInRange`;
-      const response = await this.post(URL, { purls: components });
+      const URL = `${this.hostURL()}/v2/cryptography/hints/range/components`;
+      const response = await this.post(URL, { components: components });
 
       if (response.ok) {
         const hints = await response.json();
         return hints as HintsInRangeResponse;
       }
+      if(response.status === 400){
+        const errorText = await response.text();
+        const errorMessage = `Failed to get encryption hints: ${response.status} ${response.statusText} - ${errorText}`;
+        logger.log(`Error getting encryption hints: ${errorMessage}`);
+        throw new Error(errorMessage);
+      }
+
+      if(response.status === 404){
+        const responseData = await response.json();
+        const errorMessage = `Failed to get encryption hints: ${response.status} ${response.statusText} - ${JSON.stringify(responseData)}`;
+        logger.log(`Error getting encryption hints: ${errorMessage}`);
+        return responseData as HintsInRangeResponse;
+      }
 
       const errorText = await response.text();
       const errorMessage = `Failed to get encryption hints: ${response.status} ${response.statusText} - ${errorText}`;

src/sdk/Clients/Cryptography/ICryptographyClient.ts

@@ -30,7 +30,7 @@ export interface Status {
 }
 
 export interface AlgorithmResponse {
-  purls: ComponentAlgorithm[];
+  components: ComponentAlgorithm[];
   status: Status;
 }
 
@@ -40,7 +40,7 @@ export interface ComponentHintResponse extends Purl {
 }
 
 export interface HintsInRangeResponse {
-  purls: ComponentHintResponse[];
+  components: ComponentHintResponse[];
   status: Status;
 }
 

src/sdk/Components/ComponentsScanner.ts

@@ -44,8 +44,6 @@ export class ComponentsScanner {
       this.componentsClient = new ComponentsHttpClient(clientCfg);
       logger.log('Using HTTP client for components service');
     }
-
-
   }
 
   /**

src/sdk/Cryptography/Helper/ResultCollector/Component/ComponentCryptographyResultColletor.ts

@@ -43,11 +43,11 @@ export class ComponentCryptographyResultCollector {
    * @param algorithmResults The algorithm detection results to collect.
    */
   public collectAlgorithmResults(algorithmResults: AlgorithmResponse):void {
-    algorithmResults.purls.forEach((p) => {
-      if (p.version) {
-        const version = p.version.startsWith('v') ? p.version.slice(1) : p.version;
-        const result = this.getOrCreateResult(p.purl,version);
-        result.algorithms = p.algorithms;
+    algorithmResults.components.forEach((c) => {
+      if (c.version) {
+        const version = c.version.startsWith('v') ? c.version.slice(1) : c.version;
+        const result = this.getOrCreateResult(c.purl,version);
+        result.algorithms = c.algorithms;
       }
     });
   }
@@ -57,11 +57,11 @@ export class ComponentCryptographyResultCollector {
    * @param hintResults The hint detection results to collect.
    */
   public collectHintResults(hintResults: HintsInRangeResponse):void {
-    hintResults.purls.forEach((h) => {
-      if (h.versions.length > 0) {
-        const version = h.versions[0].startsWith('v') ? h.versions[0].slice(1) : h.versions[0];
-        const result = this.getOrCreateResult(h.purl, version);
-        result.hints = h.hints;
+    hintResults.components.forEach((c) => {
+      if (c.versions.length > 0) {
+        const version = c.versions[0].startsWith('v') ? c.versions[0].slice(1) : c.versions[0];
+        const result = this.getOrCreateResult(c.purl, version);
+        result.hints = c.hints;
       }
     });
   }