Skip to content

Commit 102652b

Browse files
committed
Bug fix while importing scene
1 parent 1b14649 commit 102652b

File tree

3 files changed

+9
-4
lines changed

3 files changed

+9
-4
lines changed

editor/editor_system.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -318,7 +318,7 @@ void EditorSystem::drawDefaultUI(float deltaMilliseconds)
318318
ImGui::Separator();
319319
if (ImGui::BeginMenu("Create Scene"))
320320
{
321-
static SceneID inputBaseID = 0;
321+
SceneID inputBaseID = 0;
322322
ImGui::InputText("Scene Name", &newSceneName, ImGuiInputTextFlags_AlwaysInsertMode);
323323
ImGui::InputScalar("Scene BaseID", ImGuiDataType_U32, &inputBaseID);
324324
Scene::SetBaseID(inputBaseID);

rootex/framework/scene.cpp

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -51,6 +51,13 @@ void Scene::ResetNextID()
5151
NextSceneID = ROOT_SCENE_ID + 1;
5252
}
5353

54+
void Scene::SetBaseID(const SceneID& inputBaseID)
55+
{
56+
BaseID = inputBaseID;
57+
SceneID SceneIDOffset = 4;
58+
NextSceneID = std::max(std::max(BaseID, NextSceneID), SceneIDOffset);
59+
}
60+
5461
Ptr<Scene> Scene::Create(const JSON::json& sceneData, const bool assignNewIDs)
5562
{
5663
// Decide ID
@@ -69,8 +76,6 @@ Ptr<Scene> Scene::Create(const JSON::json& sceneData, const bool assignNewIDs)
6976
}
7077
else
7178
{
72-
SceneID SceneIDOffset = 4;
73-
NextSceneID = std::max(std::max(BaseID, NextSceneID), SceneIDOffset);
7479
thisSceneID = NextSceneID;
7580
}
7681
NextSceneID++;

rootex/framework/scene.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ class Scene
5858

5959
public:
6060
static void ResetNextID();
61-
static void SetBaseID(const SceneID& inputBaseID) { BaseID = inputBaseID; }
61+
static void SetBaseID(const SceneID& inputBaseID);
6262

6363
static Ptr<Scene> Create(const JSON::json& sceneData, const bool assignNewIDs);
6464
static Ptr<Scene> CreateFromFile(const String& sceneFile);

0 commit comments

Comments
 (0)