Skip to content

Commit 301edf8

Browse files
committed
Minor flow changes
1 parent 713f0fd commit 301edf8

File tree

5 files changed

+21
-28
lines changed

5 files changed

+21
-28
lines changed

editor/editor.app.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
}
2121
},
2222
"InputSystem": {
23-
"height": 991,
23+
"height": 1017,
2424
"inputSchemes": {
2525
"Editor": {
2626
"bools": [
@@ -91,7 +91,7 @@
9191
},
9292
"PhysicsSystem": {},
9393
"UISystem": {
94-
"height": 991,
94+
"height": 1017,
9595
"width": 1920
9696
}
9797
},

editor/editor_system.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -318,7 +318,7 @@ void EditorSystem::drawDefaultUI(float deltaMilliseconds)
318318
ImGui::Separator();
319319
if (ImGui::BeginMenu("Create Scene"))
320320
{
321-
static unsigned int inputBaseID = 0;
321+
static SceneID inputBaseID = 0;
322322
ImGui::InputText("Scene Name", &newSceneName, ImGuiInputTextFlags_AlwaysInsertMode);
323323
ImGui::InputScalar("Scene BaseID", ImGuiDataType_U32, &inputBaseID);
324324
Scene::SetBaseID(inputBaseID);

imgui.ini

Lines changed: 15 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
11
[Window][Rootex Editor]
22
Pos=0,0
3-
Size=1920,991
3+
Size=1920,1017
44
Collapsed=0
55

66
[Window][Output]
7-
Pos=0,620
8-
Size=1114,371
7+
Pos=0,636
8+
Size=1114,381
99
Collapsed=0
1010
DockId=0x00000003,0
1111

@@ -33,19 +33,19 @@ Collapsed=0
3333
DockId=0x0000000D,0
3434

3535
[Window][Toolbar]
36-
Pos=1116,620
37-
Size=333,371
36+
Pos=1116,636
37+
Size=333,381
3838
Collapsed=0
3939
DockId=0x00000004,0
4040

4141
[Window][Viewport]
4242
Pos=0,28
43-
Size=1449,590
43+
Size=1449,606
4444
Collapsed=0
4545
DockId=0x00000008,0
4646

4747
[Window][Inspector]
48-
Pos=1451,409
48+
Pos=1451,435
4949
Size=469,582
5050
Collapsed=0
5151
DockId=0x00000009,0
@@ -155,7 +155,7 @@ Collapsed=0
155155

156156
[Window][Scene]
157157
Pos=1451,28
158-
Size=469,379
158+
Size=469,405
159159
Collapsed=0
160160
DockId=0x00000007,0
161161

@@ -170,13 +170,13 @@ Size=750,643
170170
Collapsed=0
171171

172172
[Window][Load Scene]
173-
Pos=1117,620
173+
Pos=1119,620
174174
Size=30,58
175175
Collapsed=0
176176

177177
[Window][Save]
178-
Pos=1233,626
179-
Size=262,110
178+
Pos=1249,634
179+
Size=257,110
180180
Collapsed=0
181181

182182
[Window][Style Editor]
@@ -191,7 +191,7 @@ Collapsed=0
191191

192192
[Window][File Editor]
193193
Pos=0,28
194-
Size=1449,590
194+
Size=1449,606
195195
Collapsed=0
196196
DockId=0x00000008,1
197197

@@ -201,13 +201,13 @@ Size=241,158
201201
Collapsed=0
202202

203203
[Window][Content Browser]
204-
Pos=0,620
205-
Size=1114,371
204+
Pos=0,636
205+
Size=1114,381
206206
Collapsed=0
207207
DockId=0x00000003,1
208208

209209
[Docking][Data]
210-
DockSpace ID=0x654E7FDC Window=0xDC8952A0 Pos=0,28 Size=1920,963 Split=X
210+
DockSpace ID=0x654E7FDC Window=0xDC8952A0 Pos=0,28 Size=1920,989 Split=X
211211
DockNode ID=0x00000001 Parent=0x654E7FDC SizeRef=1932,1359 Split=Y Selected=0x995B0CF8
212212
DockNode ID=0x00000008 Parent=0x00000001 SizeRef=1932,596 Selected=0x995B0CF8
213213
DockNode ID=0x0000000A Parent=0x00000001 SizeRef=1932,375 Split=X Selected=0xCB7211A8

rootex/framework/scene.cpp

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -70,8 +70,6 @@ Ptr<Scene> Scene::Create(const JSON::json& sceneData, const bool assignNewIDs)
7070
}
7171
else
7272
{
73-
/*thisSceneID = std::max(std::max(BaseID, NextSceneID), SceneIDOffset);
74-
NextSceneID = std::max(BaseID, SceneIDOffset);*/
7573
NextSceneID = std::max(std::max(BaseID, NextSceneID), SceneIDOffset);
7674
thisSceneID = NextSceneID;
7775
}
@@ -320,11 +318,6 @@ void Scene::setName(const String& name)
320318
m_FullName = name + " # " + std::to_string(m_ID);
321319
}
322320

323-
void Scene::setm_BaseID(const SceneID& input)
324-
{
325-
m_BaseID = BaseID;
326-
}
327-
328321
JSON::json Scene::getJSON() const
329322
{
330323
JSON::json j;
@@ -356,7 +349,7 @@ Scene::Scene(SceneID id, const String& name, const SceneSettings& settings, Impo
356349
, m_Entity(this)
357350
{
358351
setName(m_Name);
359-
setm_BaseID(BaseID);
352+
setm_BaseID();
360353
s_Scenes.push_back(this);
361354
}
362355

rootex/framework/scene.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ class Scene
5858

5959
public:
6060
static void ResetNextID();
61-
static void Scene::SetBaseID(const SceneID& inputBaseID) { BaseID = inputBaseID; }
61+
static void SetBaseID(const SceneID& inputBaseID) { BaseID = inputBaseID; }
6262

6363
static Ptr<Scene> Create(const JSON::json& sceneData, const bool assignNewIDs);
6464
static Ptr<Scene> CreateFromFile(const String& sceneFile);
@@ -82,7 +82,7 @@ class Scene
8282
bool removeChild(Scene* toRemove);
8383

8484
void setName(const String& name);
85-
void setm_BaseID(const SceneID& input);
85+
void Scene::setm_BaseID(){ m_BaseID = BaseID; }
8686

8787
JSON::json getJSON() const;
8888
bool& getIsScenePaused() { return m_IsScenePaused; }

0 commit comments

Comments
 (0)