Merge pull request #595 from sdslabs/component-array

r41k0u · web-flow · commit 5fb00345b88b · 2023-08-25T04:04:05.000+05:30
Fix vector erase bug
diff --git a/rootex/utility/component_array.h b/rootex/utility/component_array.h
@@ -91,6 +91,9 @@ class ComponentArray
 			if (m_IsValid[i] && (m_Data[i].getOwner().getID() == entity.getID()))
 			{
 				m_IsValid[i] = false;
+				m_Data[i].onRemove();
+				m_Data[i].~Component();
+				memset(&m_Data[i], 0, sizeof(m_Data[i]));
 				m_ArraySize--;
 				return true;
 			}

Original file line number	Diff line number	Diff line change
`@@ -91,6 +91,9 @@ class ComponentArray`
`91`	`91`	`if (m_IsValid[i] && (m_Data[i].getOwner().getID() == entity.getID()))`
`92`	`92`	`{`
`93`	`93`	`m_IsValid[i] = false;`
	`94`	`+ m_Data[i].onRemove();`
	`95`	`+ m_Data[i].~Component();`
	`96`	`+ memset(&m_Data[i], 0, sizeof(m_Data[i]));`
`94`	`97`	`m_ArraySize--;`
`95`	`98`	`return true;`
`96`	`99`	`}`