PR review fixes

Aryan51203 · Aryan51203 · commit 65e4cb7a72ee · 2025-02-05T14:07:15.000+05:30
diff --git a/core/config/challenge.go b/core/config/challenge.go
@@ -162,6 +162,7 @@ func (config *ChallengeMetadata) ValidateRequiredFields() (error, bool) {
 		return fmt.Errorf("fail solve limit must be greater than equal to 0"), false
 	} else if config.MaxAttemptLimit == 0 {
 		// sets default value to -1 so it means that there is no limit.
+		log.Warn("MaxAttemptLimit is set to 0, defaulting to no limit for attempts")
 		config.MaxAttemptLimit = -1
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -162,6 +162,7 @@ func (config *ChallengeMetadata) ValidateRequiredFields() (error, bool) {`
`162`	`162`	`return fmt.Errorf("fail solve limit must be greater than equal to 0"), false`
`163`	`163`	`} else if config.MaxAttemptLimit == 0 {`
`164`	`164`	`// sets default value to -1 so it means that there is no limit.`
	`165`	`+ log.Warn("MaxAttemptLimit is set to 0, defaulting to no limit for attempts")`
`165`	`166`	`config.MaxAttemptLimit = -1`
`166`	`167`	`}`
`167`	`168`