Clarification on PR #4195 (code removal confusion) #4786
Unanswered
Aqil-Ahmad
asked this question in
Q&A
Replies: 1 comment
-
Sorry, didn't notice that PR was locked. Unlocked. As far as I can see, change originates from commit 1446d59 If you have trouble with that one, I will doublecheck code tommorow, squash then remove that part, since everything else seems to be in order. |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
Hi @akleshchev,
In PR #4195 you mentioned that I removed the code part. I want to clarify that I didn’t actually remove it — the change may have appeared due to a merge/rebase effect after upgrading to develop. I haven’t modified this file since your changes in develop, and the code section still exists further down in the file if you view the complete file.
Since the PR is locked, I’m posting here for clarification. Please let me know if I should open a follow-up PR to fix this if needed.
Beta Was this translation helpful? Give feedback.
All reactions