-
Notifications
You must be signed in to change notification settings - Fork 126
Add volume for home directory to the build pod #1998
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add volume for home directory to the build pod #1998
Conversation
2c2d1a9 to
15c0c5a
Compare
|
Part of #1969 |
15c0c5a to
d520bcd
Compare
|
The changes looks clean and simple, it seems that it relies on previous changes (ie. Nothing to comment on, but would be better to have a second opinion. |
d1a7fb2 to
62990ff
Compare
Each container gets its own isolated emptyDir volume mounted at "/shp-writeable-home", to remove writes to the container's rootfs. Should be isolated volumes since when step 1 runs as user A but step 2 as user B, there will permission issues if this directory is shared. For Git SSH, it would actually mean that we put a private key on disk which is then unnecessarily visible Signed-off-by: Hasan Awad <[email protected]>
62990ff to
cc35fe9
Compare
|
@adambkaplan @SaschaSchwarze0 is it ok if we merge this ? This is one pr away from us closing #1969 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
Accepting as a feature to add to Shipwright
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adambkaplan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
d8447f9
into
shipwright-io:main
Each container gets its own isolated emptyDir volume mounted at "/shp-writeable-home", to remove writes to the container's rootfs. Should be isolated volumes since when step 1 runs as user A but step 2 as user B, there will permission issues if this directory is shared. For Git SSH, it would actually mean that we put a private key on disk which is then unnecessarily visible
Changes
HOMEenv value forsource,build,image-processingcontainers.Submitter Checklist
See the contributor guide
for details on coding conventions, github and prow interactions, and the code review process.
Release Notes