From 4c26996e1f195597c50d60888900919410a2dc53 Mon Sep 17 00:00:00 2001 From: rxinui Date: Sun, 11 May 2025 01:56:41 +0200 Subject: [PATCH] fix: replace ptr.To("") by new(string) Signed-off-by: rxinui --- pkg/shp/flags/build.go | 12 ++++++------ pkg/shp/flags/build_test.go | 4 ++-- pkg/shp/flags/buildrun.go | 8 ++++---- pkg/shp/flags/buildrun_test.go | 2 +- 4 files changed, 13 insertions(+), 13 deletions(-) diff --git a/pkg/shp/flags/build.go b/pkg/shp/flags/build.go index b1b7ff47d..80ae86a90 100644 --- a/pkg/shp/flags/build.go +++ b/pkg/shp/flags/build.go @@ -18,14 +18,14 @@ func BuildSpecFromFlags(flags *pflag.FlagSet) (*buildv1beta1.BuildSpec, *string, pruneOption := buildv1beta1.PruneNever spec := &buildv1beta1.BuildSpec{ Source: &buildv1beta1.Source{ - ContextDir: ptr.To(""), + ContextDir: new(string), Git: &buildv1beta1.Git{ - Revision: ptr.To(""), - CloneSecret: ptr.To(""), + Revision: new(string), + CloneSecret: new(string), }, OCIArtifact: &buildv1beta1.OCIArtifact{ Prune: &pruneOption, - PullSecret: ptr.To(""), + PullSecret: new(string), }, }, Strategy: buildv1beta1.Strategy{ @@ -33,7 +33,7 @@ func BuildSpecFromFlags(flags *pflag.FlagSet) (*buildv1beta1.BuildSpec, *string, }, Output: buildv1beta1.Image{ Insecure: ptr.To(false), - PushSecret: ptr.To(""), + PushSecret: new(string), Labels: map[string]string{}, Annotations: map[string]string{}, }, @@ -45,7 +45,7 @@ func BuildSpecFromFlags(flags *pflag.FlagSet) (*buildv1beta1.BuildSpec, *string, TTLAfterSucceeded: &metav1.Duration{}, }, NodeSelector: map[string]string{}, - SchedulerName: ptr.To(""), + SchedulerName: new(string), } sourceFlags(flags, spec.Source) diff --git a/pkg/shp/flags/build_test.go b/pkg/shp/flags/build_test.go index 1ed34f90a..6ca5bd124 100644 --- a/pkg/shp/flags/build_test.go +++ b/pkg/shp/flags/build_test.go @@ -195,7 +195,7 @@ func TestSanitizeBuildSpec(t *testing.T) { name: "should clean-up `.spec.source.credentials`", in: buildv1beta1.BuildSpec{Source: &buildv1beta1.Source{ Git: &buildv1beta1.Git{ - CloneSecret: ptr.To(""), + CloneSecret: new(string), }, }}, out: buildv1beta1.BuildSpec{}, @@ -237,7 +237,7 @@ func TestSanitizeBuildSpec(t *testing.T) { name: "should clean-up an empty source contextDir", in: buildv1beta1.BuildSpec{ Source: &buildv1beta1.Source{ - ContextDir: ptr.To(""), + ContextDir: new(string), }, }, out: buildv1beta1.BuildSpec{}, diff --git a/pkg/shp/flags/buildrun.go b/pkg/shp/flags/buildrun.go index 2ce262ab0..b63583cd1 100644 --- a/pkg/shp/flags/buildrun.go +++ b/pkg/shp/flags/buildrun.go @@ -13,12 +13,12 @@ import ( func BuildRunSpecFromFlags(flags *pflag.FlagSet) *buildv1beta1.BuildRunSpec { spec := &buildv1beta1.BuildRunSpec{ Build: buildv1beta1.ReferencedBuild{ - Name: ptr.To(""), + Name: new(string), }, - ServiceAccount: ptr.To(""), + ServiceAccount: new(string), Timeout: &metav1.Duration{}, Output: &buildv1beta1.Image{ - PushSecret: ptr.To(""), + PushSecret: new(string), Insecure: ptr.To(false), Labels: map[string]string{}, Annotations: map[string]string{}, @@ -29,7 +29,7 @@ func BuildRunSpecFromFlags(flags *pflag.FlagSet) *buildv1beta1.BuildRunSpec { TTLAfterSucceeded: &metav1.Duration{}, }, NodeSelector: map[string]string{}, - SchedulerName: ptr.To(""), + SchedulerName: new(string), } buildRefFlags(flags, &spec.Build) diff --git a/pkg/shp/flags/buildrun_test.go b/pkg/shp/flags/buildrun_test.go index 494be4bbc..a2eec49c0 100644 --- a/pkg/shp/flags/buildrun_test.go +++ b/pkg/shp/flags/buildrun_test.go @@ -128,7 +128,7 @@ func TestSanitizeBuildRunSpec(t *testing.T) { out: buildv1beta1.BuildRunSpec{}, }, { name: "should clean-up service-account", - in: buildv1beta1.BuildRunSpec{ServiceAccount: ptr.To("")}, + in: buildv1beta1.BuildRunSpec{ServiceAccount: new(string)}, out: buildv1beta1.BuildRunSpec{}, }, { name: "should clean-up output",