Enable all cops

Author: shreyasbharath

.gitattributes

@@ -0,0 +1,2 @@
+# Set the default behavior, in case people don't have core.autocrlf set.
+* text=auto

.rubocop.yml

@@ -1,54 +1,8 @@
+inherit_from: .rubocop_todo.yml
+
 AllCops:
   TargetRubyVersion: 2.5
-  DisabledByDefault: true
+  DisabledByDefault: false
 
 Metrics/LineLength:
-  Enabled: true
   Max: 140
-
-Style/HashSyntax:
-  Enabled: true
-
-Style/StringLiterals:
-  Enabled: true
-  EnforcedStyle: single_quotes
-
-Style/MultilineIfThen:
-  Enabled: true
-
-Style/MethodDefParentheses:
-  Enabled: true
-
-Style/BracesAroundHashParameters:
-  Enabled: true
-
-Layout/IndentationWidth:
-  Enabled: true
-
-Layout/Tab:
-  Enabled: true
-
-Layout/EmptyLines:
-  Enabled: true
-
-Layout/TrailingBlankLines:
-  Enabled: true
-
-Layout/TrailingWhitespace:
-  Enabled: true
-
-Layout/SpaceBeforeBlockBraces:
-  Enabled: true
-
-Layout/SpaceInsideBlockBraces:
-  Enabled: true
-
-Layout/SpaceInsideHashLiteralBraces:
-  Enabled: true
-
-Layout/CaseIndentation:
-  Enabled: true
-
-Layout/EndAlignment:
-  Enabled: true
-  EnforcedStyleAlignWith: variable

.rubocop_todo.yml

@@ -0,0 +1,21 @@
+# This configuration was generated by
+# `rubocop --auto-gen-config`
+# on 2018-04-08 15:14:25 +1200 using RuboCop version 0.54.0.
+# The point is for the user to remove these configuration records
+# one by one as the offenses are removed from the code base.
+# Note that changes in the inspected code, or installation of new
+# versions of RuboCop, may require this file to be generated again.
+
+# Offense count: 1
+Metrics/AbcSize:
+  Max: 19
+
+# Offense count: 2
+# Configuration parameters: CountComments, ExcludedMethods.
+Metrics/BlockLength:
+  Max: 32
+
+# Offense count: 1
+Style/MixinUsage:
+  Exclude:
+    - 'exe/cpp_dependency_graph'

.vscode/launch.json

@@ -24,7 +24,7 @@
       "pathToBundler": "C:/tools/ruby25/bin/bundle.bat",
       "pathToRDebugIDE": "C:/tools/ruby25/bin/rdebug-ide.bat",
       "showDebuggerOutput": true,
-      "args": ["visualise", "--root_dir", "../protobuf/src"]
+      "args": ["visualise", "-r", "../TileDB", "-f", "dot"]
     },
     {
       "name": "Listen for rdebug-ide",

Gemfile

@@ -2,6 +2,6 @@
 
 source 'https://rubygems.org'
 
-git_source(:github) { |repo_name| 'https://github.com/shreyasbharath/cpp_dependency_graph' }
+git_source(:github) { |_| 'https://github.com/shreyasbharath/cpp_dependency_graph' }
 
 gemspec

Rakefile

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'bundler/gem_tasks'
 require 'rspec/core/rake_task'
 require 'rubocop/rake_task'

TODO.md

@@ -5,6 +5,7 @@
   - [ ] Create a github.io homepage
   - [ ] Add interactive `html` or `svg` examples to homepage
   - [ ] Add a [CONTRIBUTING.md](https://github.com/nayafia/contributing-template/blob/master/CONTRIBUTING-template.md)
+  - [ ] Ruby gem docs
 - [ ] Progress messages
   - [ ] Progress bar?
 - [x] Allow user to specify a single component and the tool should print only that component
@@ -32,6 +33,8 @@
 - [ ] Visualisation
   - [ ] Highlight strongly coupled components (i.e. have lots of outgoing/incoming dependencies). How to visualise strongly coupled components?
   - [ ] Interface vs implementation coupling (interface is worse!). Highlighting interface vs implementation coupling between components on graph?
+  - [ ] Hierarchy diagram for components with no cycles? (https://bl.ocks.org/mbostock/4339184)
+  - [ ] Pack diagram for just visualising components (https://bl.ocks.org/mbostock/ca5b03a33affa4160321)
   - [ ] Look at using subgraphs of the dot/svg language to cluster component dependencies in the graph
   - [ ] Create a d3 donut graph with relative sizes of components in project? This'll probably show which components need to be further split up (something like this https://blog.kathyreid.id.au/2016/12/29/linux-australia-expense-breakdown-a-data-visualisation-in-d3-js/)
   - [ ] Node size - base it on how many source files (or lines of code) or how many connections going in/out of node?

bin/console

@@ -1,5 +1,7 @@
 #!/usr/bin/env ruby
 
+# frozen_string_literal: true
+
 require 'bundler/setup'
 require 'cpp_dependency_graph'
 

cpp_dependency_graph.gemspec

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-lib = File.expand_path('../lib', __FILE__)
+lib = File.expand_path('lib', __dir__)
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 
 require 'cpp_dependency_graph/version'
@@ -9,7 +9,7 @@ Gem::Specification.new do |s|
   s.name = 'cpp_dependency_graph'
   s.version = CppDependencyGraph::VERSION
   s.authors = ['Shreyas Balakrishna']
-  s.email = ['shreyasbharath@users.noreply.github.com>']
+  s.email = ['shreyasbharath@gmail.com']
   s.summary = <<-SUMMARY
   CppDependencyGraph is a program that generates dependency visualisations (dot, d3.js) to study the architecture of C/C++ projects
   SUMMARY
@@ -19,7 +19,7 @@ Gem::Specification.new do |s|
   s.homepage = 'https://github.com/shreyasbharath/cpp_dependency_graph'
   s.licenses = ['MIT']
 
-  s.files = %x[git ls-files -z].split("\x0").reject { |f| f.match(%r{^(test|spec|features)/}) } -
+  s.files = `git ls-files -z`.split("\x0").reject { |f| f.match(%r{^(test|spec|features)/}) } -
             %w[.rubocop.yml .travis.yml appveyor.yml]
   s.bindir = 'exe'
   s.executables = s.files.grep(%r{^exe/}) { |f| File.basename(f) }
@@ -39,6 +39,6 @@ Gem::Specification.new do |s|
   s.add_development_dependency 'rake', '~> 12.3'
   s.add_development_dependency 'rspec', '~> 3.7'
   s.add_development_dependency 'rubocop', '~> 0.54'
-  s.add_development_dependency 'ruby-prof', '~> 0.17'
   s.add_development_dependency 'ruby-debug-ide', '~> 0.6'
+  s.add_development_dependency 'ruby-prof', '~> 0.17'
 end

exe/cpp_dependency_graph

@@ -1,5 +1,7 @@
 #!/usr/bin/env ruby
 
+# frozen_string_literal: true
+
 #--
 # Copyright (c) 2018 Shreyas Balakrishna
 
@@ -53,12 +55,12 @@ DOCOPT
 begin
   args = Docopt.docopt(doc)
 
-  if (args['--version'])
+  if args['--version']
     puts VERSION
     Kernel.exit(0)
   end
 
-  project_dir = args['--root_dir'].gsub(/\\/,'/')
+  project_dir = args['--root_dir'].tr('\\', '/')
 
   unless File.directory?(project_dir)
     puts('Not a valid project source directory')