From 34863dba47c966f6a2abc0012c4f84f7599ae60c Mon Sep 17 00:00:00 2001
From: Remi Andruccioli <remi.andruccioli@gmail.com>
Date: Thu, 13 Feb 2025 21:46:50 +0100
Subject: [PATCH] To compare string ignoring case, use the option
 StringComparison.OrdinalIgnoreCase instead of converting the case of the
 whole string.

---
 src/core/SIP/SIPEndPoint.cs            | 10 +++++-----
 src/core/SIPEvents/SIPEventPackages.cs | 18 ++++++++----------
 2 files changed, 13 insertions(+), 15 deletions(-)

diff --git a/src/core/SIP/SIPEndPoint.cs b/src/core/SIP/SIPEndPoint.cs
index ac5a02f69..8d682d24a 100644
--- a/src/core/SIP/SIPEndPoint.cs
+++ b/src/core/SIP/SIPEndPoint.cs
@@ -137,11 +137,11 @@ public static SIPEndPoint ParseSIPEndPoint(string sipEndPointStr)
                 return null;
             }
 
-            if (sipEndPointStr.ToLower().StartsWith("udp:") ||
-                sipEndPointStr.ToLower().StartsWith("tcp:") ||
-                sipEndPointStr.ToLower().StartsWith("tls:") ||
-                sipEndPointStr.ToLower().StartsWith("ws:") ||
-                sipEndPointStr.ToLower().StartsWith("wss:"))
+            if (sipEndPointStr.StartsWith("udp:", StringComparison.OrdinalIgnoreCase) ||
+                sipEndPointStr.StartsWith("tcp:", StringComparison.OrdinalIgnoreCase) ||
+                sipEndPointStr.StartsWith("tls:", StringComparison.OrdinalIgnoreCase) ||
+                sipEndPointStr.StartsWith("ws:", StringComparison.OrdinalIgnoreCase)  ||
+                sipEndPointStr.StartsWith("wss:", StringComparison.OrdinalIgnoreCase))
             {
                 return ParseSerialisedSIPEndPoint(sipEndPointStr);
             }
diff --git a/src/core/SIPEvents/SIPEventPackages.cs b/src/core/SIPEvents/SIPEventPackages.cs
index 9159fe5dd..3f8101566 100644
--- a/src/core/SIPEvents/SIPEventPackages.cs
+++ b/src/core/SIPEvents/SIPEventPackages.cs
@@ -163,16 +163,14 @@ public static bool IsValid(string value)
             {
                 return false;
             }
-            else if (value.ToLower() == "cancelled" || value.ToLower() == "error" || value.ToLower() == "local-bye" ||
-                value.ToLower() == "rejected" || value.ToLower() == "replaced" || value.ToLower() == "remote-bye" ||
-                value.ToLower() == "timeout")
-            {
-                return true;
-            }
-            else
-            {
-                return false;
-            }
+
+            return value.Equals("cancelled", StringComparison.OrdinalIgnoreCase)  ||
+                   value.Equals("error", StringComparison.OrdinalIgnoreCase)      ||
+                   value.Equals("local-bye", StringComparison.OrdinalIgnoreCase)  ||
+                   value.Equals("rejected", StringComparison.OrdinalIgnoreCase)   ||
+                   value.Equals("replaced", StringComparison.OrdinalIgnoreCase)   ||
+                   value.Equals("remote-bye", StringComparison.OrdinalIgnoreCase) ||
+                   value.Equals("timeout", StringComparison.OrdinalIgnoreCase);
         }
 
         public static SIPEventDialogStateEvent Parse(string value)