Ensure version metadata is bumped before tags are created

[matthewfeickert]

@ArturU043 @RogerJanusiak Can you make sure that the version bump happens before the version tag? Otherwise you end up with the version metadata getting distributed being things like 1.2.0a, which is wrong.

c.f. 1.1.1...1.2.0

Originally posted by @matthewfeickert in 47c9c9a

[matthewfeickert]

Noticed in conda-forge/servicex-analysis-utils-feedstock#7

[ArturU043]

The 1.2.0a was an intentional alpha tag I released last week

I just now released one from 1.2.0a to 1.2.0

Did these tags conflict for some reason?

The GHA for publishing is updating this version in the pyproject.toml, from the new GH release, before building anything and publishing to PyPi.

is adding this ´a´ to the version tag a problem for conda-forge?

I dont know why the recipe.yaml was at version: "1.1.1" still

[matthewfeickert]

@ArturU043 The point is that the tag in GitHub should have 1-to-1 correspondence with the released artifact. At the moment that is not happening as at tag v1.2.0 the version metadata is

ServiceX_analysis_utils/pyproject.toml

Line 7 in 2aa3eed

version = "1.2.0a"

These opertations

ServiceX_analysis_utils/.github/workflows/pypi.yml

Lines 29 to 35 in 47c9c9a

	- name: Set env
	run: echo "RELEASE_VERSION=${GITHUB_REF#refs/*/}" >> $GITHUB_ENV
	- name: Update Version
	run: |
	sed -i 's/^version\s*=\s*".*"/version = "${{ env.RELEASE_VERSION }}"/' pyproject.toml
	sed -i '/__version__/ s/__version__\s*=.*/__version__ = "${{ env.RELEASE_VERSION }}"/' servicex_analysis_utils/__init__.py

should not happen in the same workflow that is distributing the release to PyPI.

I don't know why the recipe.yaml was at version: "1.1.1" still

Because that was the last stable release.

[ArturU043]

We made this "update pyproject.toml tag to on new GH release" to make sure we build and distribute the Pypi package with the correct version tag without needing to make version-bump PRs.
It's the same for the front_end:
https://github.com/ssl-hep/ServiceX_frontend/blob/master/.github/workflows/pypi.yaml#L48

The metadata in the published Pypi packages match the GH releases.

Is the conda-forge issue because the version bump in the .toml is applied only after releasing?
Should we avoid version bumps on release and do them before?

Also, I don't understand why this has not been problematic before. It's been running this way for some time now...