Skip to content

Conversation

@jfroche
Copy link
Collaborator

@jfroche jfroche commented Jul 21, 2025

Use one recent version of nixpkgs in the flake inputs.

a76c4553d7e741e17f289224eda135423de0491d -> 9807714d6944a957c2e036f84b0ff8caf9930bc0

@jfroche jfroche force-pushed the update-nixpkgs branch 2 times, most recently from a3275e8 to 98633c4 Compare July 21, 2025 22:29
@jfroche jfroche marked this pull request as ready for review July 22, 2025 13:39
@jfroche jfroche requested review from a team as code owners July 22, 2025 13:39
@samrose
Copy link
Collaborator

samrose commented Aug 8, 2025

rebased on develop, and will e2e test ami for each major version

@samrose samrose force-pushed the update-nixpkgs branch 2 times, most recently from c061085 to 07fb5e2 Compare September 2, 2025 13:28
@samrose samrose force-pushed the update-nixpkgs branch 2 times, most recently from 6b51806 to a33cf5d Compare September 10, 2025 17:58
@samrose samrose force-pushed the update-nixpkgs branch 2 times, most recently from 37962e0 to 52722b1 Compare November 18, 2025 15:45
@yvan-sraka yvan-sraka self-assigned this Nov 19, 2025
@yvan-sraka yvan-sraka marked this pull request as draft November 19, 2025 21:13
jfroche and others added 22 commits November 21, 2025 11:39
The previously used version was failing to build:

/build/source/src/common/get_check_data.c: In function 'pgr_SPI_getText':
/build/source/src/common/get_check_data.c:307:28: error: passing argument 1 of 'DatumGetCString' makes integer from pointer without a cast [-Wint-conversion]
  307 |     return DatumGetCString(SPI_getvalue(*tuple, *tupdesc, info.colNumber));
      |                            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      |                            |
      |                            char *
In file included from /build/source/include/c_common/postgres_connection.h:29,
                 from /build/source/src/common/get_check_data.c:27:
/nix/store/nn6vpjqlsxxmynwcrsib9agb3hpr5cqj-postgresql-17.4/include/server/postgres.h:335:23: note: expected 'Datum' {aka 'long unsigned int'} but argument is of type 'char *'
  335 | DatumGetCString(Datum X)
      |                 ~~~~~~^
make[2]: *** [src/common/CMakeFiles/common.dir/build.make:149: src/common/CMakeFiles/common.dir/get_check_data.c.o] Error 1
We cannot use nodejs.libv8 as it is too new for plv8 3.1.
We will be able to use it with plv8 3.2.
Backport upstream commit to remove the deprecated darwin framework: NixOS/nixpkgs#398707
dbmate 2.27 is now using a varchar for the version column in the
schema_migrations table.

See amacneil/dbmate#641
Copy link
Collaborator

@samrose samrose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

adding request changes just to stop merge until fully tested

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants