Skip to content

Commit 683e69e

Browse files
authored
fix(storage): analytics bucket prop (#1852)
1 parent d30607e commit 683e69e

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

packages/core/storage-js/src/lib/types.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ export interface ListBucketOptions {
3333
*/
3434
export interface AnalyticBucket {
3535
/** Unique identifier for the bucket */
36-
id: string
36+
name: string
3737
/** Bucket type - always 'ANALYTICS' for analytics buckets */
3838
type: 'ANALYTICS'
3939
/** Storage format used (e.g., 'iceberg') */

packages/core/storage-js/src/packages/StorageAnalyticsApi.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ import { DEFAULT_HEADERS } from '../lib/constants'
22
import { isStorageError, StorageError } from '../lib/errors'
33
import { Fetch, get, post, remove } from '../lib/fetch'
44
import { resolveFetch } from '../lib/helpers'
5-
import { AnalyticBucket, Bucket } from '../lib/types'
5+
import { AnalyticBucket } from '../lib/types'
66

77
/**
88
* API class for managing Analytics Buckets using Iceberg tables
@@ -154,7 +154,7 @@ export default class StorageAnalyticsApi {
154154
* A bucket can't be deleted with existing objects inside it
155155
* You must first empty the bucket before deletion
156156
*
157-
* @param bucketId The unique identifier of the bucket you would like to delete
157+
* @param bucketName The unique identifier of the bucket you would like to delete
158158
* @returns Promise with success message or error
159159
*
160160
* @example
@@ -167,7 +167,7 @@ export default class StorageAnalyticsApi {
167167
* }
168168
* ```
169169
*/
170-
async deleteBucket(bucketId: string): Promise<
170+
async deleteBucket(bucketName: string): Promise<
171171
| {
172172
data: { message: string }
173173
error: null
@@ -180,7 +180,7 @@ export default class StorageAnalyticsApi {
180180
try {
181181
const data = await remove(
182182
this.fetch,
183-
`${this.url}/bucket/${bucketId}`,
183+
`${this.url}/bucket/${bucketName}`,
184184
{},
185185
{ headers: this.headers }
186186
)

0 commit comments

Comments
 (0)