fix(sw360_objects): correct component ids in embedded releases

We can only set component_id if releases are embedded in components, but
not for releases in projects.

As this was a somehow tricky bug, let's add first testcases for it.

Author: gernot-h

sw360/sw360_objects.py

@@ -72,9 +72,12 @@ def _parse_link(self, key, links_key, links_value):
                 links_value,
                 resources=[self])
         elif links_key == "sw360:releases":
+            component_id = None
+            if isinstance(self, Component):
+                component_id = self.id
             self.releases = self._parse_release_list(
                 links_value,
-                component_id=self.id)
+                component_id=component_id)
         elif links_key == "self":
             self.id = links_value["href"].split("/")[-1]
         else:

tests/test_sw360obj_base.py

@@ -0,0 +1,17 @@
+import unittest
+import responses
+from sw360 import SW360
+
+
+SW360_BASE_URL = "https://sw360.siemens.com/resource/api/"
+
+
+class Sw360ObjTestBase(unittest.TestCase):
+    @responses.activate
+    def setUp(self):
+        responses.add(
+            responses.GET,
+            SW360_BASE_URL,
+            json={"status": "ok"})
+        self.lib = SW360("https://sw360.siemens.com", "mytoken")
+        self.lib.login_api()

tests/test_sw360obj_component.py

@@ -0,0 +1,30 @@
+import responses
+import unittest
+from tests.test_sw360obj_base import Sw360ObjTestBase, SW360_BASE_URL
+from sw360 import Component
+
+
+class Sw360ObjTestComponent(Sw360ObjTestBase):
+    @responses.activate
+    def test_get_component(self):
+        responses.add(
+            responses.GET,
+            SW360_BASE_URL + "components/123",
+            json={
+                'name': 'acl',
+                'somekey': 'value',
+                '_embedded': {
+                    'sw360:releases': [{
+                        'name': 'acl',
+                        'version': '2.2',
+                        '_links': {'self': {
+                            'href': SW360_BASE_URL + 'releases/7c4'}}}]}})
+        comp = Component().get(self.lib, "123")
+        self.assertEqual(comp.name, "acl")
+        self.assertEqual(comp.details["somekey"], "value")
+        self.assertEqual(len(comp.releases), 1)
+        self.assertEqual(comp.releases["7c4"].component_id, "123")
+
+
+if __name__ == "__main__":
+    unittest.main()

tests/test_sw360obj_project.py

@@ -0,0 +1,30 @@
+import responses
+import unittest
+from tests.test_sw360obj_base import Sw360ObjTestBase, SW360_BASE_URL
+from sw360 import Project
+
+
+class Sw360ObjTestProject(Sw360ObjTestBase):
+    @responses.activate
+    def test_get_project(self):
+        responses.add(
+            responses.GET,
+            SW360_BASE_URL + "projects/123",
+            json={
+                'name': 'MyProj',
+                'version': '11.0',
+                '_embedded': {
+                    'sw360:releases': [{
+                        'name': 'acl',
+                        'version': '2.2',
+                        '_links': {'self': {
+                            'href': SW360_BASE_URL + 'releases/7c4'}}}]}})
+        proj = Project().get(self.lib, "123")
+        self.assertEqual(proj.name, "MyProj")
+        self.assertEqual(proj.version, "11.0")
+        self.assertEqual(len(proj.releases), 1)
+        self.assertIsNone(proj.releases["7c4"].component_id)
+
+
+if __name__ == "__main__":
+    unittest.main()